f2fs: fix to allow node segment for GC by ioctl path
PATCH v2 1/1 f2fs: fix to allow node segment for GC by ioctl path
Allow node type segments also to be GC'd via f2fs ioctl F2FS_IOC_GARBAGE_COLLECT_RANGE.
Signed-off-by Sahitya Tummala <[email protected]>
---
v2:
update commit message
fs/f2fs/gc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
fs/f2fs/gc.c +4 -4
@@ -323,8 +323,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, p.min_cost =get_max_cost (sbi, &p);if (*result !=NULL_SEGNO ) { -if (IS_DATASEG (get_seg_entry (sbi, *result)->type) && -get_valid_blocks (sbi, *result, false) && +if (get_valid_blocks (sbi, *result, false) && !sec_usage_check (sbi,GET_SEC_FROM_SEG (sbi, *result))) p.min_segno = *result; goto out;
@@ -404,11 +403,12 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, } *result = (p.min_segno / p.ofs_unit) * p.ofs_unit; + } +out: +if (p.min_segno !=NULL_SEGNO )trace_f2fs_get_victim (sbi->sb, type, gc_type, &p, sbi->cur_victim_sec,prefree_segments (sbi),free_segments (sbi)); - } -out:mutex_unlock (&dirty_i->seglist_lock);return (p.min_segno ==NULL_SEGNO ) ?0 :1 ;
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 16 lines · Sahitya Tummala
Allow node type segments also to be GC'd via f2fs ioctl
F2FS_IOC_GARBAGE_COLLECT_RANGE.Signed-off-by Sahitya Tummala <[email protected]>---
v2:
update commit messagefs/f2fs/gc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)fs/f2fs/gc.c +0
-0
fs/f2fs/gc.c static int get_victim_by_default(struct f2fs_sb_info *sbi, · line 326
Quoted 6 lines
fs/f2fs/gc.c +1
-2@@ -323,8 +323,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, p.min_cost =get_max_cost (sbi, &p);if (*result !=NULL_SEGNO ) { - if (IS_DATASEG(get_seg_entry(sbi, *result)->type) && - get_valid_blocks(sbi, *result, false) && + if (get_valid_blocks(sbi, *result, false) &&
I'm okay with above commit message and change, but how about separating below change into another patch?
Reviewed-by Chao Yu <[email protected]>
Thanks,
Quoted 19 lines
fs/f2fs/gc.c +3
-2!sec_usage_check(sbi, GET_SEC_FROM_SEG(sbi, *result))) p.min_segno = *result; goto out;@@ -404,11 +403,12 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi, } *result = (p.min_segno / p.ofs_unit) * p.ofs_unit; + } +out: +if (p.min_segno !=NULL_SEGNO )trace_f2fs_get_victim (sbi->sb, type, gc_type, &p, sbi->cur_victim_sec,prefree_segments (sbi),free_segments (sbi)); - } -out:mutex_unlock (&dirty_i->seglist_lock);return (p.min_segno ==NULL_SEGNO ) ?0 :1 ;