xfsprogs: Define PLATFORM to linux
PATCH 1/1 xfsprogs: Define PLATFORM to linux
PLATFORM is an environment variable used by xfsprogs' configure script to determine the platform for which the applications are being built. If we set some incorrect/unsupported value through e.g: export, this will be picked up by xfsprogs' configure script and used as-is and assigned to PKG_PLATFORM, which will lead to build failures.
If PLATFORM was empty/unset, then uname on the host building xfsprogs gets used to determine the build platform, which again could be incorrect if we e.g: built xfsprogs on a Darwin system.
Since we are obviously building for Linux, let's just make sure we define it that way which solves both issues.
--- package/xfsprogs/xfsprogs.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/xfsprogs/xfsprogs.mk +1 -1
@@ -12,7 +12,7 @@ XFSPROGS_LICENSE_FILES = LICENSES/GPL-2.0 LICENSES/LGPL-2.1 XFSPROGS_DEPENDENCIES = util-linux -XFSPROGS_CONF_ENV = ac_cv_header_aio_h=yes ac_cv_lib_rt_lio_listio=yes +XFSPROGS_CONF_ENV = ac_cv_header_aio_h=yes ac_cv_lib_rt_lio_listio=yes PLATFORM="linux" XFSPROGS_CONF_OPTS = \ --enable-lib64=no \ --enable-gettext=no \
Signature · 1 line
2.7.4
PATCH 1/1 xfsprogs: Define PLATFORM to linux
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Florian" == Florian Fainelli <[email protected]> writes:
PLATFORM is an environment variable used by xfsprogs' configure script to determine the platform for which the applications are being built. If we set some incorrect/unsupported value through e.g: export, this will be picked up by xfsprogs' configure script and used as-is and assigned to
PKG_PLATFORM, which will lead to build failures.
Quoted 8 lines
If PLATFORM was empty/unset, then uname on the host building xfsprogs gets used to determine the build platform, which again could be incorrect if we e.g: built xfsprogs on a Darwin system.
Since we are obviously building for Linux, let's just make sure we define it that way which solves both issues.
Signed-off-by Florian Fainelli <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 xfsprogs: Define PLATFORM to linux
In reply to Florian FainelliQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Florian" == Florian Fainelli <[email protected]> writes:
PLATFORM is an environment variable used by xfsprogs' configure script to determine the platform for which the applications are being built. If we set some incorrect/unsupported value through e.g: export, this will be picked up by xfsprogs' configure script and used as-is and assigned to
PKG_PLATFORM, which will lead to build failures.
Quoted 8 lines
If PLATFORM was empty/unset, then uname on the host building xfsprogs gets used to determine the build platform, which again could be incorrect if we e.g: built xfsprogs on a Darwin system.
Since we are obviously building for Linux, let's just make sure we define it that way which solves both issues.
Signed-off-by Florian Fainelli <[email protected]>
Committed to 2018.02.x and 2018.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard