qcom_adsp_pil: Remove voting for lpass_aon clock

PATCH In review Rohit kumar 3 participants 9 messages Nov 30, 2018 – Feb 18, 2019

Subsystems (3)

Device tree bindings Arm Qualcomm mailing list Remote processor (remoteproc)

lore

Share & tools

lore

Rohit kumar

author

2018-11-30 07:29 UTC #0 lore raw

cover qcom_adsp_pil: Remove voting for lpass_aon clock

LPASS Audio Wrapper AON clock is on by default. Remove voting for it.

Rohit kumar (2):
dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock
list
remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

 Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
 drivers/remoteproc/qcom_q6v5_adsp.c                            | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

Signature · 2 lines

Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

Rohit kumar

author

2018-11-30 07:29 UTC #1 lore raw

PATCH 1/2 dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list

LPASS_Audio_Wrapper_AON clock is on by default. Remove it from lpass clock list to avoid voting for it.

Signed-off-by Rohit kumar <[email protected]>

---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt +2 -3

index a842a78..66af2c3 100644
@@ -35,7 +35,7 @@ on the Qualcomm Technology Inc. ADSP Hexagon core.
 	Value type: <stringlist>
 	Definition: List of clock input name strings sorted in the same
 		    order as the clocks property. Definition must have
-		    "xo", "sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr",
+		    "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
 		    "lpass_ahbm_aon_cbcr", "qdsp6ss_xo", "qdsp6ss_sleep"
 		    and "qdsp6ss_core".

@@ -100,13 +100,12 @@ ADSP, as it is found on SDM845 boards.
 
 		clocks = <&rpmhcc RPMH_CXO_CLK>,
 			<&gcc GCC_LPASS_SWAY_CLK>,
-			<&lpasscc LPASS_AUDIO_WRAPPER_AON_CLK>,
 			<&lpasscc LPASS_Q6SS_AHBS_AON_CLK>,
 			<&lpasscc LPASS_Q6SS_AHBM_AON_CLK>,
 			<&lpasscc LPASS_QDSP6SS_XO_CLK>,
 			<&lpasscc LPASS_QDSP6SS_SLEEP_CLK>,
 			<&lpasscc LPASS_QDSP6SS_CORE_CLK>;
-		clock-names = "xo", "sway_cbcr", "lpass_aon",
+		clock-names = "xo", "sway_cbcr",
 			"lpass_ahbs_aon_cbcr",
 			"lpass_ahbm_aon_cbcr", "qdsp6ss_xo",
 			"qdsp6ss_sleep", "qdsp6ss_core";

Signature · 2 lines

Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

Rob Herring

maintainer Reviewed-by on v1 1/2

2018-12-12 02:32 UTC #2 lore raw

Re: [PATCH 1/2] dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock list

Quoted 8 lines · Rohit kumar

LPASS_Audio_Wrapper_AON clock is on by default. Remove it from lpass clock list to avoid voting for it.
Signed-off-by Rohit kumar <[email protected]>
---
 Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by Rob Herring <[email protected]>

Rohit kumar

author

2018-11-30 07:29 UTC #3 lore raw

PATCH 2/2 remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

In reply to Rohit kumar

Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it.

Signed-off-by Rohit kumar <[email protected]>

---
 drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/remoteproc/qcom_q6v5_adsp.c +1 -1

index 79374d1..4829173 100644
@@ -48,7 +48,7 @@
 
 /* list of clocks required by ADSP PIL */
 static const char * const adsp_clk_id[] = {
-	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
+	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
 	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
 };

Signature · 2 lines

Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

Rohit Kumar

author

2019-01-04 04:36 UTC #4 lore raw

Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

Hello Bjorn,

Can you please review this patch series too.

LPASS_AON clock support is already removed from lpass clock driver.

Thanks,

Rohit

Quoted 21 lines · Rohit kumar

Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it.

Signed-off-by Rohit kumar <[email protected]>

---
  drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/remoteproc/qcom_q6v5_adsp.c +1 -1

index 79374d1..4829173 100644
@@ -48,7 +48,7 @@
 
  /* list of clocks required by ADSP PIL */
  static const char * const adsp_clk_id[] = {
-	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
+	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
  	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
  };

Signature · 2 lines

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Bjorn Andersson

2019-01-07 07:13 UTC #5 lore raw

Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

Quoted 6 lines · Rohit Kumar

Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.

Applied the two patches.

Thanks,
Bjorn

Quoted 30 lines

Thanks,

Rohit

Quoted 19 lines · Rohit kumar

Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it.

Signed-off-by Rohit kumar <[email protected]>

---
  drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/remoteproc/qcom_q6v5_adsp.c +1 -1

index 79374d1..4829173 100644
@@ -48,7 +48,7 @@
  /* list of clocks required by ADSP PIL */
  static const char * const adsp_clk_id[] = {
-	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
+	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
  	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
  };

Signature · 2 lines

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Rohit Kumar

author

2019-01-14 10:44 UTC #6 lore raw

Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

Quoted 9 lines · Bjorn Andersson

Quoted 6 lines · Rohit Kumar
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the two patches.

Hello Bjorn,

Can you please point me to the tree where this is applied.

Thanks,

Rohit

Quoted 31 lines

Thanks,
Bjorn

Quoted 28 lines

Thanks,

Rohit

Quoted 19 lines · Rohit kumar

Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it.

Signed-off-by Rohit kumar <[email protected]>

---
   drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

drivers/remoteproc/qcom_q6v5_adsp.c +1 -1

index 79374d1..4829173 100644
@@ -48,7 +48,7 @@
   /* list of clocks required by ADSP PIL */
   static const char * const adsp_clk_id[] = {
-	"sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
+	"sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
   	"qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
   };

Signature · 2 lines

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Signature · 2 lines

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Rohit Kumar

author

2019-01-30 05:08 UTC #7 lore raw

Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

Hello Bjorn,

Quoted 4 lines · Rohit Kumar

Quoted 2 lines · Bjorn Andersson
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:

Quoted 8 lines

Quoted 7 lines
Quoted 6 lines
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the two patches.

I did not see this in next yet. Can you please pick this up.

Thanks,

Rohit

Quoted 42 lines

Hello Bjorn,
Can you please point me to the tree where this is applied.
Thanks,
Rohit
Quoted 32 lines
Thanks,
Bjorn
Quoted 29 lines
Thanks,
Rohit
Quoted 20 lines · Rohit kumar
Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it.
Signed-off-by Rohit kumar <[email protected]>
---
drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/remoteproc/qcom_q6v5_adsp.c +1 -1
index 79374d1..4829173 100644
@@ -48,7 +48,7 @@
    /* list of clocks required by ADSP PIL */
    static const char * const adsp_clk_id[] = {
-    "sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", 
 "lpass_ahbm_aon_cbcr",
+    "sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
        "qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
    };
Signature · 2 lines
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Signature · 2 lines

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Rohit Kumar

author

2019-02-18 04:54 UTC #8 lore raw

Re: [PATCH 2/2] remoteproc: q6v5_adsp: Remove voting for lpass_aon clock

Hello Bjorn,

Quoted 15 lines · Rohit Kumar

Hello Bjorn,
Quoted 12 lines · Rohit Kumar
Quoted 9 lines · Bjorn Andersson
Quoted 6 lines · Rohit Kumar
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the two patches.

Can you please apply these patches. I don't see them in next.

Quoted 49 lines

Quoted 1 line
I did not see this in next yet. Can you please pick this up.
Thanks,
Rohit
Quoted 42 lines
Hello Bjorn,
Can you please point me to the tree where this is applied.
Thanks,
Rohit
Quoted 32 lines
Thanks,
Bjorn
Quoted 29 lines
Thanks,
Rohit
Quoted 20 lines · Rohit kumar
Lpass_aon clock is on by default. Remove it from lpass clock list to avoid voting for it.
Signed-off-by Rohit kumar <[email protected]>
---
drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/remoteproc/qcom_q6v5_adsp.c +1 -1
index 79374d1..4829173 100644
@@ -48,7 +48,7 @@
    /* list of clocks required by ADSP PIL */
    static const char * const adsp_clk_id[] = {
-    "sway_cbcr", "lpass_aon", "lpass_ahbs_aon_cbcr", 
 "lpass_ahbm_aon_cbcr",
+    "sway_cbcr", "lpass_ahbs_aon_cbcr", "lpass_ahbm_aon_cbcr",
        "qdsp6ss_xo", "qdsp6ss_sleep", "qdsp6ss_core",
    };
Signature · 2 lines
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Thanks,

Rohit

Signature · 2 lines

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.