drm/amdgpu: Fix num_doorbell calculation issue
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix num_doorbell calculation issue
When paging queue is enabled, it use the second page of doorbell. The AMDGPU_DOORBELL64_MAX_ASSIGNMENT definition assumes all the kernel doorbells are in the first page. So with paging queue enabled, the total kernel doorbell range should be original num_doorbell plus one page (0x400 in dword), not *2.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -2
@@ -539,10 +539,13 @@ static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)return -EINVAL ;/* For Vega, reserve and map two pages on doorbell BAR since SDMA -* paging queue doorbell use the second page +* paging queue doorbell use the second page. The +* AMDGPU_DOORBELL64_MAX_ASSIGNMENT definition assumes all the +* doorbells are in the first page. So with paging queue enabled, +* the max num_doorbells should + 1 page (0x400 in dword) */ if (adev->asic_type >=CHIP_VEGA10 ) - adev->doorbell.num_doorbells *=2 ; + adev->doorbell.num_doorbells +=0x400 ; adev->doorbell.ptr = ioremap(adev->doorbell.base, adev->doorbell.num_doorbells *
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1543592352-6915-1-git-send-email-ozeng-5C7GfCeVMHo@public.gmane.org
Deucher, Alexander
Reviewed-by________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Oak Zeng <[email protected]>
Sent: Friday, November 30, 2018 10:39:21 AM
To: [email protected]
Cc: Yang, Philip; Zeng, Oak; Yin, Tianci (Rico)
Subject: [PATCH] drm/amdgpu: Fix num_doorbell calculation issue
When paging queue is enabled, it use the second page of doorbell. The AMDGPU_DOORBELL64_MAX_ASSIGNMENT definition assumes all the kernel doorbells are in the first page. So with paging queue enabled, the total kernel doorbell range should be original num_doorbell plus one page (0x400 in dword), not *2.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -2
@@ -539,10 +539,13 @@ static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)return -EINVAL ;/* For Vega, reserve and map two pages on doorbell BAR since SDMA -* paging queue doorbell use the second page +* paging queue doorbell use the second page. The +* AMDGPU_DOORBELL64_MAX_ASSIGNMENT definition assumes all the +* doorbells are in the first page. So with paging queue enabled, +* the max num_doorbells should + 1 page (0x400 in dword) */ if (adev->asic_type >=CHIP_VEGA10 ) - adev->doorbell.num_doorbells *=2 ; + adev->doorbell.num_doorbells +=0x400 ; adev->doorbell.ptr = ioremap(adev->doorbell.base, adev->doorbell.num_doorbells *
--
2.7.4
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx