Skip to contentSkip to conversation

drm/msm/dpu: Fix clock issue after bind failure

PATCH In review Jayant Shekhar 2 participants 2 messages Dec 5, 2018 – Dec 6, 2018

Subsystems (3)
DRM drivers Arm Qualcomm mailing list DRM driver for Qualcomm display hardware
lore
Share & tools
lore

Jayant Shekhar

author
#0 lore raw

PATCH 1/1 drm/msm/dpu: Fix clock issue after bind failure

In case of msm drm bind failure, pm runtime put sync is called from dsi driver which issues an asynchronous put on mdss device. Subsequently when dpu_mdss_destroy is triggered the change will make sure to put the mdss device in suspend and clearing pending work if not scheduled.

Signed-off-by Jayant Shekhar <[email protected]>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +1 -0
index 2d66025..030229a 100644
@@ -191,6 +191,7 @@ static void dpu_mdss_destroy(struct drm_device *dev)
 	struct dss_module_power *mp = &dpu_mdss->mp;
 	int i;
 
+	pm_runtime_suspend(dev->dev);
 	pm_runtime_disable(dev->dev);
 	_dpu_mdss_irq_domain_fini(dpu_mdss);
 	free_irq(platform_get_irq(pdev, 0), dpu_mdss);
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reviewer
#1 lore raw
Quoted 8 lines · Jayant Shekhar

In case of msm drm bind failure, pm runtime put sync is called from dsi driver which issues an asynchronous put on mdss device. Subsequently when dpu_mdss_destroy is triggered the change will make sure to put the mdss device in suspend and clearing pending work if not scheduled.

Signed-off-by Jayant Shekhar <[email protected]>

Thanks for sending this, pushed to dpu-staging/for-next

Sean

Quoted 20 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +1 -0
index 2d66025..030229a 100644
@@ -191,6 +191,7 @@ static void dpu_mdss_destroy(struct drm_device *dev)
 	struct dss_module_power *mp = &dpu_mdss->mp;
 	int i;
 
+	pm_runtime_suspend(dev->dev);
 	pm_runtime_disable(dev->dev);
 	_dpu_mdss_irq_domain_fini(dpu_mdss);
 	free_irq(platform_get_irq(pdev, 0), dpu_mdss);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel