Skip to contentSkip to conversation

checkstack.pl: fix for aarch64

PATCH In review Qian Cai 2 participants 3 messages Dec 7, 2018

lore
Share & tools
lore

Qian Cai

author
#0 lore raw

PATCH 1/1 checkstack.pl: fix for aarch64

There is actually a space after "sp," like this,

ffff2000080813c8: a9bb7bfd stp x29, x30, [sp, #-80]!

---
 scripts/checkstack.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/checkstack.pl +2 -2
index 8081b6cf67d2..34414c6efad6 100755
@@ -47,8 +47,8 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
 	$xs	= "[0-9a-f ]";	# hex character or space
 	$funcre = qr/^$x* <(.*)>:$/;
 	if ($arch eq 'aarch64') {
-		#ffffffc0006325cc:       a9bb7bfd        stp     x29, x30, [sp,#-80]!
-		$re = qr/^.*stp.*sp,\#-([0-9]{1,8})\]\!/o;
+		#ffffffc0006325cc:       a9bb7bfd        stp     x29, x30, [sp, #-80]!
+		$re = qr/^.*stp.*sp, \#-([0-9]{1,8})\]\!/o;
 	} elsif ($arch eq 'arm') {
 		#c0008ffc:	e24dd064	sub	sp, sp, #100	; 0x64
 		$re = qr/.*sub.*sp, sp, #(([0-9]{2}|[3-9])[0-9]{2})/o;
Signature · 1 line
2.17.2 (Apple Git-113)
#1 lore raw
Quoted 4 lines · On Fri, 7 Dec 2018 14:58:43 -0500 Qian Cai <[email protected]> wrote:

There is actually a space after "sp," like this,

ffff2000080813c8: a9bb7bfd stp x29, x30, [sp, #-80]!

Confused. Why does this matter? Why is the patched version superior?

author
#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 4 lines · On Fri,  7 Dec 2018 14:58:43 -0500 Qian Cai <[email protected]> wrote:

There is actually a space after "sp," like this,

ffff2000080813c8:       a9bb7bfd        stp     x29, x30, [sp, #-80]!

Confused.  Why does this matter?  Why is the patched version superior?

<Resend in plain text.>

Right now, checkstack.pl won’t be able to  print anything on aarch64, because it won’t be able to match the stating objdump line of a function due to this missing space. Hence, it saw every stack is zero-size.

After applied this patch, checkpatch.pl is able to match the start of a function’s objdump, and then be able to calculate each function’s stack correctly.