Move TXQ scheduling and airtime fairness into mac80211
Subsystems (4)
v5 cover Move TXQ scheduling and airtime fairness into mac80211
All,
Sorry for the long delay. Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness.
Three main APIs are defined for TXQ scheduling.
- ieee80211_next_txq
- ieee80211_return_txq
- ieee80211_txq_may_transmit
and two APIs for synchronization when the driver wants to iterate through all TXQs.
- ieee80211_txq_schedule_start
- ieee80211_txq_schedule_end
The earlier discussions:
https://patchwork.kernel.org/project/linux-wireless/list/?series=&submitter=&state=*&q=TXQ+scheduling&archive=both&delegate=
-Rajkumar
v2:
- replaced driver specific airtime default by multiplier
- fixed tab intent
- fixed author and commit log
v3:
- fixed checkpatch warnings and kbuild bot errors. few of over 80 char warnings are left.
v4:
- Folded Louie's airtime counter reset change
- rebased the series on top of mac80211 tree.
v5:
- fix kbuild-robot errors (s/BIT/BIT_ULL)
Kan Yan (1):
ath10k: reporting estimated tx airtime for fairness
Toke Høiland-Jørgensen (5):
mac80211: Add TXQ scheduling API
cfg80211: Add airtime statistics and settings
mac80211: Add airtime accounting and scheduling to TXQs
ath9k: Switch to mac80211 TXQ scheduling and airtime APIs
ath10k: migrate to mac80211 txq scheduling
drivers/net/wireless/ath/ath10k/core.c | 2 - drivers/net/wireless/ath/ath10k/core.h | 8 +- drivers/net/wireless/ath/ath10k/htc.h | 1 - drivers/net/wireless/ath/ath10k/htt_rx.c | 9 ++ drivers/net/wireless/ath/ath10k/mac.c | 155 +++++++++++------- drivers/net/wireless/ath/ath10k/txrx.c | 4 + drivers/net/wireless/ath/ath9k/ath9k.h | 14 -- drivers/net/wireless/ath/ath9k/debug.c | 3 - drivers/net/wireless/ath/ath9k/debug.h | 8 - drivers/net/wireless/ath/ath9k/debug_sta.c | 70 --------- drivers/net/wireless/ath/ath9k/init.c | 3 +- drivers/net/wireless/ath/ath9k/recv.c | 9 +- drivers/net/wireless/ath/ath9k/xmit.c | 244 +++++++++-------------------- include/net/cfg80211.h | 10 +- include/net/mac80211.h | 121 +++++++++++++- include/uapi/linux/nl80211.h | 15 ++ net/mac80211/agg-tx.c | 2 +- net/mac80211/cfg.c | 3 + net/mac80211/debugfs.c | 3 + net/mac80211/debugfs_sta.c | 68 +++++++- net/mac80211/driver-ops.h | 9 ++ net/mac80211/ieee80211_i.h | 11 ++ net/mac80211/main.c | 9 ++ net/mac80211/sta_info.c | 46 +++++- net/mac80211/sta_info.h | 13 ++ net/mac80211/status.c | 6 + net/mac80211/tx.c | 140 ++++++++++++++++- net/wireless/nl80211.c | 30 ++++ 28 files changed, 662 insertions(+), 354 deletions(-)
Signature · 1 line
1.9.1
PATCH v5 1/6 mac80211: Add TXQ scheduling API
From: Toke Høiland-Jørgensen <[email protected]>
This adds an API to mac80211 to handle scheduling of TXQs. The interface between driver and mac80211 for TXQ handling is changed by adding two new
functions: ieee80211_next_txq(), which will return the next TXQ to schedule in the current round-robin rotation, and ieee80211_return_txq(), which the driver uses to indicate that it has finished scheduling a TXQ (which will then be put back in the scheduling rotation if it isn't empty).
The driver must call ieee80211_txq_schedule_start() at the start of each scheduling session, and ieee80211_txq_schedule_end() at the end. The API then guarantees that the same TXQ is not returned twice in the same session (so a driver can loop on ieee80211_next_txq() without worrying about breaking the loop.
Usage of the new API is optional, so drivers can be ported one at a time. In this patch, the actual scheduling performed by mac80211 is simple round-robin, but a subsequent commit adds airtime fairness awareness to the scheduler.
--- include/net/mac80211.h | 62 +++++++++++++++++++++++++++++++++++++++++++--- net/mac80211/agg-tx.c | 2 +- net/mac80211/driver-ops.h | 9 +++++++ net/mac80211/ieee80211_i.h | 9 +++++++ net/mac80211/main.c | 5 ++++ net/mac80211/sta_info.c | 2 +- net/mac80211/tx.c | 58 ++++++++++++++++++++++++++++++++++++++++++- 7 files changed, 140 insertions(+), 7 deletions(-)
include/net/mac80211.h +58 -4
@@ -108,9 +108,15 @@* The driver is expected to initialize its private per-queue data for stations * and interfaces in the .add_interface and .sta_add ops. * -* The driver can't access the queue directly. To dequeue a frame, it calls -* ieee80211_tx_dequeue(). Whenever mac80211 adds a new frame to a queue, it -* calls the .wake_tx_queue driver op. +* The driver can't access the queue directly. To dequeue a frame from a +* txq, it calls ieee80211_tx_dequeue(). Whenever mac80211 adds a new frame to a +* queue, it calls the .wake_tx_queue driver op. +* +* Drivers can optionally delegate responsibility for scheduling queues to +* mac80211, to take advantage of airtime fairness accounting. In this case, to +* obtain the next queue to pull frames from, the driver calls +* ieee80211_next_txq(). The driver is then expected to return the txq using +* ieee80211_return_txq(). * * For AP powersave TIM handling, the driver only needs to indicate if it has * buffered packets in the driver specific data structures by calling
@@ -6088,7 +6094,8 @@ void ieee80211_tdls_oper_request(struct ieee80211_vif *vif, const u8 *peer,* ieee80211_tx_dequeue - dequeue a packet from a software tx queue * * @hw: pointer as obtained from ieee80211_alloc_hw() -* @txq: pointer obtained from station or virtual interface +* @txq: pointer obtained from station or virtual interface, or from +* ieee80211_next_txq() * * Returns the skb if successful, %NULL if no frame was available. */
@@ -6096,6 +6103,53 @@ struct sk_buff *ieee80211_tx_dequeue(struct ieee80211_hw *hw, struct ieee80211_txq *txq);/** +* ieee80211_next_txq - get next tx queue to pull packets from +* +* @hw: pointer as obtained from ieee80211_alloc_hw() +* @ac: AC number to return packets from. +* +* Should only be called between calls to ieee80211_txq_schedule_start() +* and ieee80211_txq_schedule_end(). +* Returns the next txq if successful, %NULL if no queue is eligible. If a txq +* is returned, it should be returned with ieee80211_return_txq() after the +* driver has finished scheduling it. +*/ +struct ieee80211_txq *ieee80211_next_txq (struct ieee80211_hw *hw,u8 ac); + +/** +* ieee80211_return_txq - return a TXQ previously acquired by +* ieee80211_next_txq() +* +* @hw: pointer as obtained from ieee80211_alloc_hw() +* @txq: pointer obtained from station or virtual interface +* +* Should only be called between calls to ieee80211_txq_schedule_start() +* and ieee80211_txq_schedule_end(). +*/ +void ieee80211_return_txq (struct ieee80211_hw *hw,struct ieee80211_txq *txq); + +/** +* ieee80211_txq_schedule_start - acquire locks for safe scheduling of an AC +* +* @hw: pointer as obtained from ieee80211_alloc_hw() +* @ac: AC number to acquire locks for +* +* Acquire locks needed to schedule TXQs from the given AC. Should be called +* before ieee80211_next_txq() or ieee80211_return_txq(). +*/ +void ieee80211_txq_schedule_start (struct ieee80211_hw *hw,u8 ac); + +/** +* ieee80211_txq_schedule_end - release locks for safe scheduling of an AC +* +* @hw: pointer as obtained from ieee80211_alloc_hw() +* @ac: AC number to acquire locks for +* +* Release locks previously acquired by ieee80211_txq_schedule_end(). +*/ +void ieee80211_txq_schedule_end (struct ieee80211_hw *hw,u8 ac); + +/** * ieee80211_txq_get_depth - get pending frame/byte count of given txq * * The values are not guaranteed to be coherent with regard to each other, i.e.
net/mac80211/agg-tx.c +1 -1
@@ -229,7 +229,7 @@ static void __releases(agg_queue)clear_bit (IEEE80211_TXQ_STOP , &txqi->flags);local_bh_disable ();rcu_read_lock (); -drv_wake_tx_queue (sta->sdata->local, txqi); +schedule_and_wake_txq (sta->sdata->local, txqi);rcu_read_unlock ();local_bh_enable (); }
net/mac80211/driver-ops.h +9 -0
@@ -1173,6 +1173,15 @@ static inline void drv_wake_tx_queue(struct ieee80211_local *local, local->ops->wake_tx_queue (&local->hw, &txq->txq); } +static inline void schedule_and_wake_txq (struct ieee80211_local *local, +struct txq_info *txqi) +{ +spin_lock_bh (&local->active_txq_lock[txqi->txq.ac]); +ieee80211_return_txq (&local->hw, &txqi->txq); +spin_unlock_bh (&local->active_txq_lock[txqi->txq.ac]); +drv_wake_tx_queue (local, txqi); +} +static inline int drv_can_aggregate_in_amsdu (struct ieee80211_local *local,struct sk_buff *head,struct sk_buff *skb)
net/mac80211/ieee80211_i.h +9 -0
@@ -830,6 +830,8 @@ enum txq_info_flags {* a fq_flow which is already owned by a different tin * @def_cvars: codel vars for @def_flow * @frags: used to keep fragments created after dequeue +* @schedule_order: used with ieee80211_local->active_txqs +* @schedule_round: counter to prevent infinite loops on TXQ scheduling */ struct txq_info {struct fq_tin tin;
@@ -837,6 +839,8 @@ struct txq_info {struct codel_vars def_cvars;struct codel_stats cstats;struct sk_buff_head frags; +struct list_head schedule_order; +u16 schedule_round;unsigned long flags;/* keep last! */
@@ -1128,6 +1132,11 @@ struct ieee80211_local {struct codel_vars *cvars;struct codel_params cparams; +/* protects active_txqs and txqi->schedule_order */ +spinlock_t active_txq_lock[IEEE80211_NUM_ACS ]; +struct list_head active_txqs[IEEE80211_NUM_ACS ]; +u16 schedule_round[IEEE80211_NUM_ACS ]; +const struct ieee80211_ops *ops;/*
net/mac80211/main.c +5 -0
@@ -663,6 +663,11 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,spin_lock_init (&local->rx_path_lock);spin_lock_init (&local->queue_stop_reason_lock); +for (i =0 ; i <IEEE80211_NUM_ACS ; i++) { +INIT_LIST_HEAD (&local->active_txqs[i]); +spin_lock_init (&local->active_txq_lock[i]); + } +INIT_LIST_HEAD (&local->chanctx_list);mutex_init (&local->chanctx_mtx);
net/mac80211/sta_info.c +1 -1
@@ -1249,7 +1249,7 @@ void ieee80211_sta_ps_deliver_wakeup(struct sta_info *sta)if (!sta->sta.txq[i] || !txq_has_queue (sta->sta.txq[i]))continue ; -drv_wake_tx_queue (local,to_txq_info (sta->sta.txq[i])); +schedule_and_wake_txq (local,to_txq_info (sta->sta.txq[i])); }skb_queue_head_init (&pending);
net/mac80211/tx.c +57 -1
82 lines not on this page · raw message
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH v5 2/6 cfg80211: Add airtime statistics and settings
In reply to Rajkumar ManoharanFrom: Toke Høiland-Jørgensen <[email protected]>
This adds TX airtime statistics to the cfg80211 station dump (to go along with the RX info already present), and adds a new parameter to set the airtime weight of each station. The latter allows userspace to implement policies for different stations by varying their weights.
--- include/net/cfg80211.h | 10 +++++++++- include/uapi/linux/nl80211.h | 15 +++++++++++++++ net/wireless/nl80211.c | 30 ++++++++++++++++++++++++++++++ 3 files changed, 54 insertions(+), 1 deletion(-)
include/net/cfg80211.h +9 -1
@@ -1001,6 +1001,7 @@ enum station_parameters_apply_mask {* @support_p2p_ps: information if station supports P2P PS mechanism * @he_capa: HE capabilities of station * @he_capa_len: the length of the HE capabilities +* @airtime_weight: airtime scheduler weight for this station */ struct station_parameters {const u8 *supported_rates;
@@ -1030,6 +1031,7 @@ struct station_parameters {int support_p2p_ps;const struct ieee80211_he_cap_elem *he_capa;u8 he_capa_len; +u16 airtime_weight; };/**
@@ -1297,6 +1299,8 @@ struct cfg80211_tid_stats {* @rx_beacon_signal_avg: signal strength average (in dBm) for beacons received * from this peer * @rx_duration: aggregate PPDU duration(usecs) for all the frames from a peer +* @tx_duration: aggregate PPDU duration(usecs) for all the frames to a peer +* @airtime_weight: current airtime scheduling weight * @pertid: per-TID statistics, see &struct cfg80211_tid_stats, using the last * (IEEE80211_NUM_TIDS) index for MSDUs not encapsulated in QoS-MPDUs. * Note that this doesn't use the @filled bit, but is used if non-NULL.
@@ -1347,10 +1351,12 @@ struct station_info {u32 expected_throughput; -u64 rx_beacon; +u64 tx_duration;u64 rx_duration; +u64 rx_beacon;u8 rx_beacon_signal_avg;struct cfg80211_tid_stats *pertid; +u16 airtime_weight;s8 ack_signal;s8 avg_ack_signal;
@@ -2381,6 +2387,8 @@ enum wiphy_params_flags { WIPHY_PARAM_TXQ_QUANTUM = 1 << 8, }; +#define IEEE80211_DEFAULT_AIRTIME_WEIGHT 256 +/** * struct cfg80211_pmksa - PMK Security Association *
include/uapi/linux/nl80211.h +15 -0
@@ -2254,6 +2254,9 @@ enum nl80211_commands {* @NL80211_ATTR_FTM_RESPONDER_STATS: Nested attribute with FTM responder * statistics, see &enum nl80211_ftm_responder_stats. * +* @NL80211_ATTR_AIRTIME_WEIGHT: Station's weight when scheduled by the airtime +* scheduler. +* * @NUM_NL80211_ATTR: total number of nl80211_attrs available * @NL80211_ATTR_MAX: highest attribute number currently defined * @__NL80211_ATTR_AFTER_LAST: internal use
@@ -2699,6 +2702,8 @@ enum nl80211_attrs {NL80211_ATTR_FTM_RESPONDER_STATS , +NL80211_ATTR_AIRTIME_WEIGHT , +/* add attributes here, update the policy in nl80211.c */ __NL80211_ATTR_AFTER_LAST,
@@ -3074,6 +3079,9 @@ enum nl80211_sta_bss_param {* with an FCS error (u32, from this station). This count may not include * some packets with an FCS error due to TA corruption. Hence this counter * might not be fully accurate. +* @NL80211_STA_INFO_TX_DURATION: aggregate PPDU duration for all frames +* sent to the station (u64, usec) +* @NL80211_STA_INFO_AIRTIME_WEIGHT: current airtime weight for station (u16) * @__NL80211_STA_INFO_AFTER_LAST: internal * @NL80211_STA_INFO_MAX: highest possible station info attribute */
@@ -3116,6 +3124,8 @@ enum nl80211_sta_info {NL80211_STA_INFO_ACK_SIGNAL_AVG ,NL80211_STA_INFO_RX_MPDUS ,NL80211_STA_INFO_FCS_ERROR_COUNT , +NL80211_STA_INFO_TX_DURATION , +NL80211_STA_INFO_AIRTIME_WEIGHT ,/* keep last */ __NL80211_STA_INFO_AFTER_LAST,
@@ -5258,6 +5268,10 @@ enum nl80211_feature_flags {* if this flag is not set. Ignoring this can leak clear text packets and/or * freeze the connection. * +* @NL80211_EXT_FEATURE_AIRTIME_FAIRNESS: Driver supports getting airtime +* fairness for transmitted packets and has enabled airtime fairness +* scheduling. +* * @NUM_NL80211_EXT_FEATURES: number of extended features. * @MAX_NL80211_EXT_FEATURES: highest extended feature index. */
@@ -5297,6 +5311,7 @@ enum nl80211_ext_feature_index {NL80211_EXT_FEATURE_SCAN_MIN_PREQ_CONTENT ,NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 ,NL80211_EXT_FEATURE_ENABLE_FTM_RESPONDER , +NL80211_EXT_FEATURE_AIRTIME_FAIRNESS ,/* add new features before the definition below */ NUM_NL80211_EXT_FEATURES,
net/wireless/nl80211.c +30 -0
@@ -497,6 +497,7 @@ static int validate_ie_attr(const struct nlattr *attr, .type = NLA_NESTED, .validation_data = nl80211_ftm_responder_policy, }, + [NL80211_ATTR_AIRTIME_WEIGHT] = { .type = NLA_U16 }, };/* policy for the key attributes */
@@ -4690,6 +4691,11 @@ static int nl80211_send_station(struct sk_buff *msg, u32 cmd, u32 portid,PUT_SINFO (PLID , plid, u16);PUT_SINFO (PLINK_STATE , plink_state, u8);PUT_SINFO_U64 (RX_DURATION , rx_duration); +PUT_SINFO_U64 (TX_DURATION , tx_duration); + +if (wiphy_ext_feature_isset (&rdev->wiphy, +NL80211_EXT_FEATURE_AIRTIME_FAIRNESS )) +PUT_SINFO (AIRTIME_WEIGHT , airtime_weight, u16);switch (rdev->wiphy.signal_type) {case CFG80211_SIGNAL_TYPE_MBM :
@@ -5308,6 +5314,18 @@ static int nl80211_set_station(struct sk_buff *skb, struct genl_info *info)nla_get_u8 (info->attrs[NL80211_ATTR_OPMODE_NOTIF ]); } +if (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT ]) { + params.airtime_weight = +nla_get_u16 (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT ]); +if (!params.airtime_weight) +return -EINVAL ; + } + +if (params.airtime_weight && + !wiphy_ext_feature_isset (&rdev->wiphy, +NL80211_EXT_FEATURE_AIRTIME_FAIRNESS )) +return -EOPNOTSUPP ; +/* Include parameters for TDLS peer (will check later) */ err =nl80211_set_station_tdls (info, ¶ms);if (err)
@@ -5436,6 +5454,18 @@ static int nl80211_new_station(struct sk_buff *skb, struct genl_info *info) params.plink_action =nla_get_u8 (info->attrs[NL80211_ATTR_STA_PLINK_ACTION ]); +if (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT ]) { + params.airtime_weight = +nla_get_u16 (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT ]); +if (!params.airtime_weight) +return -EINVAL ; + } + +if (params.airtime_weight && + !wiphy_ext_feature_isset (&rdev->wiphy, +NL80211_EXT_FEATURE_AIRTIME_FAIRNESS )) +return -EOPNOTSUPP ; + err =nl80211_parse_sta_channel_info (info, ¶ms);if (err)return err;
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH v5 3/6 mac80211: Add airtime accounting and scheduling to TXQs
In reply to Rajkumar ManoharanFrom: Toke Høiland-Jørgensen <[email protected]>
This adds airtime accounting and scheduling to the mac80211 TXQ scheduler. A new callback, ieee80211_sta_register_airtime(), is added that drivers can call to report airtime usage for stations.
When airtime information is present, mac80211 will schedule TXQs (through ieee80211_next_txq()) in a way that enforces airtime fairness between active stations. This scheduling works the same way as the ath9k in-driver airtime fairness scheduling. If no airtime usage is reported by the driver, the scheduler will default to round-robin scheduling.
For drivers that don't control TXQ scheduling in software, a new API function, ieee80211_txq_may_transmit(), is added which the driver can use to check if the TXQ is eligible for transmission, or should be throttled to enforce fairness. Calls to this function must also be enclosed in ieee80211_txq_schedule_{start,end}() calls to ensure proper locking.
The API ieee80211_txq_may_transmit() also ensures that TXQ list will be aligned aginst driver's own round-robin scheduler list. i.e it rotates the TXQ list till it makes the requested node becomes the first entry in TXQ list. Thus both the TXQ list and driver's list are in sync.
--- include/net/mac80211.h | 59 ++++++++++++++++++++++++++++++ net/mac80211/cfg.c | 3 ++ net/mac80211/debugfs.c | 3 ++ net/mac80211/debugfs_sta.c | 68 +++++++++++++++++++++++++++++++++-- net/mac80211/ieee80211_i.h | 2 ++ net/mac80211/main.c | 4 +++ net/mac80211/sta_info.c | 44 +++++++++++++++++++++-- net/mac80211/sta_info.h | 13 +++++++ net/mac80211/status.c | 6 ++++ net/mac80211/tx.c | 90 +++++++++++++++++++++++++++++++++++++++++++--- 10 files changed, 282 insertions(+), 10 deletions(-)
include/net/mac80211.h +59 -0
@@ -2357,6 +2357,9 @@ enum ieee80211_hw_flags {* @tx_sk_pacing_shift: Pacing shift to set on TCP sockets when frames from * them are encountered. The default should typically not be changed, * unless the driver has good reasons for needing more buffers. +* +* @weight_multipler: Driver specific airtime weight multiplier used while +* refilling deficit of each TXQ. */ struct ieee80211_hw {struct ieee80211_conf conf;
@@ -2393,6 +2396,7 @@ struct ieee80211_hw {const struct ieee80211_cipher_scheme *cipher_schemes;u8 max_nan_de_entries;u8 tx_sk_pacing_shift; +u8 weight_multiplier; }; static inline bool _ieee80211_hw_check(struct ieee80211_hw *hw,
@@ -5393,6 +5397,34 @@ void ieee80211_sta_block_awake(struct ieee80211_hw *hw,void ieee80211_send_eosp_nullfunc (struct ieee80211_sta *pubsta,int tid);/** +* ieee80211_sta_register_airtime - register airtime usage for a sta/tid +* +* Register airtime usage for a given sta on a given tid. The driver can call +* this function to notify mac80211 that a station used a certain amount of +* airtime. This information will be used by the TXQ scheduler to schedule +* stations in a way that ensures airtime fairness. +* +* The reported airtime should as a minimum include all time that is spent +* transmitting to the remote station, including overhead and padding, but not +* including time spent waiting for a TXOP. If the time is not reported by the +* hardware it can in some cases be calculated from the rate and known frame +* composition. When possible, the time should include any failed transmission +* attempts. +* +* The driver can either call this function synchronously for every packet or +* aggregate, or asynchronously as airtime usage information becomes available. +* TX and RX airtime can be reported together, or separately by setting one of +* them to 0. +* +* @pubsta: the station +* @tid: the TID to register airtime for +* @tx_airtime: airtime used during TX (in usec) +* @rx_airtime: airtime used during RX (in usec) +*/ +void ieee80211_sta_register_airtime (struct ieee80211_sta *pubsta,u8 tid, +u32 tx_airtime,u32 rx_airtime); + +/** * ieee80211_iter_keys - iterate keys programmed into the device * @hw: pointer obtained from ieee80211_alloc_hw() * @vif: virtual interface to iterate, may be %NULL for all
@@ -6150,6 +6182,33 @@ struct sk_buff *ieee80211_tx_dequeue(struct ieee80211_hw *hw,void ieee80211_txq_schedule_end (struct ieee80211_hw *hw,u8 ac);/** +* ieee80211_txq_may_transmit - check whether TXQ is allowed to transmit +* +* This function is used to check whether given txq is allowed to transmit by +* the airtime scheduler, and can be used by drivers to access the airtime +* fairness accounting without going using the scheduling order enfored by +* next_txq(). +* +* Returns %true if the airtime scheduler thinks the TXQ should be allowed to +* transmit, and %false if it should be throttled. This function can also have +* the side effect of rotating the TXQ in the scheduler rotation, which will +* eventually bring the deficit to positive and allow the station to transmit +* again. +* +* The API ieee80211_txq_may_transmit() also ensures that TXQ list will be +* aligned aginst driver's own round-robin scheduler list. i.e it rotates +* the TXQ list till it makes the requested node becomes the first entry +* in TXQ list. Thus both the TXQ list and driver's list are in sync. If this +* function returns %true, the driver is expected to schedule packets +* for transmission, and then return the TXQ through ieee80211_return_txq(). +* +* @hw: pointer as obtained from ieee80211_alloc_hw() +* @txq: pointer obtained from station or virtual interface +*/ +bool ieee80211_txq_may_transmit (struct ieee80211_hw *hw, +struct ieee80211_txq *txq); + +/** * ieee80211_txq_get_depth - get pending frame/byte count of given txq * * The values are not guaranteed to be coherent with regard to each other, i.e.
net/mac80211/cfg.c +3 -0
@@ -1447,6 +1447,9 @@ static int sta_apply_parameters(struct ieee80211_local *local,if (ieee80211_vif_is_mesh (&sdata->vif))sta_apply_mesh_params (local, sta, params); +if (params->airtime_weight) + sta->airtime_weight = params->airtime_weight; +/* set the STA state after all sta info from usermode has been set */ if (test_sta_flag (sta,WLAN_STA_TDLS_PEER ) || set &BIT (NL80211_STA_FLAG_ASSOCIATED )) {
net/mac80211/debugfs.c +3 -0
@@ -383,6 +383,9 @@ void debugfs_hw_add(struct ieee80211_local *local)if (local->ops->wake_tx_queue)DEBUGFS_ADD_MODE (aqm,0600 ); +debugfs_create_u16 ("airtime_flags" ,0600 , + phyd, &local->airtime_flags); + statsd =debugfs_create_dir ("statistics" , phyd);/* if the dir failed, don't put all the other things into the root! */
net/mac80211/debugfs_sta.c +65 -3
86 lines not on this page · raw message
net/mac80211/ieee80211_i.h +2 -0
@@ -1137,6 +1137,8 @@ struct ieee80211_local {struct list_head active_txqs[IEEE80211_NUM_ACS ];u16 schedule_round[IEEE80211_NUM_ACS ]; +u16 airtime_flags; +const struct ieee80211_ops *ops;/*
net/mac80211/main.c +4 -0
@@ -667,6 +667,7 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,INIT_LIST_HEAD (&local->active_txqs[i]);spin_lock_init (&local->active_txq_lock[i]); } + local->airtime_flags =AIRTIME_USE_TX |AIRTIME_USE_RX ;INIT_LIST_HEAD (&local->chanctx_list);mutex_init (&local->chanctx_mtx);
@@ -1153,6 +1154,9 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)if (!local->hw.max_nan_de_entries) local->hw.max_nan_de_entries =IEEE80211_MAX_NAN_INSTANCE_ID ; +if (!local->hw.weight_multiplier) + local->hw.weight_multiplier =1 ; + result =ieee80211_wep_init (local);if (result <0 ) wiphy_debug(local->hw.wiphy, "Failed to initialize wep: %d\n",
net/mac80211/sta_info.c +41 -3
78 lines not on this page · raw message
net/mac80211/sta_info.h +13 -0
@@ -127,6 +127,16 @@ enum ieee80211_agg_stop_reason { AGG_STOP_DESTROY_STA, }; +/* Debugfs flags to enable/disable use of RX/TX airtime in scheduler */ +#define AIRTIME_USE_TX BIT(0) +#define AIRTIME_USE_RX BIT(1) + +struct airtime_info { +u64 rx_airtime; +u64 tx_airtime; +s64 deficit; +}; +struct sta_info ;/**
@@ -563,6 +573,9 @@ struct sta_info { } tx_stats;u16 tid_seq[IEEE80211_QOS_CTL_TID_MASK +1 ]; +struct airtime_info airtime[IEEE80211_NUM_ACS ]; +u16 airtime_weight; +/* * Aggregation information, locked with lock. */
net/mac80211/status.c +6 -0
@@ -823,6 +823,12 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,ieee80211_sta_tx_notify (sta->sdata, (void *) skb->data, acked, info->status.tx_time); +if (info->status.tx_time && +wiphy_ext_feature_isset (local->hw.wiphy, +NL80211_EXT_FEATURE_AIRTIME_FAIRNESS )) +ieee80211_sta_register_airtime (&sta->sta, tid, + info->status.tx_time,0 ); +if (ieee80211_hw_check (&local->hw,REPORTS_TX_ACK_STATUS )) {if (info->flags &IEEE80211_TX_STAT_ACK ) {if (sta->status_stats.lost_packets)
net/mac80211/tx.c +86 -4
117 lines not on this page · raw message
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
kbuild test robot
build botRe: [PATCH v5 3/6] mac80211: Add airtime accounting and scheduling to TXQs
I love your patch! Perhaps something to improve:
Hi Toke,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mac80211/master]
[also build test WARNING on v4.20-rc7]
[cannot apply to next-20181219]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Rajkumar-Manoharan/Move-TXQ-scheduling-and-airtime-fairness-into-mac80211/20181219-132034 base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master reproduce: make htmldocs
All warnings (new ones prefixed by >>):
include/net/cfg80211.h:4447: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/cfg80211.h:2846: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:2400: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2400: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw'
>> include/net/mac80211.h:2400: warning: Function parameter or member 'weight_multiplier' not described in 'ieee80211_hw' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:1007: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:1007: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:483: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' net/mac80211/sta_info.h:601: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:601: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' >> net/mac80211/sta_info.h:601: warning: Function parameter or member 'airtime' not described in 'sta_info' >> net/mac80211/sta_info.h:601: warning: Function parameter or member 'airtime_weight' not described in 'sta_info'
kernel/rcu/tree.c:685: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array' include/linux/gpio/driver.h:375: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/iio/hw-consumer.h:1: warning: no structured comments found
include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/regulator/driver.h:227: warning: Function parameter or member 'resume' not described in 'regulator_ops' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb' drivers/slimbus/stream.c:1: warning: no structured comments found
include/linux/spi/spi.h:177: warning: Function parameter or member 'driver_override' not described in 'spi_device' drivers/target/target_core_device.c:1: warning: no structured comments found
drivers/usb/typec/bus.c:1: warning: no structured comments found
drivers/usb/typec/class.c:1: warning: no structured comments found
include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family' fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete'
fs/file_table.c:1: warning: no structured comments found
fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end'
fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode' fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode' fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:254: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_invalidate_range_start_gfx' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:302: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:382: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:383: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:555: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:555: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:555: warning: Function parameter or member 'start' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:555: warning: Function parameter or member 'end' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:555: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:603: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:603: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:603: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:603: warning: Function parameter or member 'entry' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:848: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1356: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'level' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1523: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_huge' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3100: warning: Function parameter or member 'pasid' not described in 'amdgpu_vm_make_compute' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_unpin' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_res_obj' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_get_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_import_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_vmap' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_vunmap' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_mmap' not described in 'drm_driver' include/drm/drm_mode_config.h:869: warning: Function parameter or member 'quirk_addfb_prefer_xbgr_30bpp' not described in 'drm_mode_config' drivers/gpu/drm/i915/i915_vma.h:49: warning: cannot understand function prototype: 'struct i915_vma ' drivers/gpu/drm/i915/i915_vma.h:1: warning: no structured comments found
drivers/gpu/drm/i915/intel_guc_fwif.h:554: warning: cannot understand function prototype: 'struct guc_log_buffer_state ' drivers/gpu/drm/i915/i915_trace.h:1: warning: no structured comments found
include/linux/skbuff.h:862: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'list' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'head_frag' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'csum_valid' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'csum_level' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'offload_fwd_mark' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'offload_mr_fwd_mark' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff' include/linux/skbuff.h:862: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff' include/net/sock.h:238: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_portpair' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_cookie' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
vim +2400 include/net/mac80211.h
1bc0826c8f Johannes Berg 2007-09-18 2242
7ac1bd6aec Johannes Berg 2007-09-14 2243 /**
7ac1bd6aec Johannes Berg 2007-09-14 2244 * struct ieee80211_hw - hardware information and state
75a5f0ccfd Johannes Berg 2007-09-18 2245 *
75a5f0ccfd Johannes Berg 2007-09-18 2246 * This structure contains the configuration and hardware
75a5f0ccfd Johannes Berg 2007-09-18 2247 * information for an 802.11 PHY.
75a5f0ccfd Johannes Berg 2007-09-18 2248 *
75a5f0ccfd Johannes Berg 2007-09-18 2249 * @wiphy: This points to the &struct wiphy allocated for this
75a5f0ccfd Johannes Berg 2007-09-18 2250 * 802.11 PHY. You must fill in the @perm_addr and @dev
75a5f0ccfd Johannes Berg 2007-09-18 2251 * members of this structure using SET_IEEE80211_DEV()
8318d78a44 Johannes Berg 2008-01-24 2252 * and SET_IEEE80211_PERM_ADDR(). Additionally, all supported
8318d78a44 Johannes Berg 2008-01-24 2253 * bands (with channels, bitrates) are registered here.
75a5f0ccfd Johannes Berg 2007-09-18 2254 *
75a5f0ccfd Johannes Berg 2007-09-18 2255 * @conf: &struct ieee80211_conf, device configuration, don't use.
75a5f0ccfd Johannes Berg 2007-09-18 2256 *
75a5f0ccfd Johannes Berg 2007-09-18 2257 * @priv: pointer to private area that was allocated for driver use
75a5f0ccfd Johannes Berg 2007-09-18 2258 * along with this structure.
75a5f0ccfd Johannes Berg 2007-09-18 2259 *
75a5f0ccfd Johannes Berg 2007-09-18 2260 * @flags: hardware flags, see &enum ieee80211_hw_flags.
75a5f0ccfd Johannes Berg 2007-09-18 2261 *
75a5f0ccfd Johannes Berg 2007-09-18 2262 * @extra_tx_headroom: headroom to reserve in each transmit skb
75a5f0ccfd Johannes Berg 2007-09-18 2263 * for use by the driver (e.g. for transmit headers.)
75a5f0ccfd Johannes Berg 2007-09-18 2264 *
70dabeb74e Felix Fietkau 2013-12-14 2265 * @extra_beacon_tailroom: tailroom to reserve in each beacon tx skb.
70dabeb74e Felix Fietkau 2013-12-14 2266 * Can be used by drivers to add extra IEs.
75a5f0ccfd Johannes Berg 2007-09-18 2267 *
566bfe5a8b Bruno Randolf 2008-05-08 2268 * @max_signal: Maximum value for signal (rssi) in RX information, used
566bfe5a8b Bruno Randolf 2008-05-08 2269 * only when @IEEE80211_HW_SIGNAL_UNSPEC or @IEEE80211_HW_SIGNAL_DB
75a5f0ccfd Johannes Berg 2007-09-18 2270 *
ea95bba41e Tomas Winkler 2008-07-18 2271 * @max_listen_interval: max listen interval in units of beacon interval
ea95bba41e Tomas Winkler 2008-07-18 2272 * that HW supports
ea95bba41e Tomas Winkler 2008-07-18 2273 *
75a5f0ccfd Johannes Berg 2007-09-18 2274 * @queues: number of available hardware transmit queues for
e100bb64bf Johannes Berg 2008-04-30 2275 * data packets. WMM/QoS requires at least four, these
e100bb64bf Johannes Berg 2008-04-30 2276 * queues need to have configurable access parameters.
e100bb64bf Johannes Berg 2008-04-30 2277 *
830f903866 Johannes Berg 2007-10-28 2278 * @rate_control_algorithm: rate control algorithm for this hardware.
830f903866 Johannes Berg 2007-10-28 2279 * If unset (NULL), the default algorithm will be used. Must be
830f903866 Johannes Berg 2007-10-28 2280 * set before calling ieee80211_register_hw().
32bfd35d4b Johannes Berg 2007-12-19 2281 *
32bfd35d4b Johannes Berg 2007-12-19 2282 * @vif_data_size: size (in bytes) of the drv_priv data area
32bfd35d4b Johannes Berg 2007-12-19 2283 * within &struct ieee80211_vif.
17741cdc26 Johannes Berg 2008-09-11 2284 * @sta_data_size: size (in bytes) of the drv_priv data area
17741cdc26 Johannes Berg 2008-09-11 2285 * within &struct ieee80211_sta.
d01a1e6586 Michal Kazior 2012-06-26 2286 * @chanctx_data_size: size (in bytes) of the drv_priv data area
d01a1e6586 Michal Kazior 2012-06-26 2287 * within &struct ieee80211_chanctx_conf.
ba8c3d6f16 Felix Fietkau 2015-03-27 2288 * @txq_data_size: size (in bytes) of the drv_priv data area
ba8c3d6f16 Felix Fietkau 2015-03-27 2289 * within @struct ieee80211_txq.
870abdf671 Felix Fietkau 2008-10-05 2290 *
78be49ec2a Helmut Schaa 2010-10-02 2291 * @max_rates: maximum number of alternate rate retry stages the hw
78be49ec2a Helmut Schaa 2010-10-02 2292 * can handle.
78be49ec2a Helmut Schaa 2010-10-02 2293 * @max_report_rates: maximum number of alternate rate retry stages
78be49ec2a Helmut Schaa 2010-10-02 2294 * the hw can report back.
e6a9854b05 Johannes Berg 2008-10-21 2295 * @max_rate_tries: maximum number of tries for each stage
4e6cbfd09c John W. Linville 2010-07-29 2296 *
df6ba5d80d Luciano Coelho 2011-01-12 2297 * @max_rx_aggregation_subframes: maximum buffer size (number of
df6ba5d80d Luciano Coelho 2011-01-12 2298 * sub-frames) to be used for A-MPDU block ack receiver
df6ba5d80d Luciano Coelho 2011-01-12 2299 * aggregation.
df6ba5d80d Luciano Coelho 2011-01-12 2300 * This is only relevant if the device has restrictions on the
df6ba5d80d Luciano Coelho 2011-01-12 2301 * number of subframes, if it relies on mac80211 to do reordering
df6ba5d80d Luciano Coelho 2011-01-12 2302 * it shouldn't be set.
5dd36bc933 Johannes Berg 2011-01-18 2303 *
5dd36bc933 Johannes Berg 2011-01-18 2304 * @max_tx_aggregation_subframes: maximum number of subframes in an
41cbb0f5a2 Luca Coelho 2018-06-09 2305 * aggregate an HT/HE device will transmit. In HT AddBA we'll
41cbb0f5a2 Luca Coelho 2018-06-09 2306 * advertise a constant value of 64 as some older APs crash if
41cbb0f5a2 Luca Coelho 2018-06-09 2307 * the window size is smaller (an example is LinkSys WRT120N
41cbb0f5a2 Luca Coelho 2018-06-09 2308 * with FW v1.0.07 build 002 Jun 18 2012).
41cbb0f5a2 Luca Coelho 2018-06-09 2309 * For AddBA to HE capable peers this value will be used.
3a25a8c8b7 Johannes Berg 2012-04-03 2310 *
6e0456b545 Felix Fietkau 2016-03-03 2311 * @max_tx_fragments: maximum number of tx buffers per (A)-MSDU, sum
6e0456b545 Felix Fietkau 2016-03-03 2312 * of 1 + skb_shinfo(skb)->nr_frags for each skb in the frag_list.
6e0456b545 Felix Fietkau 2016-03-03 2313 *
3a25a8c8b7 Johannes Berg 2012-04-03 2314 * @offchannel_tx_hw_queue: HW queue ID to use for offchannel TX
3a25a8c8b7 Johannes Berg 2012-04-03 2315 * (if %IEEE80211_HW_QUEUE_CONTROL is set)
ac55d2fe05 Johannes Berg 2012-05-10 2316 *
ac55d2fe05 Johannes Berg 2012-05-10 2317 * @radiotap_mcs_details: lists which MCS information can the HW
ac55d2fe05 Johannes Berg 2012-05-10 2318 * reports, by default it is set to _MCS, _GI and _BW but doesn't
b4f7f4ad42 Jani Nikula 2016-10-21 2319 * include _FMT. Use %IEEE80211_RADIOTAP_MCS_HAVE_\* values, only
ac55d2fe05 Johannes Berg 2012-05-10 2320 * adding _BW is supported today.
72d7872852 Arik Nemtsov 2012-05-10 2321 *
5164892184 Johannes Berg 2012-11-22 2322 * @radiotap_vht_details: lists which VHT MCS information the HW reports,
5164892184 Johannes Berg 2012-11-22 2323 * the default is _GI | _BANDWIDTH.
b4f7f4ad42 Jani Nikula 2016-10-21 2324 * Use the %IEEE80211_RADIOTAP_VHT_KNOWN_\* values.
5164892184 Johannes Berg 2012-11-22 2325 *
41cbb0f5a2 Luca Coelho 2018-06-09 2326 * @radiotap_he: HE radiotap validity flags
41cbb0f5a2 Luca Coelho 2018-06-09 2327 *
99ee7cae3b Johannes Berg 2016-08-29 2328 * @radiotap_timestamp: Information for the radiotap timestamp field; if the
99ee7cae3b Johannes Berg 2016-08-29 2329 * 'units_pos' member is set to a non-negative value it must be set to
99ee7cae3b Johannes Berg 2016-08-29 2330 * a combination of a IEEE80211_RADIOTAP_TIMESTAMP_UNIT_* and a
99ee7cae3b Johannes Berg 2016-08-29 2331 * IEEE80211_RADIOTAP_TIMESTAMP_SPOS_* value, and then the timestamp
99ee7cae3b Johannes Berg 2016-08-29 2332 * field will be added and populated from the &struct ieee80211_rx_status
99ee7cae3b Johannes Berg 2016-08-29 2333 * device_timestamp. If the 'accuracy' member is non-negative, it's put
99ee7cae3b Johannes Berg 2016-08-29 2334 * into the accuracy radiotap field and the accuracy known flag is set.
99ee7cae3b Johannes Berg 2016-08-29 2335 *
72d7872852 Arik Nemtsov 2012-05-10 2336 * @netdev_features: netdev features to be set in each netdev created
680a0daba7 Johannes Berg 2015-04-13 2337 * from this HW. Note that not all features are usable with mac80211,
680a0daba7 Johannes Berg 2015-04-13 2338 * other features will be rejected during HW registration.
219c38674c Alexander Bondar 2013-01-22 2339 *
219c38674c Alexander Bondar 2013-01-22 2340 * @uapsd_queues: This bitmap is included in (re)association frame to indicate
219c38674c Alexander Bondar 2013-01-22 2341 * for each access category if it is uAPSD trigger-enabled and delivery-
219c38674c Alexander Bondar 2013-01-22 2342 * enabled. Use IEEE80211_WMM_IE_STA_QOSINFO_AC_* to set this bitmap.
219c38674c Alexander Bondar 2013-01-22 2343 * Each bit corresponds to different AC. Value '1' in specific bit means
219c38674c Alexander Bondar 2013-01-22 2344 * that corresponding AC is both trigger- and delivery-enabled. '0' means
219c38674c Alexander Bondar 2013-01-22 2345 * neither enabled.
219c38674c Alexander Bondar 2013-01-22 2346 *
219c38674c Alexander Bondar 2013-01-22 2347 * @uapsd_max_sp_len: maximum number of total buffered frames the WMM AP may
219c38674c Alexander Bondar 2013-01-22 2348 * deliver to a WMM STA during any Service Period triggered by the WMM STA.
219c38674c Alexander Bondar 2013-01-22 2349 * Use IEEE80211_WMM_IE_STA_QOSINFO_SP_* for correct values.
2475b1cc0d Max Stepanov 2013-03-24 2350 *
2475b1cc0d Max Stepanov 2013-03-24 2351 * @n_cipher_schemes: a size of an array of cipher schemes definitions.
2475b1cc0d Max Stepanov 2013-03-24 2352 * @cipher_schemes: a pointer to an array of cipher scheme definitions
2475b1cc0d Max Stepanov 2013-03-24 2353 * supported by HW.
167e33f4f6 Ayala Beker 2016-09-20 2354 * @max_nan_de_entries: maximum number of NAN DE functions supported by the
167e33f4f6 Ayala Beker 2016-09-20 2355 * device.
70e53669c4 Wen Gong 2018-08-08 2356 *
70e53669c4 Wen Gong 2018-08-08 2357 * @tx_sk_pacing_shift: Pacing shift to set on TCP sockets when frames from
70e53669c4 Wen Gong 2018-08-08 2358 * them are encountered. The default should typically not be changed,
70e53669c4 Wen Gong 2018-08-08 2359 * unless the driver has good reasons for needing more buffers.
1053390d02 Toke Høiland-Jørgensen 2018-12-18 2360 *
1053390d02 Toke Høiland-Jørgensen 2018-12-18 2361 * @weight_multipler: Driver specific airtime weight multiplier used while
1053390d02 Toke Høiland-Jørgensen 2018-12-18 2362 * refilling deficit of each TXQ.
7ac1bd6aec Johannes Berg 2007-09-14 2363 */
f0706e828e Jiri Benc 2007-05-05 2364 struct ieee80211_hw {
f0706e828e Jiri Benc 2007-05-05 2365 struct ieee80211_conf conf;
75a5f0ccfd Johannes Berg 2007-09-18 2366 struct wiphy *wiphy;
830f903866 Johannes Berg 2007-10-28 2367 const char *rate_control_algorithm;
f0706e828e Jiri Benc 2007-05-05 2368 void *priv;
30686bf7f5 Johannes Berg 2015-06-02 2369 unsigned long flags[BITS_TO_LONGS(NUM_IEEE80211_HW_FLAGS)];
f0706e828e Jiri Benc 2007-05-05 2370 unsigned int extra_tx_headroom;
70dabeb74e Felix Fietkau 2013-12-14 2371 unsigned int extra_beacon_tailroom;
32bfd35d4b Johannes Berg 2007-12-19 2372 int vif_data_size;
17741cdc26 Johannes Berg 2008-09-11 2373 int sta_data_size;
d01a1e6586 Michal Kazior 2012-06-26 2374 int chanctx_data_size;
ba8c3d6f16 Felix Fietkau 2015-03-27 2375 int txq_data_size;
ea95bba41e Tomas Winkler 2008-07-18 2376 u16 queues;
ea95bba41e Tomas Winkler 2008-07-18 2377 u16 max_listen_interval;
f0706e828e Jiri Benc 2007-05-05 2378 s8 max_signal;
e6a9854b05 Johannes Berg 2008-10-21 2379 u8 max_rates;
78be49ec2a Helmut Schaa 2010-10-02 2380 u8 max_report_rates;
e6a9854b05 Johannes Berg 2008-10-21 2381 u8 max_rate_tries;
41cbb0f5a2 Luca Coelho 2018-06-09 2382 u16 max_rx_aggregation_subframes;
41cbb0f5a2 Luca Coelho 2018-06-09 2383 u16 max_tx_aggregation_subframes;
6e0456b545 Felix Fietkau 2016-03-03 2384 u8 max_tx_fragments;
3a25a8c8b7 Johannes Berg 2012-04-03 2385 u8 offchannel_tx_hw_queue;
ac55d2fe05 Johannes Berg 2012-05-10 2386 u8 radiotap_mcs_details;
5164892184 Johannes Berg 2012-11-22 2387 u16 radiotap_vht_details;
99ee7cae3b Johannes Berg 2016-08-29 2388 struct {
99ee7cae3b Johannes Berg 2016-08-29 2389 int units_pos;
99ee7cae3b Johannes Berg 2016-08-29 2390 s16 accuracy;
99ee7cae3b Johannes Berg 2016-08-29 2391 } radiotap_timestamp;
72d7872852 Arik Nemtsov 2012-05-10 2392 netdev_features_t netdev_features;
219c38674c Alexander Bondar 2013-01-22 2393 u8 uapsd_queues;
219c38674c Alexander Bondar 2013-01-22 2394 u8 uapsd_max_sp_len;
2475b1cc0d Max Stepanov 2013-03-24 2395 u8 n_cipher_schemes;
2475b1cc0d Max Stepanov 2013-03-24 2396 const struct ieee80211_cipher_scheme *cipher_schemes;
167e33f4f6 Ayala Beker 2016-09-20 2397 u8 max_nan_de_entries;
70e53669c4 Wen Gong 2018-08-08 2398 u8 tx_sk_pacing_shift;1053390d02 Toke Høiland-Jørgensen 2018-12-18 2399 u8 weight_multiplier;f0706e828e Jiri Benc 2007-05-05 @2400 };f0706e828e Jiri Benc 2007-05-05 2401
:::::: The code at line 2400 was first introduced by commit
:::::: f0706e828e96d0fa4e80c0d25aa98523f6d589a0 [MAC80211]: Add mac80211 wireless stack.
:::::: TO: Jiri Benc <[email protected]> :::::: CC: David S. Miller <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
PATCH v5 4/6 ath9k: Switch to mac80211 TXQ scheduling and airtime APIs
In reply to Rajkumar ManoharanFrom: Toke Høiland-Jørgensen <[email protected]>
This moves the ath9k driver to use the mac80211 TXQ scheduling and airtime accounting APIs, removing the corresponding state tracking inside the driver.
--- drivers/net/wireless/ath/ath9k/ath9k.h | 14 -- drivers/net/wireless/ath/ath9k/debug.c | 3 - drivers/net/wireless/ath/ath9k/debug.h | 8 - drivers/net/wireless/ath/ath9k/debug_sta.c | 70 --------- drivers/net/wireless/ath/ath9k/init.c | 3 +- drivers/net/wireless/ath/ath9k/recv.c | 9 +- drivers/net/wireless/ath/ath9k/xmit.c | 244 +++++++++-------------------- 7 files changed, 75 insertions(+), 276 deletions(-)
drivers/net/wireless/ath/ath9k/ath9k.h +0 -14
@@ -112,8 +112,6 @@ int ath_descdma_setup(struct ath_softc *sc, struct ath_descdma *dd,#define ATH_TXFIFO_DEPTH 8#define ATH_TX_ERROR 0x01 -#define ATH_AIRTIME_QUANTUM 300/* usec */ -/* Stop tx traffic 1ms before the GO goes away */ #define ATH_P2P_PS_STOP_TIME 1000
@@ -246,10 +244,8 @@ struct ath_atx_tid {s8 bar_index;bool active;bool clear_ps_filter; -bool has_queued; }; -void __ath_tx_queue_tid (struct ath_softc *sc,struct ath_atx_tid *tid);void ath_tx_queue_tid (struct ath_softc *sc,struct ath_atx_tid *tid);struct ath_node {
@@ -263,12 +259,9 @@ struct ath_node {bool sleeping;bool no_ps_filter; -s64 airtime_deficit[IEEE80211_NUM_ACS ]; -u32 airtime_rx_start;#ifdef CONFIG_ATH9K_STATION_STATISTICS struct ath_rx_rate_stats rx_rate_stats; -struct ath_airtime_stats airtime_stats;#endif u8 key_idx[4 ];
@@ -986,11 +979,6 @@ struct ath_ant_comb {#define ATH9K_NUM_CHANCTX 2/* supports 2 operating channels */ -#define AIRTIME_USE_TX BIT(0) -#define AIRTIME_USE_RX BIT(1) -#define AIRTIME_USE_NEW_QUEUES BIT(2) -#define AIRTIME_ACTIVE (flags) (!!(flags & (AIRTIME_USE_TX|AIRTIME_USE_RX))) -struct ath_softc {struct ieee80211_hw *hw;struct device *dev;
@@ -1034,8 +1022,6 @@ struct ath_softc {short nbcnvifs;unsigned long ps_usecount; -u16 airtime_flags;/* AIRTIME_* */ -struct ath_rx rx;struct ath_tx tx;struct ath_beacon beacon;
drivers/net/wireless/ath/ath9k/debug.c +0 -3
@@ -1443,9 +1443,6 @@ int ath9k_init_debug(struct ath_hw *ah)#endif debugfs_create_file ("tpc" ,0600 , sc->debug.debugfs_phy, sc, &fops_tpc); -debugfs_create_u16 ("airtime_flags" ,0600 , - sc->debug.debugfs_phy, &sc->airtime_flags); -debugfs_create_file ("nf_override" ,0600 , sc->debug.debugfs_phy, sc, &fops_nf_override);
drivers/net/wireless/ath/ath9k/debug.h +0 -8
@@ -319,20 +319,12 @@ static inline void ath9k_debug_stat_ant(struct ath_softc *sc,void ath_debug_rate_stats (struct ath_softc *sc,struct ath_rx_status *rs,struct sk_buff *skb); -void ath_debug_airtime (struct ath_softc *sc, -struct ath_node *an, -u32 rx,u32 tx);#else static inline void ath_debug_rate_stats (struct ath_softc *sc,struct ath_rx_status *rs,struct sk_buff *skb) { } -static inline void ath_debug_airtime (struct ath_softc *sc, -struct ath_node *an, -u32 rx,u32 tx) -{ -}#endif /* CONFIG_ATH9K_STATION_STATISTICS */ #endif /* DEBUG_H */
drivers/net/wireless/ath/ath9k/debug_sta.c +0 -70
80 lines not on this page · raw message
drivers/net/wireless/ath/ath9k/init.c +1 -2
@@ -676,8 +676,6 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc,/* Will be cleared in ath9k_start() */ set_bit (ATH_OP_INVALID , &common->op_flags); - sc->airtime_flags = (AIRTIME_USE_TX |AIRTIME_USE_RX | -AIRTIME_USE_NEW_QUEUES ); sc->sc_ah = ah; sc->dfs_detector =dfs_pattern_detector_init (common,NL80211_DFS_UNSET );
@@ -1013,6 +1011,7 @@ static void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)SET_IEEE80211_PERM_ADDR (hw, common->macaddr);wiphy_ext_feature_set (hw->wiphy,NL80211_EXT_FEATURE_CQM_RSSI_LIST ); +wiphy_ext_feature_set (hw->wiphy,NL80211_EXT_FEATURE_AIRTIME_FAIRNESS ); } int ath9k_init_device(u16 devid, struct ath_softc *sc,
drivers/net/wireless/ath/ath9k/recv.c +1 -8
@@ -1054,14 +1054,7 @@ static void ath_rx_count_airtime(struct ath_softc *sc, len, rxs->rate_idx, is_sp); } -if (!!(sc->airtime_flags &AIRTIME_USE_RX )) { -spin_lock_bh (&acq->lock); - an->airtime_deficit[acno] -= airtime; -if (an->airtime_deficit[acno] <=0 ) -__ath_tx_queue_tid (sc,ATH_AN_2_TID (an, tidno)); -spin_unlock_bh (&acq->lock); - } -ath_debug_airtime (sc, an, airtime,0 ); +ieee80211_sta_register_airtime (sta, tidno,0 , airtime); exit:rcu_read_unlock (); }
drivers/net/wireless/ath/ath9k/xmit.c +73 -171
491 lines not on this page · raw message
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Toke Høiland-Jørgensen
maintainerRe: [PATCH v5 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs
Just discovered this while working on my follow-up:
Quoted 7 lines
void
ath_tx_queue_tid(struct ath_softc *sc, struct ath_atx_tid *tid){drivers/net/wireless/ath/ath9k/xmit.c +2
-3-struct ath_vif *avp = (struct ath_vif *) tid->an->vif->drv_priv; -struct ath_chanctx *ctx = avp->chanctx; -struct ath_acq *acq; +struct ieee80211_txq *queue = + container_of((void *)tid, struct ieee80211_txq, drv_priv);
drivers/net/wireless/ath/ath9k/xmit.c void ath_txq_unlock_complete(struct ath_softc *sc, struct ath_txq *txq) · line 122
Quoted 10 lines
drivers/net/wireless/ath/ath9k/xmit.c +1
-7-if (!ctx || !list_empty (&tid->list)) -return ; - - acq = &ctx->acq[TID_TO_WME_AC (tid->tidno)]; -spin_lock_bh (&acq->lock); -__ath_tx_queue_tid (sc, tid); -spin_unlock_bh (&acq->lock); +ieee80211_return_txq (sc->hw, queue); }
After we evolved the API, this is now wrong, as ieee80211_return_txq() should only be called while holding the right lock. I'll post a fixed version tomorrow.
-Toke
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
PATCH v5 5/6 ath10k: migrate to mac80211 txq scheduling
In reply to Rajkumar ManoharanFrom: Toke Høiland-Jørgensen <[email protected]>
ath10k maintains common txqs list for all stations. This txq management can be removed by migrating to mac80211 txq APIs and let mac80211 handle txqs reordering based on reported airtime. By doing this, txq fairness maintained in ath10k i.e processing N frames per txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm.
--- drivers/net/wireless/ath/ath10k/core.c | 2 - drivers/net/wireless/ath/ath10k/core.h | 6 +- drivers/net/wireless/ath/ath10k/htc.h | 1 - drivers/net/wireless/ath/ath10k/htt_rx.c | 8 +++ drivers/net/wireless/ath/ath10k/mac.c | 98 ++++++++++++++------------------ 5 files changed, 54 insertions(+), 61 deletions(-)
drivers/net/wireless/ath/ath10k/core.c +0 -2
@@ -3065,9 +3065,7 @@ struct ath10k *ath10k_core_create(size_t priv_size, struct device *dev,mutex_init (&ar->conf_mutex);spin_lock_init (&ar->data_lock); -spin_lock_init (&ar->txqs_lock); -INIT_LIST_HEAD (&ar->txqs);INIT_LIST_HEAD (&ar->peers);init_waitqueue_head (&ar->peer_mapping_wq);init_waitqueue_head (&ar->htt.empty_tx_wq);
drivers/net/wireless/ath/ath10k/core.h +3 -3
@@ -90,6 +90,9 @@/* The magic used by QCA spec */ #define ATH10K_SMBIOS_BDF_EXT_MAGIC "BDF_" +/* Default Airtime weight multipler (Tuned for multiclient performance) */ +#define ATH10K_AIRTIME_WEIGHT_MULTIPLIER 4 +struct ath10k ;static inline const char *ath10k_bus_str (enum ath10k_bus bus)
@@ -1062,10 +1065,7 @@ struct ath10k {/* protects shared structure data */ spinlock_t data_lock; -/* protects: ar->txqs, artxq->list */ -spinlock_t txqs_lock; -struct list_head txqs;struct list_head arvifs;struct list_head peers;struct ath10k_peer *peer_map[ATH10K_MAX_NUM_PEER_IDS ];
drivers/net/wireless/ath/ath10k/htc.h +0 -1
@@ -51,7 +51,6 @@*/ #define HTC_HOST_MAX_MSG_PER_RX_BUNDLE 8 -#define HTC_HOST_MAX_MSG_PER_TX_BUNDLE 16enum ath10k_htc_tx_flags {ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE =0x01 ,
drivers/net/wireless/ath/ath10k/htt_rx.c +8 -0
@@ -2379,6 +2379,7 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10k *ar, struct sk_buff *skb)u8 tid;int ret;int i; +bool may_tx;ath10k_dbg (ar,ATH10K_DBG_HTT ,"htt rx tx fetch ind\n" );
@@ -2451,8 +2452,13 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10k *ar, struct sk_buff *skb) num_msdus =0 ; num_bytes =0 ; +ieee80211_txq_schedule_start (hw, txq->ac); + may_tx =ieee80211_txq_may_transmit (hw, txq);while (num_msdus < max_num_msdus && num_bytes < max_num_bytes) { +if (!may_tx) +break ; + ret =ath10k_mac_tx_push_txq (hw, txq);if (ret <0 )break ;
@@ -2460,6 +2466,8 @@ static void ath10k_htt_rx_tx_fetch_ind(struct ath10k *ar, struct sk_buff *skb) num_msdus++; num_bytes += ret; } +ieee80211_return_txq (hw, txq); +ieee80211_txq_schedule_end (hw, txq->ac); record->num_msdus =cpu_to_le16 (num_msdus); record->num_bytes =cpu_to_le32 (num_bytes);
drivers/net/wireless/ath/ath10k/mac.c +43 -55
154 lines not on this page · raw message
Signature · 1 line
1.9.1
Re: [PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling
Quoted 9 lines · Rajkumar Manoharan
From: Toke Høiland-Jørgensen <[email protected]>
ath10k maintains common txqs list for all stations. This txq management can be removed by migrating to mac80211 txq APIs and let mac80211 handle txqs reordering based on reported airtime. By doing this, txq fairness maintained in ath10k i.e processing N frames per txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm.
Quoted 4 lines
Co-developed-by Rajkumar Manoharan <[email protected]>Signed-off-by Toke Høiland-Jørgensen <[email protected]>Signed-off-by Rajkumar Manoharan <[email protected]>
Please always add hardware and firmware versions used for testing. But I can add that, so no need to resend because of this. Just let me know what to add.
Signature · 1 line
Kalle Valo
Re: [PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling
Quoted 11 lines · Kalle Valo
Quoted 9 lines · Rajkumar Manoharan
From: Toke Høiland-Jørgensen <[email protected]>
ath10k maintains common txqs list for all stations. This txq management can be removed by migrating to mac80211 txq APIs and let mac80211 handle txqs reordering based on reported airtime. By doing this, txq fairness maintained in ath10k i.e processing N frames per txq is removed. By adapting to mac80211 APIs, ath10k will support mac80211 based airtime fairness algorithm.
Quoted 9 lines
Quoted 4 lines
Co-developed-by Rajkumar Manoharan <[email protected]>Signed-off-by Toke Høiland-Jørgensen <[email protected]>Signed-off-by Rajkumar Manoharan <[email protected]>Please always add hardware and firmware versions used for testing. But I can add that, so no need to resend because of this. Just let me know what to add.
Thanks Kalle. Please amend the commit log with
Tested on QCA4019 with firmware version 10.4-3.2.1.1-00015 Tested on QCA9984 with firmware version 10.4-3.9.0.1-00005
-Rajkumar
PATCH v5 6/6 ath10k: reporting estimated tx airtime for fairness
In reply to Rajkumar ManoharanFrom: Kan Yan <[email protected]>
Transmit airtime will be estimated from last tx rate used. Firmware report tx rate by peer stats. Airtime is computed on tx path and the same will be reported to mac80211 upon tx completion.
This change is based on Kan's orginal commit in Chromium tree ("CHROMIUM: ath10k: Implementing airtime fairness based TX scheduler")
ref: https://chromium-review.googlesource.com/588190
--- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/htt_rx.c | 1 + drivers/net/wireless/ath/ath10k/mac.c | 57 ++++++++++++++++++++++++++++++-- drivers/net/wireless/ath/ath10k/txrx.c | 4 +++ 4 files changed, 61 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath10k/core.h +2 -0
@@ -126,6 +126,7 @@ struct ath10k_skb_cb {u8 flags;u8 eid;u16 msdu_id; +u16 airtime_est;struct ieee80211_vif *vif;struct ieee80211_txq *txq; } __packed;
@@ -496,6 +497,7 @@ struct ath10k_sta {u32 smps;u16 peer_id;struct rate_info txrate; +u32 last_tx_bitrate;struct work_struct update_wk;u64 rx_duration;
drivers/net/wireless/ath/ath10k/htt_rx.c +1 -0
@@ -2808,6 +2808,7 @@ static inline int ath10k_get_legacy_rate_idx(struct ath10k *ar, u8 rate) arsta->txrate.nss = txrate.nss; arsta->txrate.bw =ath10k_bw_to_mac80211_bw (txrate.bw); + arsta->last_tx_bitrate =cfg80211_calculate_bitrate (&arsta->txrate);if (ath10k_debug_is_extd_tx_stats_enabled (ar)) ath10k_accumulate_per_peer_tx_stats(ar, arsta, peer_stats,
drivers/net/wireless/ath/ath10k/mac.c +54 -3
100 lines not on this page · raw message
drivers/net/wireless/ath/ath10k/txrx.c +4 -0
@@ -95,6 +95,10 @@ int ath10k_txrx_tx_unref(struct ath10k_htt *htt,wake_up (&htt->empty_tx_wq);spin_unlock_bh (&htt->tx_lock); +if (txq && txq->sta) +ieee80211_sta_register_airtime (txq->sta, txq->tid, + skb_cb->airtime_est,0 ); +if (ar->dev_type !=ATH10K_DEV_TYPE_HL )dma_unmap_single (dev, skb_cb->paddr, msdu->len,DMA_TO_DEVICE );
Signature · 1 line
1.9.1
Re: [PATCH v5 6/6] ath10k: reporting estimated tx airtime for fairness
Quoted 7 lines · Rajkumar Manoharan
From: Kan Yan <[email protected]>
Transmit airtime will be estimated from last tx rate used. Firmware report tx rate by peer stats. Airtime is computed on tx path and the same will be reported to mac80211 upon tx completion.
Quoted 7 lines
This change is based on Kan's orginal commit in Chromium tree ("CHROMIUM: ath10k: Implementing airtime fairness based TX scheduler")
ref: https://chromium-review.googlesource.com/588190Signed-off-by Kan Yan <[email protected]>[[email protected]: ported only the airtime computation]Signed-off-by Rajkumar Manoharan <[email protected]>
Same as with patch 5, let me know the tested hardware and firmware so I can add it to the commit log.
Signature · 1 line
Kalle Valo
Toke Høiland-Jørgensen
maintainerQuoted 5 lines · Rajkumar Manoharan
All,
Sorry for the long delay. Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness.
Thanks for taking care of the respin!
Johannes, I think it's safe for you to review this version. I have started working on another approach for the scheduler algorithm itself, but it is fine to do as an incremental patch on top of this as it shouldn't impact the API. Having a separate patch also makes testing easier anyway. I'll see if I can't get it to a working state over the holidays...
-Toke
Dave Taht
Acked-byQuoted 8 lines · Toke Høiland-Jørgensen
Quoted 5 lines · Rajkumar Manoharan
All,
Sorry for the long delay. Here is the consolidated series of mac80211, ath9k and ath10k changes for moving TXQ scheduling and airtime fairness into mac80211 and support airtime fairness.
Quoted 8 lines
Thanks for taking care of the respin!
Johannes, I think it's safe for you to review this version. I have started working on another approach for the scheduler algorithm itself, but it is fine to do as an incremental patch on top of this as it shouldn't impact the API. Having a separate patch also makes testing easier anyway. I'll see if I can't get it to a working state over the holidays...
There comes a time in all patch series where the best thing to do is commit it, and inflict it on others. Now may be that time.
Quoted 6 lines
-Toke
_______________________________________________
Make-wifi-fast mailing list
[email protected]
https://lists.bufferbloat.net/listinfo/make-wifi-fast