Skip to contentSkip to conversation

Add support for initializing MMC

PATCH Superseded tien.fong.chee at intel.com 2 participants 2 messages Dec 29, 2018 – Dec 30, 2018 Char and misc drivers

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Add support for initializing MMC

From: Tien Fong Chee <[email protected]>

Firmware loader would encounter problem if the MMC is accessed before initializing it. This patch would adding the support of probing block device and initializing MMC before the MMC is accessed by firmware loader.

---
Changes in v2:
- Initializing MMC through probing the blk device

---
 drivers/misc/fs_loader.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/misc/fs_loader.c +32 -0
index 57a14a3..d981b5a 100644
@@ -12,6 +12,7 @@
 #include <linux/string.h>
 #include <mapmem.h>
 #include <malloc.h>
+#include <mmc.h>
 #include <spl.h>
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -252,6 +253,37 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)
 
 static int fs_loader_probe(struct udevice *dev)
 {
+#if defined(CONFIG_DM_MMC) && defined(CONFIG_BLK)
+	int ret;
+	struct device_platdata *plat = dev->platdata;
+
+	ret = mmc_initialize(NULL);
+	if (ret) {
+		debug("MMC: could not initialize mmc. error: %d\n", ret);
+
+		return ret;
+	}
+
+	if (plat->phandlepart.phandle) {
+		ofnode node = ofnode_get_by_phandle(plat->phandlepart.phandle);
+
+		struct udevice *mmc_dev = NULL;
+
+		ret = device_get_global_by_ofnode(node, &mmc_dev);
+		if (!ret) {
+			struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
+			struct udevice *dev;
+
+			if (blk_get_from_parent(mmc->dev, &dev))
+			{
+				debug("MMC: No block device: %d\n",
+					ret);
+
+				return ret;
+			}
+		}
+	}
+#endif
 	return 0;
 };
 
Signature · 1 line
2.2.0
#1 lore raw

PATCH v2 1/1 Add support for initializing MMC

Quoted 7 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

Firmware loader would encounter problem if the MMC is accessed before initializing it. This patch would adding the support of probing block device and initializing MMC before the MMC is accessed by firmware loader.

Quoted 5 lines

---
Changes in v2:
- Initializing MMC through probing the blk device

Please ignore this patch, just realized missing a line status checking code. I would resend another patch.

Quoted 57 lines

---
 drivers/misc/fs_loader.c | 32 ++++++++++++++++++++++++++++++++

 1 file changed, 32 insertions(+)
drivers/misc/fs_loader.c +1 -0
index 57a14a3..d981b5a 100644
@@ -12,6 +12,7 @@
  #include <linux/string.h>
  #include <mapmem.h>
  #include <malloc.h>
+#include <mmc.h>
  #include <spl.h>


 DECLARE_GLOBAL_DATA_PTR;

drivers/misc/fs_loader.c +0 -0
@@ -252,6 +253,37 @@ static int fs_loader_ofdata_to_platdata(struct
 udevice *dev)


 static int fs_loader_probe(struct udevice *dev)
 {

drivers/misc/fs_loader.c +7 -0
+#if defined(CONFIG_DM_MMC) && defined(CONFIG_BLK)
+	int ret;
+	struct device_platdata *plat = dev->platdata;
+
+	ret = mmc_initialize(NULL);
+	if (ret) {
+		debug("MMC: could not initialize mmc. error: %d\n",

ret);

drivers/misc/fs_loader.c +6 -0
+
+		return ret;
+	}
+
+	if (plat->phandlepart.phandle) {
+		ofnode node = ofnode_get_by_phandle(plat-
Quoted 1 line

phandlepart.phandle);

drivers/misc/fs_loader.c +18 -0
+
+		struct udevice *mmc_dev = NULL;
+
+		ret = device_get_global_by_ofnode(node, &mmc_dev);
+		if (!ret) {
+			struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
+			struct udevice *dev;
+
+			if (blk_get_from_parent(mmc->dev, &dev))
+			{
+				debug("MMC: No block device: %d\n",
+					ret);
+
+				return ret;
+			}
+		}
+	}
+#endif

  return 0;
 };