Skip to contentSkip to conversation

powerpc: build dtb even without COMPILE_TEST

PATCH In review Corentin Labbe 3 participants 3 messages Jan 4, 2019 – Jan 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: build dtb even without COMPILE_TEST

I wanted to test the virtex440-ml507 qemu machine and found that the dtb for it was not builded.
All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on COMPILE_TEST.
But building DTB is not related to a "compile build test".

So this patch made building of DTB independent of COMPILE_TEST (by depending only on the PPC arch)
A better selection of which DTB to build could be done in the future like that do the ARM arch.

---
 arch/powerpc/boot/dts/Makefile     | 2 +-
 arch/powerpc/boot/dts/fsl/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/boot/dts/Makefile +1 -1
index fb335d05aae8..3a73cf41585b 100644
@@ -3,4 +3,4 @@
 subdir-y += fsl
 
 dtstree		:= $(srctree)/$(src)
-dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
+dtb-$(CONFIG_PPC) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
arch/powerpc/boot/dts/fsl/Makefile +1 -1
index 3bae982641e9..27c5ca3a35be 100644
@@ -1,4 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0
 
 dtstree		:= $(srctree)/$(src)
-dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
+dtb-$(CONFIG_PPC) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
Signature · 1 line
2.19.2
#1 lore raw
Quoted 3 lines · Corentin Labbe

I wanted to test the virtex440-ml507 qemu machine and found that the dtb for it was not builded.

Just do:

make virtex440-ml507.dtb

Quoted 3 lines

All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on COMPILE_TEST.
But building DTB is not related to a "compile build test".

But it is. We normally only build the dtbs for enabled platforms just like we only build platform/driver code for enabled platforms. It's hidden behind COMPILE_TEST so it only gets enabled for allmodconfig/allyesconfig builds.

Quoted 4 lines

So this patch made building of DTB independent of COMPILE_TEST (by depending only on the PPC arch)
A better selection of which DTB to build could be done in the future like that do the ARM arch.

No reason you can't start that now for the platform you care about. You don't have to convert everyone.

Rob

#2 lore raw
Quoted 8 lines · Rob Herring
Quoted 3 lines · Corentin Labbe

I wanted to test the virtex440-ml507 qemu machine and found that the dtb for it was not builded.

Just do:

make virtex440-ml507.dtb

I actually thought you had to do that, so I've never done anything different.

Quoted 9 lines
Quoted 3 lines

All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on COMPILE_TEST.
But building DTB is not related to a "compile build test".

But it is. We normally only build the dtbs for enabled platforms just like we only build platform/driver code for enabled platforms. It's hidden behind COMPILE_TEST so it only gets enabled for allmodconfig/allyesconfig builds.

Quoted 7 lines
Quoted 4 lines

So this patch made building of DTB independent of COMPILE_TEST (by depending only on the PPC arch)
A better selection of which DTB to build could be done in the future like that do the ARM arch.

No reason you can't start that now for the platform you care about. You don't have to convert everyone.

Yeah that seems like the best option. I'm happy to take a patch just for that target.

cheers