net: bridge: fix a bug on using a neighbour cache entry without checking its state
Subsystems (4)
PATCH 1/1 net: bridge: fix a bug on using a neighbour cache entry without checking its state
From: JianJhen Chen <[email protected]>
When handling DNAT'ed packets on a bridge device, the neighbour cache entry from lookup was used without checking its state. It means that a cache entry in the NUD_STALE state will be used directly instead of entering the NUD_DELAY state to confirm the reachability of the neighbor.
This problem becomes worse after commit 2724680bceee ("neigh: Keep neighbour cache entries if number of them is small enough."), since all neighbour cache entries in the NUD_STALE state will be kept in the neighbour table as long as the number of cache entries does not exceed the value specified in gc_thresh1.
This commit validates the state of a neighbour cache entry before using the entry.
--- net/bridge/br_netfilter_hooks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_netfilter_hooks.c +1 -1
@@ -278,7 +278,7 @@ int br_nf_pre_routing_finish_bridge(struct net *net, struct sock *sk, struct sk_struct nf_bridge_info *nf_bridge =nf_bridge_info_get (skb);int ret; -if (neigh->hh.hh_len) { +if ((neigh->nud_state &NUD_CONNECTED ) && neigh->hh.hh_len) {neigh_hh_bridge (&neigh->hh, skb); skb->dev = nf_bridge->physindev; ret =br_handle_frame_finish (net, sk, skb);
Signature · 1 line
2.7.4
David Miller
maintainerFrom: kchen <[email protected]>
Date: Sun, 6 Jan 2019 11:28:13 +0800
Quoted 12 lines
From: JianJhen Chen <[email protected]>
When handling DNAT'ed packets on a bridge device, the neighbour cache entry from lookup was used without checking its state. It means that a cache entry in the
NUD_STALEstate will be used directly instead of entering theNUD_DELAYstate to confirm the reachability of the neighbor.This problem becomes worse after commit
2724680bceee("neigh: Keep neighbour cache entries if number of them is small enough."), since all neighbour cache entries in theNUD_STALEstate will be kept in the neighbour table as long as the number of cache entries does not exceed the value specified ingc_thresh1.
Quoted 5 lines
This commit validates the state of a neighbour cache entry before using the entry.
Signed-off-by JianJhen Chen <[email protected]>Reviewed-by JinLin Chen <[email protected]>
Indeed, this looks correct.
Applied and queued up for -stable, thanks.
From: David Miller <[email protected]>
Date: Mon, 07 Jan 2019 09:10:31 -0800
Quoted 20 lines
From: David Miller <[email protected]>
From: kchen <[email protected]>
Date: Sun, 6 Jan 2019 11:28:13 +0800Quoted 15 lines
From: JianJhen Chen <[email protected]>
When handling DNAT'ed packets on a bridge device, the neighbour cache entry from lookup was used without checking its state. It means that a cache entry in the
NUD_STALEstate will be used directly instead of entering theNUD_DELAYstate to confirm the reachability of the neighbor.This problem becomes worse after commit
2724680bceee("neigh: Keep neighbour cache entries if number of them is small enough."), since all neighbour cache entries in theNUD_STALEstate will be kept in the neighbour table as long as the number of cache entries does not exceed the value specified ingc_thresh1.This commit validates the state of a neighbour cache entry before using the entry.
Quoted 7 lines
Quoted 2 lines
Signed-off-by JianJhen Chen <[email protected]>Reviewed-by JinLin Chen <[email protected]>Indeed, this looks correct.
Applied and queued up for -stable, thanks.
Thank you for the confirmation.