patch "staging: rtl8188eu: Fix module loading from tasklet for WEP" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: rtl8188eu: Fix module loading from tasklet for WEP
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 7775665aadc48a562051834a73519129bf717d73 Mon Sep 17 00:00:00 2001
From: Larry Finger <[email protected]>
Date: Wed, 2 Jan 2019 20:12:47 -0600
Subject: staging: rtl8188eu: Fix module loading from tasklet for WEP
encryption
Commit 2b2ea09e74a5 ("staging:r8188eu: Use lib80211 to decrypt WEP-frames") causes scheduling while atomic bugs followed by a hard freeze whenever the driver tries to connect to a WEP-encrypted network. Experimentation showed that the freezes were eliminated when module lib80211 was preloaded, which can be forced by calling lib80211_get_crypto_ops() directly rather than indirectly through try_then_request_module(). With this change, no BUG messages are logged.
--- drivers/staging/rtl8188eu/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/core/rtw_security.c +2 -2
@@ -154,7 +154,7 @@ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) pframe = ((struct xmit_frame *)pxmitframe)->buf_addr + hw_hdr_offset; - crypto_ops =try_then_request_module (lib80211_get_crypto_ops ("WEP" ),"lib80211_crypt_wep" ); + crypto_ops =lib80211_get_crypto_ops ("WEP" );if (!crypto_ops)return ;
@@ -210,7 +210,7 @@ int rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe)void *crypto_private =NULL ;int status = _SUCCESS;const int keyindex = prxattrib->key_index; -struct lib80211_crypto_ops *crypto_ops =try_then_request_module (lib80211_get_crypto_ops ("WEP" ),"lib80211_crypt_wep" ); +struct lib80211_crypto_ops *crypto_ops =lib80211_get_crypto_ops ("WEP" );char iv[4 ], icv[4 ];if (!crypto_ops) {
Signature · 1 line
2.20.1