Skip to contentSkip to conversation

examples/vhost: remove unnecessary method and constant

PATCH Applied Rami Rosen 2 participants 3 messages Jan 9, 2019 – Jan 10, 2019

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 examples/vhost: remove unnecessary method and constant

This cleanup patch removes a method and a constant which are now unnecessary in the VHOST sample applicaiopn, namely the validate_num_devices() method and the MAX_DEVICES constant.

Fixes 56fe86f8dcaf ("examples/vhost: embed statistics into device structure")
---
 examples/vhost/main.c | 22 ----------------------
 1 file changed, 22 deletions(-)
examples/vhost/main.c +0 -22
index dc9ea10..f722a13 100644
@@ -55,9 +55,6 @@
 
 #define INVALID_PORT_ID 0xFF
 
-/* Max number of devices. Limited by vmdq. */
-#define MAX_DEVICES 64
-
 /* Maximum long option length for option parsing. */
 #define MAX_LONG_OPT_SZ 64
 
@@ -215,21 +212,6 @@ struct mbuf_table {
 }
 
 /*
- * Validate the device number according to the max pool number gotten form
- * dev_info. If the device number is invalid, give the error message and
- * return -1. Each device must have its own pool.
- */
-static inline int
-validate_num_devices(uint32_t max_nb_devices)
-{
-	if (num_devices > max_nb_devices) {
-		RTE_LOG(ERR, VHOST_PORT, "invalid number of devices\n");
-		return -1;
-	}
-	return 0;
-}
-
-/*
  * Initialises a given port using global settings and with the rx buffers
  * coming from the mbuf_pool passed as parameter
  */
@@ -270,10 +252,6 @@ struct mbuf_table {
 
 	tx_rings = (uint16_t)rte_lcore_count();
 
-	retval = validate_num_devices(MAX_DEVICES);
-	if (retval < 0)
-		return retval;
-
 	/* Get port configuration. */
 	retval = get_eth_conf(&port_conf, num_devices);
 	if (retval < 0)
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Rami Rosen

This cleanup patch removes a method and a constant which are now unnecessary in the VHOST sample applicaiopn, namely the

s/applicaiopn/application/

Quoted 10 lines

validate_num_devices() method and the MAX_DEVICES constant.

Fixes 56fe86f8dcaf ("examples/vhost: embed statistics into device structure")
---
  examples/vhost/main.c | 22 ----------------------
  1 file changed, 22 deletions(-)

No need to resend, I'll fix while applying:

Thanks,
Maxime

#2 lore raw
In reply to Rami Rosen
Quoted 11 lines · Rami Rosen

This cleanup patch removes a method and a constant which are now unnecessary in the VHOST sample applicaiopn, namely the validate_num_devices() method and the MAX_DEVICES constant.

Fixes 56fe86f8dcaf ("examples/vhost: embed statistics into device structure")
---
  examples/vhost/main.c | 22 ----------------------
  1 file changed, 22 deletions(-)

Applied to dpdk-next-virtio with fixing commit message typo, and also removing the Cc to stable, as IIUC it is more a cleanup than fixing a real problem.

Thanks,
Maxime