Skip to contentSkip to conversation

drivers/usb/storage/jumpshot.c: Remove duplicate header

PATCH NAK Sabyasachi Gupta 2 participants 2 messages Jan 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/usb/storage/jumpshot.c: Remove duplicate header

Remove unusual_jumpshot.h which is included more than once.

---
 drivers/usb/storage/jumpshot.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/storage/jumpshot.c +0 -1
index 917f170..06e46c6 100644
@@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
 }
 
 static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
-#	include "unusual_jumpshot.h"
 	{ }		/* Terminating entry */
 };
 
#1 lore raw
Quoted 12 lines · Sabyasachi Gupta

Remove unusual_jumpshot.h which is included more than once.

---
 drivers/usb/storage/jumpshot.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/storage/jumpshot.c +0 -0
index 917f170..06e46c6 100644

drivers/usb/storage/jumpshot.c MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids); · line 89

Quoted 7 lines
drivers/usb/storage/jumpshot.c +0 -1
@@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
 }
 
 static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
-#	include "unusual_jumpshot.h"
 	{ }		/* Terminating entry */
 };
 

NACK.

It is included twice because the same device needs to be specified and is quirky. You are breaking the driver.

Regards
Oliver