Skip to contentSkip to conversation

build: fix incorrect variable name in error message

PATCH Applied Bruce Richardson 3 participants 3 messages Jan 10, 2019 – Jan 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: fix incorrect variable name in error message

The variable name in the error message had an extra '_' which caused an actual meson error when the message would otherwise be printed to give meaningful information about what was going wrong.

Fixes 203b61dc5e18 ("build: improve error message for missing dependency")
---
 lib/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/meson.build +1 -1
index a2dd52e17..93d7901d4 100644
@@ -79,7 +79,7 @@ foreach l:libraries
 			foreach d:deps
 				if not is_variable('shared_rte_' + d)
 					error('Missing dependency ' + d +
-						' for library ' + lib_name)
+						' for library ' + libname)
 				endif
 				shared_deps += [get_variable('shared_rte_' + d)]
 				static_deps += [get_variable('static_rte_' + d)]
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Bruce Richardson

The variable name in the error message had an extra '_' which caused an actual meson error when the message would otherwise be printed to give meaningful information about what was going wrong.

Fixes 203b61dc5e18 ("build: improve error message for missing

dependency")
CC: [email protected]

---
 lib/meson.build | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
lib/meson.build +0 -0
index a2dd52e17..93d7901d4 100644
@@ -79,7 +79,7 @@ foreach l:libraries

  foreach d:deps
  if not is_variable('shared_rte_' +
d)
  error('Missing dependency '
+ d +

lib/meson.build +0 -1
-						' for library ' +

lib_name)

lib/meson.build +1 -0
+						' for library ' +
Quoted 6 lines

libname)
  endif
  shared_deps +=
[get_variable('shared_rte_' + d)]
  static_deps +=
[get_variable('static_rte_' + d)]

Signature · 2 lines
Kind regards,
Luca Boccassi
#2 lore raw

10/01/2019 14:10, Luca Boccassi:

Quoted 5 lines · Bruce Richardson
Quoted 4 lines

The variable name in the error message had an extra '_' which caused an actual meson error when the message would otherwise be printed to give meaningful information about what was going wrong.

Quoted 7 lines
Quoted 5 lines
Fixes 203b61dc5e18 ("build: improve error message for missing

dependency")
CC: [email protected]

Applied, thanks