ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup
Subsystems (2)
PATCH 1/1 ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup
Exynos cpufreq drivers does not support device tree based regulator lookup, so it can get the VDD ARM regulator only by its name. To get cpufreq working for now, this patch works this around by renaming the regulator in board dts files to vdd_arm, which is the name expected by the driver.
--- arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++- arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos4210-origen.dts +6 -1
@@ -192,7 +192,12 @@ }; buck1_reg: BUCK1 { - regulator-name = "VDD_ARM_1.2V"; + /* + * HACK: The real name is VDD_ARM_1.2V, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <950000>; regulator-max-microvolt = <1350000>; regulator-always-on;
arch/arm/boot/dts/exynos4210-trats.dts +6 -1
@@ -290,7 +290,12 @@ }; varm_breg: BUCK1 { - regulator-name = "VARM_1.2V_C210"; + /* + * HACK: The real name is VARM_1.2V_C210, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1350000>; regulator-always-on;
Signature · 1 line
1.8.3.2
PATCH 1/1 ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup
Quoted 39 lines · On Tuesday 20 of August 2013 19:35:36 Tomasz Figa wrote:
Exynos cpufreq drivers does not support device tree based regulator lookup, so it can get the VDD ARM regulator only by its name. To get cpufreq working for now, this patch works this around by renaming the regulator in board dts files to
vdd_arm, which is the name expected by the driver.Signed-off-by Tomasz Figa <[email protected]>Signed-off-by Kyungmin Park <[email protected]>--- arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++- arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4210-origen.dtsindex 382d8c7..46378fe 100644arch/arm/boot/dts/exynos4210-origen.dts +6
-1@@ -192,7 +192,12 @@ }; buck1_reg: BUCK1 { - regulator-name = "VDD_ARM_1.2V"; + /* + * HACK: The real name is VDD_ARM_1.2V, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <950000>; regulator-max-microvolt = <1350000>; regulator-always-on;(quoted diff) +0
-0
b/arch/arm/boot/dts/exynos4210-trats.dtsindex 1c164f2..63cc571 100644arch/arm/boot/dts/exynos4210-trats.dts +0
-0@@ -290,7 +290,12 @@ }; varm_breg: BUCK1 {
arch/arm/boot/dts/exynos4210-trats.dts line 301
Quoted 10 lines
arch/arm/boot/dts/exynos4210-trats.dts +6
-1- regulator-name = "VARM_1.2V_C210"; + /* + * HACK: The real name is VARM_1.2V_C210, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1350000>; regulator-always-on;
Ping.
This patch fixes broken cpufreq on above two boards, so it would be nice to have it merged for 3.12, even if it's a bit hacky, since it's too late for proper solution at the moment. (It's already in development, though.)
Best regards,
Tomasz
PATCH RESEND 1/1 ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup
Exynos cpufreq drivers does not support device tree based regulator lookup, so it can get the VDD ARM regulator only by its name. To get cpufreq working for now, this patch works this around by renaming the regulator in board dts files to vdd_arm, which is the name expected by the driver.
This fixes a regression introduced by dropping support of board file based bootup of Exynos 4210 boards that rendered cpufreq inoperable on Trats and Origen boards.
--- arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++- arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-)
Resending again, since my mail client previously freaked out and reset message format to HTML...
arch/arm/boot/dts/exynos4210-origen.dts +6 -1
@@ -192,7 +192,12 @@ }; buck1_reg: BUCK1 { - regulator-name = "VDD_ARM_1.2V"; + /* + * HACK: The real name is VDD_ARM_1.2V, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <950000>; regulator-max-microvolt = <1350000>; regulator-always-on;
arch/arm/boot/dts/exynos4210-trats.dts +6 -1
@@ -290,7 +290,12 @@ }; varm_breg: BUCK1 { - regulator-name = "VARM_1.2V_C210"; + /* + * HACK: The real name is VARM_1.2V_C210, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1350000>; regulator-always-on;
Signature · 1 line
1.8.3.2