Skip to contentSkip to conversation

drm: Add panel support for PDA 91-00156-A0

PATCH Applied [email protected] 4 participants 10 messages Jan 14, 2019 – Jan 28, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover drm: Add panel support for PDA 91-00156-A0

From: Eugen Hristev <[email protected]>

Hello,

This patch series adds support for PDA (Precision Design Associates, Inc.) vendor, and for the PDA 91-00156-A0 simple panel, together with the bindings.

The series is on top of http://anongit.freedesktop.org/git/drm/drm.git drm-next branch.

Changes in v2:
- According to Rob Herring's review, added backlight and supply binding to the .../devicetree/bindings/display/panel/pda,91-00156-a0.txt to comply with the simple-panel bindings

Cristian Birsan (1):
dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0

Eugen Hristev (2):
dt-bindings: add vendor prefix for PDA Precision Design Associates,
Inc.
drm/panel: simple: add support for PDA 91-00156-A0 panel

 .../bindings/display/panel/pda,91-00156-a0.txt     | 14 +++++++++++
 .../devicetree/bindings/vendor-prefixes.txt        |  1 +
 drivers/gpu/drm/panel/panel-simple.c               | 27 ++++++++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/3 dt-bindings: add vendor prefix for PDA Precision Design Associates, Inc.

From: Eugen Hristev <[email protected]>

Precision Design Associates, Inc. (PDA) manufactures standard and custom capacitive touch screens, LCD's embedded controllers and custom embedded software. They specialize in industrial, rugged and outdoor applications.
Website: http://www.pdaatl.com/

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 3895085..967a670 100644
@@ -297,6 +297,7 @@ ovti	OmniVision Technologies
 oxsemi	Oxford Semiconductor, Ltd.
 panasonic	Panasonic Corporation
 parade	Parade Technologies Inc.
+pda	Precision Design Associates, Inc.
 pericom	Pericom Technology Inc.
 pervasive	Pervasive Displays, Inc.
 phicomm PHICOMM Co., Ltd.
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH v2 1/3] dt-bindings: add vendor prefix for PDA Precision Design Associates, Inc.

Hi Eugen.

Quoted 18 lines · On Mon, Jan 14, 2019 at 09:43:26AM +0000, [email protected] wrote:

From: Eugen Hristev <[email protected]>

Precision Design Associates, Inc. (PDA) manufactures standard and custom capacitive touch screens, LCD's embedded controllers and custom embedded software. They specialize in industrial, rugged and outdoor applications.
Website: http://www.pdaatl.com/

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
index 3895085..967a670 100644

Documentation/devicetree/bindings/vendor-prefixes.txt ovti OmniVision Technologies · line 300

Quoted 4 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -297,6 +297,7 @@ ovti	OmniVision Technologies
 oxsemi	Oxford Semiconductor, Ltd.
 panasonic	Panasonic Corporation
 parade	Parade Technologies Inc.
+pda	Precision Design Associates, Inc.

The website uses "pdaatl" - which looks a little less generic than just "pda". But then I do not get any association from pdaatl to Precision Design Associates) so you can say it is not a good abbrevation either.

Sam

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH v2 1/3] dt-bindings: add vendor prefix for PDA Precision Design Associates, Inc.

In reply to [email protected]
Quoted 7 lines · On Mon, Jan 14, 2019 at 09:43:26AM +0000, [email protected] wrote:

From: Eugen Hristev <[email protected]>

Precision Design Associates, Inc. (PDA) manufactures standard and custom capacitive touch screens, LCD's embedded controllers and custom embedded software. They specialize in industrial, rugged and outdoor applications.
Website: http://www.pdaatl.com/

Quoted 5 lines
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

Applied to drm-misc-next, thanks.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw

PATCH v2 2/3 dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0

In reply to [email protected]

From: Cristian Birsan <[email protected]>

PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5).
Adding Device Tree bindings for this panel.

[[email protected]]: specified backlight and supply bindings

---
Changes in v2:
- added binding explanations for required properties from simple-panel:
backlight and power supply which are mandatory

 .../devicetree/bindings/display/panel/pda,91-00156-a0.txt  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt new file +14 -0
new file mode 100644
index 0000000..1639fb1
@@ -0,0 +1,14 @@
+PDA 91-00156-A0 5.0" WVGA TFT LCD panel
+
+Required properties:
+- compatible: should be "pda,91-00156-a0"
+- power-supply: this panel requires a single power supply. A phandle to a
+regulator needs to be specified here. Compatible with panel-common binding which
+is specified in the panel-common.txt in this directory.
+- backlight: this panel's backlight is controlled by an external backlight
+controller. A phandle to this controller needs to be specified here.
+Compatible with panel-common binding which is specified in the panel-common.txt
+in this directory.
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
Signature · 1 line
2.7.4
maintainer Reviewed-by on v2 2/3
#5 lore raw

Re: [PATCH v2 2/3] dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0

Quoted 10 lines · On Mon, 14 Jan 2019 09:43:28 +0000, <[email protected]> wrote:

From: Cristian Birsan <[email protected]>

PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5).
Adding Device Tree bindings for this panel.

[[email protected]]: specified backlight and supply bindings

Quoted 9 lines

---
Changes in v2:
- added binding explanations for required properties from simple-panel:
backlight and power supply which are mandatory

 .../devicetree/bindings/display/panel/pda,91-00156-a0.txt  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
#6 lore raw

Re: [PATCH v2 2/3] dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0

In reply to [email protected]
Quoted 10 lines · On Mon, Jan 14, 2019 at 09:43:28AM +0000, [email protected] wrote:

From: Cristian Birsan <[email protected]>

PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5).
Adding Device Tree bindings for this panel.

[[email protected]]: specified backlight and supply bindings

Quoted 8 lines

---
Changes in v2:
- added binding explanations for required properties from simple-panel:
backlight and power supply which are mandatory

 .../devicetree/bindings/display/panel/pda,91-00156-a0.txt  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt

Applied to drm-misc-next, thanks.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw

PATCH v2 3/3 drm/panel: simple: add support for PDA 91-00156-A0 panel

In reply to [email protected]

From: Eugen Hristev <[email protected]>

PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5).

---
 drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +27 -0
index 9c69e73..61361ba 100644
@@ -2008,6 +2008,30 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
 };
 
+static const struct drm_display_mode pda_91_00156_a0_mode = {
+	.clock = 33300,
+	.hdisplay = 800,
+	.hsync_start = 800 + 1,
+	.hsync_end = 800 + 1 + 64,
+	.htotal = 800 + 1 + 64 + 64,
+	.vdisplay = 480,
+	.vsync_start = 480 + 1,
+	.vsync_end = 480 + 1 + 23,
+	.vtotal = 480 + 1 + 23 + 22,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc pda_91_00156_a0  = {
+	.modes = &pda_91_00156_a0_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};
+
+
 static const struct drm_display_mode qd43003c0_40_mode = {
 	.clock = 9000,
 	.hdisplay = 480,
@@ -2686,6 +2710,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "ortustech,com43h4m85ulc",
 		.data = &ortustech_com43h4m85ulc,
 	}, {
+		.compatible = "pda,91-00156-a0",
+		.data = &pda_91_00156_a0,
+	}, {
 		.compatible = "qiaodian,qd43003c0-40",
 		.data = &qd43003c0_40,
 	}, {
Signature · 1 line
2.7.4
#8 lore raw

Re: [PATCH v2 3/3] drm/panel: simple: add support for PDA 91-00156-A0 panel

Hi Eugen.

Patch looks good, but a small improvement proposal.

Quoted 21 lines · On Mon, Jan 14, 2019 at 09:43:31AM +0000, [email protected] wrote:

From: Eugen Hristev <[email protected]>

PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5).

---
 drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 9c69e73..61361ba 100644
@@ -2008,6 +2008,30 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
 };
 
+static const struct drm_display_mode pda_91_00156_a0_mode = {
+	.clock = 33300,

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc ortustech_com43h4m85ulc = { · line 2022

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+	.hdisplay = 800,
+	.hsync_start = 800 + 1,
+	.hsync_end = 800 + 1 + 64,
+	.htotal = 800 + 1 + 64 + 64,
+	.vdisplay = 480,
+	.vsync_start = 480 + 1,
+	.vsync_end = 480 + 1 + 23,
+	.vtotal = 480 + 1 + 23 + 22,
+	.vrefresh = 60,
+};

.flags are omitted, as it is for many panels in simple-panel. drm_modes.h do not document any default, so we must assume default equals no flags.

I would expect two of these as a minimum:
DRM_MODE_FLAG_PHSYNC: horizontal sync is active high.
DRM_MODE_FLAG_NHSYNC: horizontal sync is active low.
DRM_MODE_FLAG_PVSYNC: vertical sync is active high.
DRM_MODE_FLAG_NVSYNC: vertical sync is active low.

But it obviously works for a lot of panel, so one
may say why bother with it.

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc ortustech_com43h4m85ulc = { · line 2032

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+
+static const struct panel_desc pda_91_00156_a0  = {
+	.modes = &pda_91_00156_a0_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+};

.bus_format is specified - good!

Consider if .bus_flags needs to be specified. (More or less same argumentation like for .flags above).

I could not find any data-sheet on the panel, so I could not check if it is OK that all delays are 0.

So to recap - things looks fine, but consider to be more explicit in .flags, bus_flags, and check if it is OK that all timing parameters are 0.

Sam

#9 lore raw

Re: [PATCH v2 3/3] drm/panel: simple: add support for PDA 91-00156-A0 panel

In reply to [email protected]
Quoted 10 lines · On Mon, Jan 14, 2019 at 09:43:31AM +0000, [email protected] wrote:

From: Eugen Hristev <[email protected]>

PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5).

---
 drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Applied to drm-misc-next, thanks.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel