Skip to contentSkip to conversation

media: ov8856: Modify ov8856 register reading function to be simplified

PATCH New Ben Kao 1 participant 1 message Jan 15, 2019

Subsystems (3)
Media (V4L/DVB) V4L2 camera sensor drivers Omnivision OV8856 sensor driver
lore
Share & tools
lore

Ben Kao

author
#0 lore raw

PATCH 1/1 media: ov8856: Modify ov8856 register reading function to be simplified

We use put_unaligned_be16() to be simplified for setting register address in ov8856_read_reg() and use sizeof() to be better suited for bytes copying.

Signed-off-by Ben Kao <[email protected]>
---
 drivers/media/i2c/ov8856.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/media/i2c/ov8856.c +4 -3
index c0d4408..dbf1095 100644
@@ -605,16 +605,17 @@ static int ov8856_read_reg(struct ov8856 *ov8856, u16 reg, u16 len, u32 *val)
 {
 	struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd);
 	struct i2c_msg msgs[2];
-	u8 addr_buf[2] = {reg >> 8, reg & 0xff};
-	u8 data_buf[4] = {0, };
+	u8 addr_buf[2];
+	u8 data_buf[4] = {0};
 	int ret;
 
 	if (len > 4)
 		return -EINVAL;
 
+	put_unaligned_be16(reg, addr_buf);
 	msgs[0].addr = client->addr;
 	msgs[0].flags = 0;
-	msgs[0].len = ARRAY_SIZE(addr_buf);
+	msgs[0].len = sizeof(addr_buf);
 	msgs[0].buf = addr_buf;
 	msgs[1].addr = client->addr;
 	msgs[1].flags = I2C_M_RD;
Signature · 1 line
2.7.4