seccomp: Work-around GCC 4.x bug in gnu99 mode
PATCH 1/1 seccomp: Work-around GCC 4.x bug in gnu99 mode
We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently fails to compile qemu-seccomp.c in this mode:
qemu-seccomp.c:45:1: error: initializer element is not constant
};
^
qemu-seccomp.c:45:1: error: (near initialization for ‘sched_setscheduler_arg[0]’)
This is due to a compiler bug which has just been fixed in GCC 5.0:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63567
Since we still want to support GCC 4.8 for a while and also want to use gnu99 mode, work-around the issue by expanding the macro manually.
--- qemu-seccomp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
qemu-seccomp.c +2 -1
@@ -41,7 +41,8 @@ struct QemuSeccompSyscall { };const struct scmp_arg_cmp sched_setscheduler_arg[] = { -SCMP_A1 (SCMP_CMP_NE ,SCHED_IDLE ) +/* was SCMP_A1(SCMP_CMP_NE, SCHED_IDLE), but expanded due to GCC 4.x bug */ + { .arg =1 , .op =SCMP_CMP_NE , .datum_a =SCHED_IDLE } };static const struct QemuSeccompSyscall blacklist[] = {
Signature · 1 line
1.8.3.1
Quoted 25 lines · Thomas Huth
We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently fails to compile
qemu-seccomp.cin this mode:qemu-seccomp.c:45:1: error: initializer element is not constant
};
^
qemu-seccomp.c:45:1: error: (near initialization for ‘sched_setscheduler_arg[0]’)This is due to a compiler bug which has just been fixed in GCC 5.0:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63567
Since we still want to support GCC 4.8 for a while and also want to use gnu99 mode, work-around the issue by expanding the macro manually.
Signed-off-by Thomas Huth <[email protected]>--- qemu-seccomp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)qemu-seccomp.c +0
-0
qemu-seccomp.c struct QemuSeccompSyscall { · line 46
Quoted 7 lines
qemu-seccomp.c +2
-1@@ -41,7 +41,8 @@ struct QemuSeccompSyscall { };const struct scmp_arg_cmp sched_setscheduler_arg[] = { -SCMP_A1 (SCMP_CMP_NE ,SCHED_IDLE ) +/* was SCMP_A1(SCMP_CMP_NE, SCHED_IDLE), but expanded due to GCC 4.x bug */ + { .arg =1 , .op =SCMP_CMP_NE , .datum_a =SCHED_IDLE } };
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 8 lines · Thomas Huth
We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently fails to compile
qemu-seccomp.cin this mode:qemu-seccomp.c:45:1: error: initializer element is not constant
};
^
qemu-seccomp.c:45:1: error: (near initialization for ‘sched_setscheduler_arg[0]’)
Quoted 8 lines
This is due to a compiler bug which has just been fixed in GCC 5.0:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63567
Since we still want to support GCC 4.8 for a while and also want to use gnu99 mode, work-around the issue by expanding the macro manually.
Signed-off-by Thomas Huth <[email protected]>
Quoted 19 lines
--- qemu-seccomp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)qemu-seccomp.c +2
-1@@ -41,7 +41,8 @@ struct QemuSeccompSyscall { };const struct scmp_arg_cmp sched_setscheduler_arg[] = { -SCMP_A1 (SCMP_CMP_NE ,SCHED_IDLE ) +/* was SCMP_A1(SCMP_CMP_NE, SCHED_IDLE), but expanded due to GCC 4.x bug */ + { .arg =1 , .op =SCMP_CMP_NE , .datum_a =SCHED_IDLE } };static const struct QemuSeccompSyscall blacklist[] = {
Quoted 37 lines · Thomas Huth
We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently fails to compile
qemu-seccomp.cin this mode:qemu-seccomp.c:45:1: error: initializer element is not constant
};
^
qemu-seccomp.c:45:1: error: (near initialization for ‘sched_setscheduler_arg[0]’)This is due to a compiler bug which has just been fixed in GCC 5.0:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63567
Since we still want to support GCC 4.8 for a while and also want to use gnu99 mode, work-around the issue by expanding the macro manually.
Signed-off-by Thomas Huth <[email protected]>--- qemu-seccomp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)qemu-seccomp.c +2
-1@@ -41,7 +41,8 @@ struct QemuSeccompSyscall { };const struct scmp_arg_cmp sched_setscheduler_arg[] = { -SCMP_A1 (SCMP_CMP_NE ,SCHED_IDLE ) +/* was SCMP_A1(SCMP_CMP_NE, SCHED_IDLE), but expanded due to GCC 4.x bug */ + { .arg =1 , .op =SCMP_CMP_NE , .datum_a =SCHED_IDLE } };static const struct QemuSeccompSyscall blacklist[] = {Signature · 1 line
1.8.3.1
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14 === TEST SCRIPT END ===
CC backends/rng-egd.o
CC backends/tpm.o/tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':/tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
The full log is available at
http://patchew.org/logs/[email protected]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]
Quoted 21 lines · On 23/01/2019 - 07:57:51, [email protected] wrote:
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14 === TEST SCRIPT END ===CC
backends/rng-egd.o
CCbackends/tpm.o/tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':/tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 8 lines
cc1: all warnings being treated as errors
The full log is available at
http://patchew.org/logs/[email protected]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]
This issue was not introduced by the patch itself. Will send a pull request anyways.
Signature · 1 line
Eduardo Otubo