Skip to contentSkip to conversation

doc: fix an error in ifc NIC document

PATCH Applied Rami Rosen 3 participants 4 messages Jan 17, 2019 – Jan 18, 2019

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 doc: fix an error in ifc NIC document

This patch fixes an error in ifc NIC document; a previous patch changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
but the ifc NIC doc file remained with the old name.

Fixes 4b614e9504a1 ("net/ifc: make driver name consistent")
---
 doc/guides/nics/ifc.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/nics/ifc.rst +1 -1
index bdf7b4e..317d9ff 100644
@@ -19,7 +19,7 @@ Config File Options
 
 The following option can be modified in the ``config`` file.
 
-- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
+- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
 
   Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
 
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1 Applied
#1 lore raw
Quoted 8 lines · Rami Rosen

This patch fixes an error in ifc NIC document; a previous patch changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
but the ifc NIC doc file remained with the old name.

Fixes 4b614e9504a1 ("net/ifc: make driver name consistent")

Applied to dpdk-next-net/master, thanks.

#2 lore raw
In reply to Rami Rosen

Hi,

Quoted 25 lines

-----Original Message-----
From: Rami Rosen [mailto:[email protected]]
Sent: Thursday, January 17, 2019 10:51 PM
To: [email protected]
Cc: [email protected]; Wang, Xiao W <[email protected]>; Rami Rosen <[email protected]>
Subject: [PATCH] doc: fix an error in ifc NIC document

This patch fixes an error in ifc NIC document; a previous patch changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
but the ifc NIC doc file remained with the old name.

Fixes 4b614e9504a1 ("net/ifc: make driver name consistent")
---
 doc/guides/nics/ifc.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/nics/ifc.rst +0 -0
index bdf7b4e..317d9ff 100644

doc/guides/nics/ifc.rst Config File Options · line 24

Quoted 7 lines
doc/guides/nics/ifc.rst +1 -1
@@ -19,7 +19,7 @@ Config File Options
 
 The following option can be modified in the ``config`` file.
 
-- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
+- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
 
   Toggle compilation of the ``librte_ifcvf_vdpa`` driver.

Could we also squash below fix into this patch? Or we make a separate one since this patch is applied already.

- Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
+ Toggle compilation of the ``librte_pmd_ifc`` driver.

BRs,
Xiao

#3 lore raw
Quoted 37 lines · Xiao W

Hi,

Quoted 25 lines

-----Original Message-----
From: Rami Rosen [mailto:[email protected]]
Sent: Thursday, January 17, 2019 10:51 PM
To: [email protected]
Cc: [email protected]; Wang, Xiao W <[email protected]>; Rami Rosen <[email protected]>
Subject: [PATCH] doc: fix an error in ifc NIC document

This patch fixes an error in ifc NIC document; a previous patch changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
but the ifc NIC doc file remained with the old name.

Fixes 4b614e9504a1 ("net/ifc: make driver name consistent")
---
 doc/guides/nics/ifc.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/nics/ifc.rst +0 -0
index bdf7b4e..317d9ff 100644

doc/guides/nics/ifc.rst Config File Options · line 24

Quoted 7 lines
doc/guides/nics/ifc.rst +1 -1
@@ -19,7 +19,7 @@ Config File Options
 
 The following option can be modified in the ``config`` file.
 
-- ``CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD`` (default ``y`` for linux)
+- ``CONFIG_RTE_LIBRTE_IFC_PMD`` (default ``y`` for linux)
 
   Toggle compilation of the ``librte_ifcvf_vdpa`` driver.

Could we also squash below fix into this patch? Or we make a separate one since this patch is applied already.

Review

Quoted 2 lines
(quoted diff) +1 -1
-  Toggle compilation of the ``librte_ifcvf_vdpa`` driver.
+  Toggle compilation of the ``librte_pmd_ifc`` driver.

Thanks for update.

Squashed in next-net, please check.