Skip to contentSkip to conversation

spl: fat/fs: Add control to build FS EXT4 in SPL

PATCH New tien.fong.chee at intel.com 3 participants 3 messages Jan 17, 2019 – Jan 18, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spl: fat/fs: Add control to build FS EXT4 in SPL

From: Tien Fong Chee <[email protected]>

CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB memory.

---
 fs/fs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
fs/fs.c +3 -1
index 0b8088b..252e2f5 100644
@@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
 		.closedir = fat_closedir,
 	},
 #endif
-#ifdef CONFIG_FS_EXT4
+/* #ifdef CONFIG_FS_EXT4 */
+#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
+	(defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT))
 	{
 		.fstype = FS_TYPE_EXT,
 		.name = "ext4",
Signature · 1 line
1.7.7.4
#1 lore raw

PATCH 1/1 spl: fat/fs: Add control to build FS EXT4 in SPL

Quoted 16 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB memory.

---
 fs/fs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
fs/fs.c +0 -0
index 0b8088b..252e2f5 100644

fs/fs.c static struct fstype_info fstypes[] = { · line 192

Quoted 10 lines
fs/fs.c +3 -1
@@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
 		.closedir = fat_closedir,
 	},
 #endif
-#ifdef CONFIG_FS_EXT4
+/* #ifdef CONFIG_FS_EXT4 */
+#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
+	(defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT))
 	{
 		.fstype = FS_TYPE_EXT,
 		.name = "ext4",

This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2 patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190117/d63b9445/attachment.sig>
#2 lore raw

PATCH 1/1 spl: fat/fs: Add control to build FS EXT4 in SPL

Quoted 27 lines · Tom Rini
Quoted 24 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from
SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB
memory.

---
 fs/fs.c |    4 +++-

 1 files changed, 3 insertions(+), 1 deletions(-)
fs/fs.c +1 -1
index 0b8088b..252e2f5 100644
@@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
  		.closedir = fat_closedir,
  	},
  #endif
-#ifdef CONFIG_FS_EXT4
+/* #ifdef CONFIG_FS_EXT4 */
Quoted 8 lines
Quoted 6 lines
fs/fs.c +2 -0
+#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
+	(defined(CONFIG_SPL_BUILD) &&
 defined(CONFIG_SPL_EXT_SUPPORT))
  	{
  		.fstype = FS_TYPE_EXT,

  .name = "ext4",

This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2 patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!

Okay.

Quoted 1 line