Skip to contentSkip to conversation

mm/slub: use WARN_ON() for some slab errors

PATCH In review [email protected] 2 participants 3 messages Jan 21, 2019 – Jan 22, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/slub: use WARN_ON() for some slab errors

From: Miles Chen <[email protected]>

When debugging with slub.c, sometimes we have to trigger a panic in order to get the coredump file. To do that, we have to modify slub.c and rebuild kernel. To make debugging easier, use WARN_ON() for these slab errors so we can dump stack trace by default or set panic_on_warn to trigger a panic.

---
 mm/slub.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
mm/slub.c +3 -3
index 1e3d0ec4e200..e48c3bb30c93 100644
@@ -684,7 +684,7 @@ static void print_trailer(struct kmem_cache *s, struct page *page, u8 *p)
 		print_section(KERN_ERR, "Padding ", p + off,
 			      size_from_object(s) - off);
 
-	dump_stack();
+	WARN_ON(1);
 }
 
 void object_err(struct kmem_cache *s, struct page *page,
@@ -705,7 +705,7 @@ static __printf(3, 4) void slab_err(struct kmem_cache *s, struct page *page,
 	va_end(args);
 	slab_bug(s, "%s", buf);
 	print_page_info(page);
-	dump_stack();
+	WARN_ON(1);
 }
 
 static void init_object(struct kmem_cache *s, void *object, u8 val)
@@ -1690,7 +1690,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
 		flags &= ~GFP_SLAB_BUG_MASK;
 		pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
 				invalid_mask, &invalid_mask, flags, &flags);
-		dump_stack();
+		WARN_ON(1);
 	}
 
 	return allocate_slab(s,
Signature · 1 line
2.18.0
#1 lore raw
Quoted 7 lines · On Mon, 21 Jan 2019, [email protected] wrote:

From: Miles Chen <[email protected]>

When debugging with slub.c, sometimes we have to trigger a panic in order to get the coredump file. To do that, we have to modify slub.c and rebuild kernel. To make debugging easier, use WARN_ON() for these slab errors so we can dump stack trace by default or set panic_on_warn to trigger a panic.

These locations really should dump stack and not terminate. There is subsequent processing that should be done.

Slub terminates by default. The messages you are modifying are only enabled if the user specified that special debugging should be one (typically via a kernel parameter slub_debug).

It does not make sense to terminate the process here.

author
#2 lore raw
Quoted 4 lines · Christopher Lameter
Quoted 2 lines · On Mon, 21 Jan 2019, miles.chen-NuS5LvNUpcJWk0Htik3J/[email protected] wrote:

From: Miles Chen <miles.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

Quoted 8 lines
Quoted 5 lines

When debugging with slub.c, sometimes we have to trigger a panic in order to get the coredump file. To do that, we have to modify slub.c and rebuild kernel. To make debugging easier, use WARN_ON() for these slab errors so we can dump stack trace by default or set panic_on_warn to trigger a panic.

These locations really should dump stack and not terminate. There is subsequent processing that should be done.

Understood. We should not terminate the process for normal case. The change only terminate the process when panic_on_warn is set.

Quoted 3 lines

Slub terminates by default. The messages you are modifying are only enabled if the user specified that special debugging should be one (typically via a kernel parameter slub_debug).

I'm a little bit confused about this: Do you mean that I should use the following approach?

1. Add a special debugging flag (say SLAB_PANIC_ON_ERROR) and call panic() by:

if (s->flags & SLAB_PANIC_ON_ERROR)

     panic("slab error");

2. The SLAB_PANIC_ON_ERROR should be set by slub_debug param.

Quoted 1 line

It does not make sense to terminate the process here.

Thanks for you comment. Sometimes it's useful to trigger a panic and get its coredump file before any restore/reset processing because we can exam the unmodified data in the coredump file with this approach.

I added BUG() for the slab errors in internal branches for a few years and it does help for both software issues and bit flipping issues. It's a quite useful in developing stage.

cheers,
Miles