Skip to contentSkip to conversation

Documentation: usb: dwc3: add power down clock scale property

PATCH In review Jun Li 2 participants 4 messages Jan 22, 2019 – Mar 10, 2019

Subsystems (3)
lore
Share & tools
lore

Jun Li

author
#0 lore raw

PATCH 1/2 Documentation: usb: dwc3: add power down clock scale property

The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock source to a small part of the USB3 core that operates when the SS PHY is in its lowest power(P3) state, and therefore does not provide a clock. The power down scale specifies how many suspend_clk periods fit into a 16 KHz clock period, details can see DWC3 databook register GCTL.PWRDNSCALE.

---
 Documentation/devicetree/bindings/usb/dwc3.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/dwc3.txt +6 -0
index 3e4c38b..d1c8b62 100644
@@ -102,6 +102,12 @@ Optional properties:
 			more than one value, which means undefined length INCR burst type
 			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
 
+ - snps,power-down-scale: Power down scale field specifies how many suspend_clk
+			periods fit into a 16 Khz clock period. When performing
+			the division, round up the remainder. Suspend clock is
+			from 32kHz to 125MHz, means the value range is 2~8000.
+			(details see DWC_usb3 databook register GCTL.PWRDNSCALE).
+
  - in addition all properties from usb-xhci.txt from the current directory are
    supported as well
 
author
#1 lore raw

PATCH 2/2 dwc3: add power down clock scale setting when init core

Set the right power down clock scale if the property "snps,power-down-scale" is specified.

---
 drivers/usb/dwc3/core.c | 15 +++++++++++++++
 drivers/usb/dwc3/core.h |  1 +
 2 files changed, 16 insertions(+)
drivers/usb/dwc3/core.c +15 -0
index 88c80fc..c41c0b2 100644
@@ -878,6 +878,19 @@ static void dwc3_set_incr_burst_type(struct dwc3 *dwc)
 	dwc3_writel(dwc->regs, DWC3_GSBUSCFG0, cfg);
 }
 
+static void dwc3_set_power_down_clk_scale(struct dwc3 *dwc)
+{
+	u32 reg, scale;
+
+	if (!device_property_read_u32(dwc->dev, "snps,power-down-scale",
+				      &scale)) {
+		reg = dwc3_readl(dwc->regs, DWC3_GCTL);
+		reg &= ~(DWC3_GCTL_PWRDNSCALE_MASK);
+		reg |= DWC3_GCTL_PWRDNSCALE(scale);
+		dwc3_writel(dwc->regs, DWC3_GCTL, reg);
+	}
+}
+
 /**
  * dwc3_core_init - Low-level initialization of DWC3 Core
  * @dwc: Pointer to our controller context structure
@@ -908,6 +921,8 @@ static int dwc3_core_init(struct dwc3 *dwc)
 			dwc->maximum_speed = USB_SPEED_HIGH;
 	}
 
+	dwc3_set_power_down_clk_scale(dwc);
+
 	ret = dwc3_phy_setup(dwc);
 	if (ret)
 		goto err0;
drivers/usb/dwc3/core.h +1 -0
index 5bfb625..8cdaab3 100644
@@ -216,6 +216,7 @@
 
 /* Global Configuration Register */
 #define DWC3_GCTL_PWRDNSCALE(n)	((n) << 19)
+#define DWC3_GCTL_PWRDNSCALE_MASK	DWC3_GCTL_PWRDNSCALE(0x1fff)
 #define DWC3_GCTL_U2RSTECN	BIT(16)
 #define DWC3_GCTL_RAMCLKSEL(x)	(((x) & DWC3_GCTL_CLK_MASK) << 6)
 #define DWC3_GCTL_CLK_BUS	(0)
maintainer
#2 lore raw
In reply to Jun Li
Quoted 17 lines · Jun Li

The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock source to a small part of the USB3 core that operates when the SS PHY is in its lowest power(P3) state, and therefore does not provide a clock. The power down scale specifies how many suspend_clk periods fit into a 16 KHz clock period, details can see DWC3 databook register GCTL.PWRDNSCALE.

---
 Documentation/devicetree/bindings/usb/dwc3.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/dwc3.txt +0 -0
index 3e4c38b..d1c8b62 100644

Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 110

Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +6 -0
@@ -102,6 +102,12 @@ Optional properties:
 			more than one value, which means undefined length INCR burst type
 			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
 
+ - snps,power-down-scale: Power down scale field specifies how many suspend_clk
+			periods fit into a 16 Khz clock period. When performing
+			the division, round up the remainder. Suspend clock is
+			from 32kHz to 125MHz, means the value range is 2~8000.
+			(details see DWC_usb3 databook register GCTL.PWRDNSCALE).
+

Sounds like the suspend_clk should be provided as a clock input so you can calculate this value.

Quoted 6 lines
Documentation/devicetree/bindings/usb/dwc3.txt +0 -0
  - in addition all properties from usb-xhci.txt from the current directory are
    supported as well
 
Signature · 1 line
2.7.4
author
#3 lore raw
Quoted 34 lines

-----Original Message-----
From: Rob Herring <[email protected]>
Sent: 2019年2月23日 8:33
To: Jun Li <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Subject: Re: [PATCH 1/2] Documentation: usb: dwc3: add power down clock scale property

Quoted 18 lines · Jun Li

The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock source to a small part of the USB3 core that operates when the SS PHY is in its lowest power(P3) state, and therefore does not provide a clock. The power down scale specifies how many suspend_clk periods fit into a 16 KHz clock period, details can see DWC3 databook register GCTL.PWRDNSCALE.

---
 Documentation/devicetree/bindings/usb/dwc3.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/dwc3.txt +0 -0
index 3e4c38b..d1c8b62 100644

Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 105

Quoted 4 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1 -0
@@ -102,6 +102,12 @@ Optional properties:
 			more than one value, which means undefined length INCR burst type
 			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
 
+ - snps,power-down-scale: Power down scale field specifies how many

suspend_clk

Quoted 8 lines

Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 110

Quoted 5 lines
Documentation/devicetree/bindings/usb/dwc3.txt +5 -0
+			periods fit into a 16 Khz clock period. When performing
+			the division, round up the remainder. Suspend clock is
+			from 32kHz to 125MHz, means the value range is 2~8000.
+			(details see DWC_usb3 databook register GCTL.PWRDNSCALE).
+

Sounds like the suspend_clk should be provided as a clock input so you can calculate this value.

Yes, I will go this approach by update dts with suspend_clk of dwc3

Thanks
Li Jun

Quoted 7 lines
Quoted 7 lines
Documentation/devicetree/bindings/usb/dwc3.txt +0 -1
  - in addition all properties from usb-xhci.txt from the current directory are
    supported as well
 
--

2.7.4