Skip to contentSkip to conversation

White-list pull-filter and script-security in interactive service

PATCH In review [email protected]... 2 participants 2 messages Jan 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 White-list pull-filter and script-security in interactive service

From: Selva Nair <[email protected]...>

This allows the Windows GUI to use these options on the command line without triggering user authorization errors.

Useful for
(i) ignoring certain pushed options such as "route-method" which could otherwise bypass the interactive service
(ii) enforcing a safer script-security setting from the GUI

See also:
https://github.com/OpenVPN/openvpn-gui/issues/235#issuecomment-456142928

---
 src/openvpnserv/validate.c | 2 ++
 1 file changed, 2 insertions(+)
src/openvpnserv/validate.c +2 -0
index 9e1d7d2..9b01770 100644
@@ -44,6 +44,8 @@ static const WCHAR *white_list[] =
     L"setenv",
     L"service",
     L"verb",
+    L"pull-filter",
+    L"script-security",
 
     NULL                                /* last value */
 };
Signature · 1 line
2.6.2
Acked-by on v1 1/1
#1 lore raw

"Because it makes sense and moves toward making OpenVPN on Windows more robust (pull-filter route-method) and secure (script-security)". Code change is simple enough :-)

Your patch has been applied to the master and release/2.4 branch (security enhancement).

commit 0d94d433438f239ff7cf0749f765a503c698f5e8 (master) commit b8190ecb33f8949f1b881c1cd240e8c1ea4fe144 (release/2.4)

Author: Selva Nair
Date:   Tue Jan 22 10:50:32 2019 -0500
     White-list pull-filter and script-security in interactive service

     Signed-off-by: Selva Nair <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg18154.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering