ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
PATCH 1/1 ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
From: Tien Fong Chee <[email protected]>
This is minimum memory pool size required to get SPL booting to U-Boot, such as FPGA program and loading U-Boot image from FAT.
--- include/configs/socfpga_common.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/socfpga_common.h +1 -1
@@ -258,7 +258,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);#if defined(CONFIG_TARGET_SOCFPGA_ARRIA10 )/* SPL memory allocation configuration, this is for FAT implementation */ #ifndef CONFIG_SYS_SPL_MALLOC_START -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00010000 +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00012000#define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_SYS_SPL_MALLOC_SIZE + \ CONFIG_SYS_INIT_RAM_ADDR)
Signature · 1 line
1.7.7.4
PATCH 1/1 ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
Quoted 4 lines · tien.fong.chee at intel.com
From: Tien Fong Chee <[email protected]>
This is minimum memory pool size required to get SPL booting to U-Boot, such as FPGA program and loading U-Boot image from FAT.
Rather, this is the minimal size needed for FAT to work ? But then , maybe you should just set the malloc area size a bit bigger to have some headroom available.
How did you come to the number 0x12000 ? Did you do some measurements ?
Quoted 19 lines
Signed-off-by Tien Fong Chee <[email protected]>--- include/configs/socfpga_common.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/configs/socfpga_common.h +1
-1@@ -258,7 +258,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);#if defined(CONFIG_TARGET_SOCFPGA_ARRIA10 )/* SPL memory allocation configuration, this is for FAT implementation */ #ifndef CONFIG_SYS_SPL_MALLOC_START -#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00010000 +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00012000#define CONFIG_SYS_SPL_MALLOC_START (CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_SYS_SPL_MALLOC_SIZE + \ CONFIG_SYS_INIT_RAM_ADDR)
Signature · 2 lines
Best regards, Marek Vasut
Chee
PATCH 1/1 ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL
Quoted 11 lines · Marek Vasut
Quoted 6 lines · tien.fong.chee at intel.com
From: Tien Fong Chee <[email protected]>
This is minimum memory pool size required to get SPL booting to U- Boot,
such as FPGA program and loading U-Boot image from FAT.Rather, this is the minimal size needed for FAT to work ? But then , maybe you should just set the malloc area size a bit bigger to have some
headroom available.
Yes, the is minimal size based on that series of FPGA program patches. How much you think we should increase?
Quoted 3 lines
How did you come to the number
0x12000? Did you do some measurements ?
Yup, after applying these patches:
1. https://www.mail-archive.com/u-boot at lists.denx.de/msg313259.html - Saving 84kIB max cluster block from excludng both fat write and EXT4 in SPL.
2. https://www.mail-archive.com/u-boot at lists.denx.de/msg312340.html Maximise reusable from memory pool, so the amount required for mmeory pool can be reduced to only (1 max cluster size[0x100000] + other than max cluster size[0x2000]), total is 0x12000.
Quoted 27 lines
Quoted 26 lines
Signed-off-by Tien Fong Chee <[email protected]>---
include/configs/socfpga_common.h | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)include/configs/socfpga_common.h +0
-0@@ -258,7 +258,7 @@ unsigned intcm_get_qspi_controller_clk_hz (void); #if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) /* SPL memory allocation configuration, this is for FATimplementation */
#ifndefCONFIG_SYS_SPL_MALLOC_STARTinclude/configs/socfpga_common.h +1
-1-#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00010000 +#define CONFIG_SYS_SPL_MALLOC_SIZE 0x00012000#define
CONFIG_SYS_SPL_MALLOC_START(CONFIG_SYS_INIT_RAM_SI
ZE - \
CONFIG_SYS_SPL_MALLOC_SIZ E + \
CONFIG_SYS_INIT_RAM_ADDR)