: net : hso : unregister_netdev only if it has been registered
Subsystems (2)
PATCH 1/1 : net : hso : unregister_netdev only if it has been registered
On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.
---
net/usb/hso.c renamed from net/usb/hso.c.orig +0 -0
@@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct h
remove_net_device(hso_net->parent);
- if (hso_net->net)
+ if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)
unregister_netdev(hso_net->net);
/* start freeing */
Quoted 11 lines · Tuba
On an error path inside the
hso_create_net_devicefunction of the hso driver,hso_free_net_devicegets called. This causes potentially a negative reference count in the net device ifregister_netdevhas not been called yet ashso_free_net_devicecallsunregister_netdevregardless. I think the driver should distinguish these cases and callunregister_netdevonly ifregister_netdevhas been called.Reported-by Tuba Yavuz <[email protected]>Signed-off-by Tuba Yavuz <[email protected]>
No need for a reported-by if you wrote the patch and sign off on it.
net/usb/hso.c
Quoted 5 lines
---
net/usb/hso.c renamed from net/usb/hso.c.orig +0
-0
Your patches need to be one more level deep. Please see the documentatino for how to do this, git should also create this automatically correctly for you.
thanks,
greg k-h