: [meta]: [recipes-bsp]: u-boot: update commit id to the latest one of u-boot upstream
From: Limeng <[email protected]>
Hi Richard,
Could you please help to merge this patch into meta/recipes-bsp/u-boot, branch is master?
There are 2 CVE issues fixing in latest u-boot upstream, so update commit id to involve these fixing patches.
thanks,
Limeng
PATCH 1/1 u-boot: update commit id to the latest one of u-boot upstream
From: MengLi <[email protected]>
There are 2 CVE issues fixing in latest u-boot upstream, so update commit id to involve these fixing patches.
--- meta/recipes-bsp/u-boot/u-boot-common.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/u-boot-common.inc +1 -1
@@ -8,7 +8,7 @@ PE = "1" # We use the revision in order to avoid having to fetch it from the # repo during parse -SRCREV = "0157013f4a4945bbdb70bb4d98d680e0845fd784" +SRCREV = "d01806a8fcbdaedcc67cead56ece572021d97ab7" SRC_URI = "git://git.denx.de/u-boot.git"
Signature · 1 line
2.7.4
Re: [yocto] [PATCH] u-boot: update commit id to the latest one of u-boot upstream
Quoted 2 lines · On Mon, 28 Jan 2019 at 11:20, <[email protected]> wrote:
There are 2 CVE issues fixing in latest u-boot upstream, so update commit id to involve these fixing patches.
We generally don't update commit id's to something random, as that means picking a source tree in the middle of a development cycle. If you want to update a component, please use a commit that has a version tag attached to it.
Also, the patch needs to go to oe-core mailing list.
Alex
Quoted 8 lines · On Mon, Jan 28, 2019 at 06:20:02PM +0800, [email protected] wrote:
From: Limeng <[email protected]>
Hi Richard,
Could you please help to merge this patch into meta/recipes-bsp/u-boot, branch is master?
There are 2 CVE issues fixing in latest u-boot upstream, so update commit id to involve these fixing patches.
With my U-Boot maintainer hat on, NAK. While there are two CVEs that have been addressed now (and present for a long while) I would say both:
- The issues themselves are not so catastrophic that you should move to a pre-release (I haven't even tagged v2019.04-rc1 yet!) to get them nor blindly back-port the changes. I intentionally didn't apply them to the last release as I expected unintended consequences. Surprise! There have been unintended consequences of those changes and I haven't pulled in the changes for that just yet.
- Even once the patches to address the CVEs are addressed, I don't see why you would move to "top of tree" rather than as is normal practice backport the changes. Simon's fix here is a clear series in patchwork (as well as git history) to apply as needed, if after evaluating the CVEs it's something that you feel should be addressed in this way and not with the workaround (telling U-Boot to load at most $X bytes).
Thanks!
Signature · 1 line
Tom