Skip to contentSkip to conversation

controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL

PATCH New Jason Xing 2 participants 4 messages Jan 29, 2019 – Jan 30, 2019

lore
Share & tools
lore

Jason Xing

author
#0 lore raw

PATCH 1/1 controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL

When doing cpuset_hotplug test, it will mount cpuset filesystem on /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus doesn't exist because the cgroup system generates cpus without 'cpuset' prefix instead. The result is undoubtly TFAIL.

The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c). The reason is that it wants the backwards compatibility for the old cpuset file system. Therefore, using "mount -t cgroup -o" method surely fixes this issue once for all.

---
 testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/cpuset/cpuset_funcs.sh +1 -1
index cc31729..935a41e 100755
@@ -128,7 +128,7 @@ setup()
 
 	mkdir -p "$CPUSET_TMP"
 	mkdir "$CPUSET"
-	mount -t cpuset cpuset "$CPUSET" 2> /dev/null
+	mount -t cgroup -o cpuset cpuset "$CPUSET" 2> /dev/null
 	if [ $? -ne 0 ]; then
 		cleanup
 		tst_brkm TFAIL "Could not mount cgroup filesystem with"\
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL

Quoted 10 lines · Jason Xing

When doing cpuset_hotplug test, it will mount cpuset filesystem on /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus doesn't exist because the cgroup system generates cpus without 'cpuset' prefix instead. The result is undoubtly TFAIL.

The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c). The reason is that it wants the backwards compatibility for the old cpuset file system. Therefore, using "mount -t cgroup -o" method surely fixes this issue once for all.

Hi Jason,

It looks good to me. :-)

Best Regards,
Xiao Yang

Quoted 18 lines
---
  testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/cpuset/cpuset_funcs.sh +1 -1
index cc31729..935a41e 100755
@@ -128,7 +128,7 @@ setup()
 
  	mkdir -p "$CPUSET_TMP"
  	mkdir "$CPUSET"
-	mount -t cpuset cpuset "$CPUSET" 2>  /dev/null
+	mount -t cgroup -o cpuset cpuset "$CPUSET" 2>  /dev/null
  	if [ $? -ne 0 ]; then
  		cleanup
  		tst_brkm TFAIL "Could not mount cgroup filesystem with"\
author
#2 lore raw

PATCH 1/1 controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL

Quoted 11 lines · Xiao Yang
Quoted 10 lines · Jason Xing

When doing cpuset_hotplug test, it will mount cpuset filesystem on /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus doesn't exist because the cgroup system generates cpus without 'cpuset' prefix instead. The result is undoubtly TFAIL.

The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c). The reason is that it wants the backwards compatibility for the old cpuset file system. Therefore, using "mount -t cgroup -o" method surely fixes this issue once for all.

Quoted 6 lines

Hi Jason,

It looks good to me. :-)

Best Regards,
Xiao Yang

Hi Yang,

Thanks for your review.

But it seems that the maintainers miss this patch, it's not a complicated one, just one line changed. So I decided to reply to you all.

Quoted 21 lines
Quoted 19 lines
---
  testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/cpuset/cpuset_funcs.sh +1 -1
index cc31729..935a41e 100755
@@ -128,7 +128,7 @@ setup()
 
      mkdir -p "$CPUSET_TMP"
      mkdir "$CPUSET"
-    mount -t cpuset cpuset "$CPUSET" 2>  /dev/null
+    mount -t cgroup -o cpuset cpuset "$CPUSET" 2>  /dev/null
      if [ $? -ne 0 ]; then
          cleanup
          tst_brkm TFAIL "Could not mount cgroup filesystem with"\
#3 lore raw

PATCH 1/1 controllers/cpuset: cpuset.cpus file doesn't exist which triggers TFAIL

Quoted 21 lines · Jason Xing
Quoted 12 lines · Xiao Yang
Quoted 11 lines · Jason Xing

When doing cpuset_hotplug test, it will mount cpuset filesystem on /dev/cpuset and try to 'cat' cpuset.cpus file. But the cpuset.cpus doesn't exist because the cgroup system generates cpus without 'cpuset' prefix instead. The result is undoubtly TFAIL.

The old ltp test uses "mount -t cpuset cpuset "$CPUSET"" which will mount with 'noprefix' options in the kernel(see kernel/cgroup/cpuset.c).
The reason is that it wants the backwards compatibility for the old cpuset file system. Therefore, using "mount -t cgroup -o" method surely fixes this issue once for all.

Quoted 6 lines

Hi Jason,

It looks good to me. :-)

Best Regards,
Xiao Yang

Quoted 6 lines

Hi Yang,

Thanks for your review.

But it seems that the maintainers miss this patch, it's not a complicated one, just one line changed. So I decided to reply to you all.

Hi Jason,

Pushed, thanks for your work.

Best Regards,
Xiao Yang

Quoted 26 lines
Quoted 13 lines
Quoted 13 lines
---
  testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/cpuset/cpuset_funcs.sh +0 -0
index cc31729..935a41e 100755
@@ -128,7 +128,7 @@ setup()
 
Quoted 9 lines

testcases/kernel/controllers/cpuset/cpuset_funcs.sh setup() · line 134

Quoted 7 lines
testcases/kernel/controllers/cpuset/cpuset_funcs.sh +1 -1
      mkdir -p "$CPUSET_TMP"
      mkdir "$CPUSET"
-    mount -t cpuset cpuset "$CPUSET" 2>  /dev/null
+    mount -t cgroup -o cpuset cpuset "$CPUSET" 2>  /dev/null
      if [ $? -ne 0 ]; then
          cleanup
          tst_brkm TFAIL "Could not mount cgroup filesystem with"\

.