misc: fs_loader: Add support for initializing block device
PATCH v3 1/1 misc: fs_loader: Add support for initializing block device
From: Tien Fong Chee <[email protected]>
Firmware loader would encounter problem if the block device is accessed before initializing it. This patch would adding the support of probing block device and initializing block before the block device is accessed by firmware loader.
---
Changes in v3:
- Initializing block device through probing the blk device
Changes in v2:
- Initializing MMC through probing the blk device
--- drivers/misc/fs_loader.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/misc/fs_loader.c +26 -0
@@ -12,6 +12,7 @@#include <linux/string.h> #include <mapmem.h> #include <malloc.h> +#include <mmc.h> #include <spl.h> DECLARE_GLOBAL_DATA_PTR ;
@@ -252,6 +253,31 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)static int fs_loader_probe (struct udevice *dev) { +#if CONFIG_IS_ENABLED (DM ) &&CONFIG_IS_ENABLED (BLK ) +int ret; +struct device_platdata *plat = dev->platdata; + +if (plat->phandlepart.phandle) { +ofnode node =ofnode_get_by_phandle (plat->phandlepart.phandle); + +struct udevice *parent_dev =NULL ; + + ret =device_get_global_by_ofnode (node, &parent_dev); + +if (!ret) { +struct udevice *dev; + + ret =blk_get_from_parent (parent_dev, &dev); +if (ret) { +debug ("fs_loader: No block device: %d\n" , + ret); + +return ret; + } + } + } +#endif +return 0 ; };
Signature · 1 line
2.2.0
PATCH v3 1/1 misc: fs_loader: Add support for initializing block device
Hi,
Quoted 12 lines · On Thu, 24 Jan 2019 at 03:24, <[email protected]> wrote:
From: Tien Fong Chee <[email protected]>
Firmware loader would encounter problem if the block device is accessed before initializing it. This patch would adding the support of probing block device and initializing block before the block device is accessed by firmware loader.
Signed-off-by Tien Fong Chee <[email protected]>---
Quoted 8 lines
Changes in v3:
- Initializing block device through probing the blk deviceChanges in v2:
- Initializing MMC through probing the blk device--- drivers/misc/fs_loader.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
Looks good, a few nits below.
Also at some point (separate patch) we really shoud have a test for UCLASS_FS_FIRMWARE_LOADER,.
drivers/misc/fs_loader.c line 15
Quoted 10 lines
drivers/misc/fs_loader.c +1
-0@@ -12,6 +12,7 @@#include <linux/string.h> #include <mapmem.h> #include <malloc.h> +#include <mmc.h>
Can you drop this now?
Quoted 4 lines
drivers/misc/fs_loader.c +0
-0#include <spl.h> DECLARE_GLOBAL_DATA_PTR ;
drivers/misc/fs_loader.c static int fs_loader_ofdata_to_platdata(struct udevice *dev) · line 262
Quoted 10 lines
drivers/misc/fs_loader.c +7
-0@@ -252,6 +253,31 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)static int fs_loader_probe (struct udevice *dev) { +#if CONFIG_IS_ENABLED (DM ) &&CONFIG_IS_ENABLED (BLK ) +int ret; +struct device_platdata *plat = dev->platdata; + +if (plat->phandlepart.phandle) { +ofnode node =ofnode_get_by_phandle (plat->phandlepart.phandle); +
drop extra blank line
drivers/misc/fs_loader.c static int fs_loader_ofdata_to_platdata(struct udevice *dev) · line 266
Quoted 4 lines
drivers/misc/fs_loader.c +4
-0+struct udevice *parent_dev =NULL ; + + ret =device_get_global_by_ofnode (node, &parent_dev); +
here too
Quoted 20 lines
drivers/misc/fs_loader.c +14
-1+if (!ret) { +struct udevice *dev; + + ret =blk_get_from_parent (parent_dev, &dev); +if (ret) { +debug ("fs_loader: No block device: %d\n" , + ret); + +return ret; + } + } + } +#endif +return 0 ; }; --2.2.0
Chee
PATCH v3 1/1 misc: fs_loader: Add support for initializing block device
Quoted 27 lines · Simon Glass
Hi,
Quoted 16 lines · On Thu, 24 Jan 2019 at 03:24, <[email protected]> wrote:
From: Tien Fong Chee <[email protected]>
Firmware loader would encounter problem if the block device is accessed
before initializing it. This patch would adding the support of probing
block device and initializing block before the block device is accessed by
firmware loader.Signed-off-by Tien Fong Chee <[email protected]>---
Quoted 8 lines
Changes in v3:
- Initializing block device through probing the blk deviceChanges in v2:
- Initializing MMC through probing the blk device
---
drivers/misc/fs_loader.c | 26 ++++++++++++++++++++++++++1 file changed, 26 insertions(+)
Quoted 4 lines
Looks good, a few nits below.
Also at some point (separate patch) we really shoud have a test for
UCLASS_FS_FIRMWARE_LOADER,.
Sure, i will do in later for separate patch. Need explore how to create a test for firmware loader and also DTS as software policy implementation.
Quoted 13 lines
drivers/misc/fs_loader.c line 15
Quoted 12 lines
drivers/misc/fs_loader.c +1
-0@@ -12,6 +12,7 @@ #include <linux/string.h> #include <mapmem.h> #include <malloc.h> +#include <mmc.h> Can you drop this now?
sure.
Quoted 16 lines
Quoted 16 lines
drivers/misc/fs_loader.c +6
-0#include <spl.h> DECLARE_GLOBAL_DATA_PTR;@@ -252,6 +253,31 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev) static int fs_loader_probe(struct udevice *dev) { +#if CONFIG_IS_ENABLED (DM ) &&CONFIG_IS_ENABLED (BLK ) + int ret; + struct device_platdata *plat = dev->platdata; + + if (plat->phandlepart.phandle) { + ofnode node = ofnode_get_by_phandle(plat-
Quoted 3 lines
drivers/misc/fs_loader.c static int fs_loader_ofdata_to_platdata(struct · line 264
Quoted 2 lines
drivers/misc/fs_loader.c +1
-0>phandlepart.phandle); +drop extra blank line
sure.
Quoted 8 lines
drivers/misc/fs_loader.c static int fs_loader_ofdata_to_platdata(struct udevice *dev) · line 266
Quoted 7 lines
drivers/misc/fs_loader.c +4
-0+ struct udevice *parent_dev = NULL; + + ret = device_get_global_by_ofnode(node, &parent_dev); +here too
sure.
Quoted 25 lines
Quoted 25 lines
drivers/misc/fs_loader.c +4
-0+ if (!ret) { + struct udevice *dev; + + ret = blk_get_from_parent(parent_dev,&dev);
+ if (ret) {
+ debug("fs_loader: No block device:
%d\n",
+ ret);drivers/misc/fs_loader.c +7
-0+ + return ret; + } + } + } +#endif +return 0;
};--
2.2.0