Skip to contentSkip to conversation

ima: remove CREDS_CHECK fall through

PATCH In review Mimi Zohar 3 participants 3 messages Jan 31, 2019

Subsystems (3)
lore
Share & tools
lore

Mimi Zohar

author maintainer
#0 lore raw

PATCH 1/1 ima: remove CREDS_CHECK fall through

This patch fixes the CREDS_CHECK fall through as annotated in the
"security mark expected switch fall-throughs" patch.

Cc Gustavo A. R. Silva <[email protected]>
Cc Matthew Garrett <[email protected]>
---
 security/integrity/ima/ima_appraise.c | 1 +
 1 file changed, 1 insertion(+)
security/integrity/ima/ima_appraise.c +1 -0
index a2baa85ea2f5..5fb7127bbe68 100644
@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,
 		break;
 	case CREDS_CHECK:
 		iint->ima_creds_status = status;
+		break;
 	case FILE_CHECK:
 	case POST_SETATTR:
 		iint->ima_file_status = status;
Signature · 1 line
2.7.5
Acked-by on v1 1/1
#1 lore raw

Great!

Thanks for reviewing this, Mimi.

Quoted 6 lines · Mimi Zohar

This patch fixes the CREDS_CHECK fall through as annotated in the
"security mark expected switch fall-throughs" patch.

Cc Gustavo A. R. Silva <[email protected]>
Cc Matthew Garrett <[email protected]>
Quoted 17 lines
---
 security/integrity/ima/ima_appraise.c | 1 +
 1 file changed, 1 insertion(+)
security/integrity/ima/ima_appraise.c +1 -0
index a2baa85ea2f5..5fb7127bbe68 100644
@@ -114,6 +114,7 @@ static void ima_set_cache_status(struct integrity_iint_cache *iint,
 		break;
 	case CREDS_CHECK:
 		iint->ima_creds_status = status;
+		break;
 	case FILE_CHECK:
 	case POST_SETATTR:
 		iint->ima_file_status = status;