Skip to contentSkip to conversation

make-syscalls.sh: fix comment referencing syscall-template

PATCH New Vineet Gupta 2 participants 4 messages Feb 1, 2019 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make-syscalls.sh: fix comment referencing syscall-template

spotted when started working on ARC port to glibc

---
 ChangeLog                     | 5 +++++
 sysdeps/unix/make-syscalls.sh | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
ChangeLog +5 -0
index 93201b76a26b..8438f93e13a2 100644
@@ -1,3 +1,8 @@
+2019-01-31  Vineet Gupta <vgupta at synopsys.com>
+
+	* sysdeps/unix/make-syscalls.sh: Fix comment referencing
+	syscall-template file.
+
 2019-01-31  Paul Pluzhnikov  <ppluzhnikov at google.com>
 
 	[BZ #24051]
sysdeps/unix/make-syscalls.sh +1 -1
index e39b2d6d5214..6a5c10d54e87 100644
@@ -7,7 +7,7 @@
 #
 # This script is used to process the syscall data encoded in the various
 # syscalls.list files to produce thin assembly syscall wrappers around the
-# appropriate OS syscall. See syscall-template.s for more details on the
+# appropriate OS syscall. See syscall-template.S for more details on the
 # actual wrapper.
 #
 # Syscall Signature Prefixes:
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 make-syscalls.sh: fix comment referencing syscall-template

Quoted 7 lines · Vineet Gupta

spotted when started working on ARC port to glibc

---
 ChangeLog                     | 5 +++++
 sysdeps/unix/make-syscalls.sh | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Obviously correct :-)

Please commit to master which is open for development.

Reviewed-by Carlos O'Donell <carlos at redhat.com>
Quoted 27 lines
ChangeLog +5 -0
index 93201b76a26b..8438f93e13a2 100644
@@ -1,3 +1,8 @@
+2019-01-31  Vineet Gupta <vgupta at synopsys.com>
+
+	* sysdeps/unix/make-syscalls.sh: Fix comment referencing
+	syscall-template file.
+
 2019-01-31  Paul Pluzhnikov  <ppluzhnikov at google.com>
 
 	[BZ #24051]
sysdeps/unix/make-syscalls.sh +1 -1
index e39b2d6d5214..6a5c10d54e87 100644
@@ -7,7 +7,7 @@
 #
 # This script is used to process the syscall data encoded in the various
 # syscalls.list files to produce thin assembly syscall wrappers around the
-# appropriate OS syscall. See syscall-template.s for more details on the
+# appropriate OS syscall. See syscall-template.S for more details on the
 # actual wrapper.
 #
 # Syscall Signature Prefixes:
Signature · 2 lines
Cheers,
Carlos.
#2 lore raw

PATCH 1/1 make-syscalls.sh: fix comment referencing syscall-template

Quoted 9 lines · Carlos O'Donell
Quoted 7 lines · Vineet Gupta

spotted when started working on ARC port to glibc

---
 ChangeLog                     | 5 +++++
 sysdeps/unix/make-syscalls.sh | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Obviously correct :-)

Changelog is bigger than the fix ;-)

Quoted 3 lines

Please commit to master which is open for development.

Reviewed-by Carlos O'Donell <carlos at redhat.com>

I'm not sure if I have access credentials to commit to *the* glibc repo ?

#3 lore raw

PATCH 1/1 make-syscalls.sh: fix comment referencing syscall-template

Quoted 11 lines · Vineet Gupta
Quoted 9 lines · Carlos O'Donell
Quoted 7 lines · Vineet Gupta

spotted when started working on ARC port to glibc

---
 ChangeLog                     | 5 +++++
 sysdeps/unix/make-syscalls.sh | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Obviously correct :-)

Quoted 9 lines

Changelog is bigger than the fix ;-)

Quoted 3 lines

Please commit to master which is open for development.

Reviewed-by Carlos O'Donell <carlos at redhat.com>

I'm not sure if I have access credentials to commit to *the* glibc repo ?

Pushed. Thank you :-)

commit d5627550ae99d10dfad216910ffa774f60460123 (HEAD -> master, origin/master, origin/HEAD)

Author: Vineet Gupta <vgupta at synopsys.com>
Date:   Thu Jan 31 22:45:10 2019 -0500

make-syscalls.sh: fix comment referencing syscall-template

Signature · 2 lines
Cheers,
Carlos.