Skip to contentSkip to conversation

ath10k: Add a condtion to fill the LDPC capability correctly

PATCH In review Surabhi Vishnoi 2 participants 5 messages Feb 1, 2019 – Feb 7, 2019 1 message not in the archive Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: Add a condtion to fill the LDPC capability correctly

The firmware advertises the LDPC support information for HT in HT capability info in the wmi service ready event. To provide granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT capabilities.

Add a condition to existing logic in host to know whether firmware supports LDPC or not.

Tested HW: WCN3990
Tested SW: WLAN.HL.2.0

---
 drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
 drivers/net/wireless/ath/ath10k/wmi.h | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/mac.c +2 -1
index e49b367..1645b1e 100644
@@ -4549,7 +4549,8 @@ static struct ieee80211_sta_ht_cap ath10k_get_ht_cap(struct ath10k *ar)
 		ht_cap.cap |= stbc;
 	}
 
-	if (ar->ht_cap_info & WMI_HT_CAP_LDPC)
+	if (ar->ht_cap_info & WMI_HT_CAP_LDPC || (ar->ht_cap_info &
+	    WMI_HT_CAP_RX_LDPC && (ar->ht_cap_info & WMI_HT_CAP_TX_LDPC)))
 		ht_cap.cap |= IEEE80211_HT_CAP_LDPC_CODING;
 
 	if (ar->ht_cap_info & WMI_HT_CAP_L_SIG_TXOP_PROT)
drivers/net/wireless/ath/ath10k/wmi.h +2 -0
index 427ca79..0aca84e 100644
@@ -2076,6 +2076,8 @@ enum wmi_channel_change_cause {
 #define WMI_HT_CAP_MPDU_DENSITY           0x0700   /* MPDU Density */
 #define WMI_HT_CAP_MPDU_DENSITY_MASK_SHIFT 8
 #define WMI_HT_CAP_HT40_SGI               0x0800
+#define WMI_HT_CAP_RX_LDPC                0x1000   /* LDPC RX support */
+#define WMI_HT_CAP_TX_LDPC                0x2000   /* LDPC TX support */
 
 #define WMI_HT_CAP_DEFAULT_ALL (WMI_HT_CAP_ENABLED       | \
 				WMI_HT_CAP_HT20_SGI      | \
Signature · 7 lines
1.9.1


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 7 lines · Surabhi Vishnoi

The firmware advertises the LDPC support information for HT in HT capability info in the wmi service ready event. To provide granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT capabilities.

Quoted 5 lines

Add a condition to existing logic in host to know whether firmware supports LDPC or not.

Tested HW: WCN3990
Tested SW: WLAN.HL.2.0

Can you give exact firmware version you tested, please? I'll add it to the commit log.

I'll also fix the typo "condtion" in the title.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

+ lists

Quoted 19 lines · Surabhi Vishnoi
Quoted 18 lines · Kalle Valo
Quoted 7 lines · Surabhi Vishnoi

The firmware advertises the LDPC support information for HT in HT capability info in the wmi service ready event. To provide granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT capabilities.

Quoted 5 lines

Add a condition to existing logic in host to know whether firmware supports LDPC or not.

Tested HW: WCN3990
Tested SW: WLAN.HL.2.0

Can you give exact firmware version you tested, please? I'll add it to the commit log.

Quoted 8 lines
Quoted 1 line

I'll also fix the typo "condtion" in the title.

Hi Kalle,

The Fw version tested are:
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,
WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1

Thanks. But please do not drop the lists, otherwise patchwork won't see this.

Signature · 1 line
Kalle Valo
#4 lore raw
In reply to Surabhi Vishnoi
Quoted 10 lines · Surabhi Vishnoi

The firmware advertises the LDPC support information for HT in HT capability info in the wmi service ready event. To provide granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT capabilities.

Add a condition to existing logic in host to know whether firmware supports LDPC or not.

Quoted 6 lines

Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,

           WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1

Patch applied to ath-next branch of ath.git, thanks.

ff488d0ef1c2 ath10k: add a condition to fill the LDPC capability correctly

Signature · 9 lines
https://patchwork.kernel.org/patch/10791807/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#5 lore raw
In reply to Surabhi Vishnoi
Quoted 10 lines · Surabhi Vishnoi

The firmware advertises the LDPC support information for HT in HT capability info in the wmi service ready event. To provide granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should also check for WMI_HT_CAP_RX_LDPC and WMI_HT_CAP_TX_LDPC in HT capabilities.

Add a condition to existing logic in host to know whether firmware supports LDPC or not.

Quoted 6 lines

Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1,

           WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1

Patch applied to ath-next branch of ath.git, thanks.

ff488d0ef1c2 ath10k: add a condition to fill the LDPC capability correctly

Signature · 3 lines
https://patchwork.kernel.org/patch/10791807/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches