don't force _init/_fini as DT_INIT/DT_FINI
PATCH 1/1 don't force _init/_fini as DT_INIT/DT_FINI
Recent gcc commit b4371b277f1e ("[ARC] Enable init_array support") inhibits DT_"INIT,FINI} in favor of DT_{INIT,FINI}ARRAY.
Even prior to that, it seems ARC port is the only one with this special DT_INIT/FINI handling in linker emulation. Removing it doesn't seem to change any uClibc/glibc testsuite results, so this can RIP anyways.
bfd/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>
* elf32-arc.c: Delete init_str, fini_str
ld/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>
* emultempl/arclinux.em : Delete special INIT/FINI handling.
--- bfd/ChangeLog | 4 ++++ bfd/elf32-arc.c | 9 --------- ld/ChangeLog | 4 ++++ ld/emultempl/arclinux.em | 27 --------------------------- 4 files changed, 8 insertions(+), 36 deletions(-)
bfd/ChangeLog +4 -0
@@ -1,3 +1,7 @@ +2019-02-01 Vineet Gupta <vgupta at synopsys.com> + + * elf32-arc.c: Delete init_str, fini_str. + 2019-01-21 Sergio Durigan Junior <sergiodj at redhat.com> * elf32-arm.c (elf32_arm_final_link_relocate): Use 'llabs' instead
bfd/elf32-arc.c +0 -9
@@ -72,15 +72,6 @@ name_for_global_symbol (struct elf_link_hash_entry *h) } -/* The default symbols representing the init and fini dyn values. -TODO: Check what is the relation of those strings with arclinux.em -and DT_INIT. */ -#define INIT_SYM_STRING "_init" -#define FINI_SYM_STRING "_fini" - -char * init_str =INIT_SYM_STRING ; -char * fini_str =FINI_SYM_STRING ; -#define ARC_RELOC_HOWTO (TYPE ,VALUE ,SIZE ,BITSIZE ,RELOC_FUNCTION ,OVERFLOW ,FORMULA ) \ case VALUE: \ return "R_" #TYPE; \
ld/ChangeLog +4 -0
@@ -1,3 +1,7 @@ +2019-02-01 Vineet Gupta <vgupta at synopsys.com> + + * emultempl/arclinux.em : Delete special INIT/FINI handling. + 2019-01-31 Alan Modra <amodra at gmail.com> * NEWS: Mention -t change.
ld/emultempl/arclinux.em +0 -27
@@ -23,30 +23,3 @@ # This file is sourced from elf32.em, and defines extra arc-linux # specific routines. # -cat >>e${EMULATION_NAME}.c <<EOF -extern char * init_str; -extern char * fini_str; -EOF - -PARSE_AND_LIST_PROLOGUE=' -#define OPTION_INIT 300+1 -#define OPTION_FINI (OPTION_INIT+1) -' -PARSE_AND_LIST_LONGOPTS=' - /* PE options */ - { "init", required_argument, NULL, OPTION_INIT }, - { "fini", required_argument, NULL, OPTION_FINI }, -' - -# FIXME: Should set PARSE_AND_LIST_OPTIONS to provide a short description -# of the options. - -PARSE_AND_LIST_ARGS_CASES=' - case OPTION_FINI: - fini_str = optarg; - break; - - case OPTION_INIT: - init_str = optarg; - break; -'
Signature · 1 line
2.7.4
PATCH 1/1 don't force _init/_fini as DT_INIT/DT_FINI
Hi,
Quoted 11 lines
bfd/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>*
elf32-arc.c: Deleteinit_str,fini_strld/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>* emultempl/arclinux.em : Delete special INIT/FINI handling.
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
It looks good. I will push it asap. Thank you for your contribution, Claudiu
PATCH 1/1 don't force _init/_fini as DT_INIT/DT_FINI
Hi,
Quoted 10 lines · Claudiu Zissulescu
Hi,
Quoted 8 lines
bfd/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>*
elf32-arc.c: Deleteinit_str,fini_strld/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>
Quoted 6 lines
Quoted 3 lines
* emultempl/arclinux.em : Delete special INIT/FINI handling.
Signed-off-by Vineet Gupta <vgupta at synopsys.com>It looks good. I will push it asap. Thank you for your contribution, Claudiu
Can this be backported to stable branches please !
Thx,
-Vineet
PATCH 1/1 don't force _init/_fini as DT_INIT/DT_FINI
In reply to Claudiu ZissulescuHi Claudiu,
Quoted 10 lines · Claudiu Zissulescu
Hi,
Quoted 8 lines
bfd/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>*
elf32-arc.c: Deleteinit_str,fini_strld/
2019-02-01 Vineet Gupta <vgupta at synopsys.com>
Quoted 6 lines
Quoted 3 lines
* emultempl/arclinux.em : Delete special INIT/FINI handling.
Signed-off-by Vineet Gupta <vgupta at synopsys.com>It looks good. I will push it asap. Thank you for your contribution, Claudiu
Can this be stable backported please.
Thx,
-Vineet