patch "tools: iio: iio_generic_buffer: make num_loops signed" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
tools: iio: iio_generic_buffer: make num_loops signed
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From b119d3bc328e7a9574861ebe0c2110e2776c2de1 Mon Sep 17 00:00:00 2001
From: Martin Kelly <[email protected]>
Date: Fri, 11 Jan 2019 23:13:09 +0000
Subject: tools: iio: iio_generic_buffer: make num_loops signed
Currently, num_loops is unsigned, but it's set by strtoll, which returns a (signed) long long int. This could lead to overflow, and it also makes the check "num_loops < 0" always be false, since num_loops is unsigned. Setting num_loops to -1 to loop forever is almost working because num_loops is getting set to a very high number, but it's technically still incorrect.
Fix this issue by making num_loops signed. This also fixes an error found by Smatch.
--- tools/iio/iio_generic_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/iio/iio_generic_buffer.c +1 -1
@@ -330,7 +330,7 @@ static const struct option longopts[] = {int main (int argc,char **argv) { -unsigned long long num_loops =2 ; +long long num_loops =2 ;unsigned long timedelay =1000000 ;unsigned long buf_len =128 ;
Signature · 1 line
2.20.1