tests/docker/test-mingw and docs: Remove --with-sdlabi=2.0
PATCH 1/1 tests/docker/test-mingw and docs: Remove --with-sdlabi=2.0
Patchew currently reports failures with the mingw docker test - this is due to --with-sdlabi=2.0 configure flag which does not exist anymore. Remove this remainder from the docker test and the docs now.
--- docs/multiseat.txt | 2 +- tests/docker/test-mingw | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
docs/multiseat.txt +1 -1
@@ -9,7 +9,7 @@ First you must compile qemu with a user interface supporting multihead/multiseat and input event routing. Right now this list includes sdl2, gtk (both 2+3) and vnc: - ./configure --enable-sdl --with-sdlabi=2.0 + ./configure --enable-sdl or
tests/docker/test-mingw +1 -2
@@ -27,8 +27,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do --enable-curl \ --enable-vnc \ --enable-bzip2 \ - --enable-guest-agent \ - --with-sdlabi=2.0 + --enable-guest-agent install_qemu make clean
Signature · 1 line
1.8.3.1
Quoted 9 lines · Thomas Huth
Patchew currently reports failures with the mingw docker test - this is due to --with-sdlabi=2.0 configure flag which does not exist anymore. Remove this remainder from the docker test and the docs now.
Signed-off-by Thomas Huth <[email protected]>--- docs/multiseat.txt | 2 +- tests/docker/test-mingw | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Hi Alex,
Quoted 5 lines · Daniel P. Berrangé
Quoted 4 lines · Thomas Huth
Patchew currently reports failures with the mingw docker test - this is due to --with-sdlabi=2.0 configure flag which does not exist anymore. Remove this remainder from the docker test and the docs now.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Thomas Huth <[email protected]>--- docs/multiseat.txt | 2 +- tests/docker/test-mingw | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)Reviewed-by Daniel P. Berrangé <[email protected]>
IMHO this patch can probably get directly applied as a build-fix, rather than going thru qemu-trivial. Alex is that OK with you?
Regards,
Phil.
Quoted 5 lines · Thomas Huth
Patchew currently reports failures with the mingw docker test - this is due to --with-sdlabi=2.0 configure flag which does not exist anymore. Remove this remainder from the docker test and the docs now.
Signed-off-by Thomas Huth <[email protected]>
I'm happy for this to be applied directly by Peter.
Quoted 23 lines
--- docs/multiseat.txt | 2 +- tests/docker/test-mingw | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)docs/multiseat.txt +1
-1@@ -9,7 +9,7 @@ First you must compile qemu with a user interface supporting multihead/multiseat and input event routing. Right now this list includes sdl2, gtk (both 2+3) and vnc: - ./configure --enable-sdl --with-sdlabi=2.0 + ./configure --enable-sdl ortests/docker/test-mingw +0
-0
tests/docker/test-mingw for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do · line 32
Quoted 8 lines
tests/docker/test-mingw +1
-2@@ -27,8 +27,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do --enable-curl \ --enable-vnc \ --enable-bzip2 \ - --enable-guest-agent \ - --with-sdlabi=2.0 + --enable-guest-agent install_qemu make clean
--
Alex Bennée
Quoted 8 lines · Alex Bennée
Quoted 4 lines · Thomas Huth
Patchew currently reports failures with the mingw docker test - this is due to --with-sdlabi=2.0 configure flag which does not exist anymore. Remove this remainder from the docker test and the docs now.
Quoted 5 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>Acked-by Alex Bennée <[email protected]>I'm happy for this to be applied directly by Peter.
Applied to master as a buildfix, thanks.
-- PMM