Skip to contentSkip to conversation

arc: hsdk_defconfig: permit kernelci jobs

PATCH Superseded Corentin Labbe 5 participants 7 messages Feb 5, 2019 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

cover arc: hsdk_defconfig: permit kernelci jobs

Hello

In our kernelci lab, we have one hsdk device and since it is the only ARC device at our disposal, it is important to made it availlable for kernelci boot jobs.

Since kernelci build only defconfig without hacking it, it is important that defconfig are bootable by default.
And so for hsdk_defconfig, it miss two CONFIGs for let hsdk boot.

Thanks
Regards

Corentin Labbe (2):
arc: hsdk_defconfig: Enable CONFIG_BLK_DEV_RAM
arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

 arch/arc/configs/hsdk_defconfig | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.19.2
#1 lore raw

PATCH 1/2 arc: hsdk_defconfig: Enable CONFIG_BLK_DEV_RAM

We have now a HSDK device in our kernelci lab, but kernel builded via the hsdk_defconfig lacks ramfs supports, so it cannot boot kernelci jobs yet.

So this patch enable CONFIG_BLK_DEV_RAM in hsdk_defconfig.

Signed-off-by Corentin Labbe <clabbe at baylibre.com>
---
 arch/arc/configs/hsdk_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arc/configs/hsdk_defconfig +1 -0
index 6fd3d29546af..0e5fd29ed238 100644
@@ -8,6 +8,7 @@ CONFIG_NAMESPACES=y
 # CONFIG_UTS_NS is not set
 # CONFIG_PID_NS is not set
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BLK_DEV_RAM=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_VM_EVENT_COUNTERS is not set
Signature · 1 line
2.19.2
#2 lore raw

PATCH 2/2 arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

In reply to Corentin Labbe

We have now a HSDK device in our kernelci lab, but kernel builded via the hsdk_defconfig ignore bootargs, so it cannot boot kernelci jobs yet. Furthermore, I think the probability is that devices will be booted more via uboot than by a debugger.

So this patch enable CONFIG_ARC_UBOOT_SUPPORT in hsdk_defconfig.

Signed-off-by Corentin Labbe <clabbe at baylibre.com>
---
 arch/arc/configs/hsdk_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arc/configs/hsdk_defconfig +1 -0
index 0e5fd29ed238..b80e3ac5c93c 100644
@@ -9,6 +9,7 @@ CONFIG_NAMESPACES=y
 # CONFIG_PID_NS is not set
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_BLK_DEV_RAM=y
+CONFIG_ARC_UBOOT_SUPPORT=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_VM_EVENT_COUNTERS is not set
Signature · 1 line
2.19.2
#3 lore raw

Re: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

Hi Corentin,

In case of devboards (like HSDK) we really often disable bootloader and load Linux image in memory via JTAG. Enabling CONFIG_ARC_UBOOT_SUPPORT by default will break it as we will try to interpret some junk in a registers as a pointers to bootargs/etc which aren't set by anyone in case of JTAG using.

So it isn't a good idea to have CONFIG_ARC_UBOOT_SUPPORT enabled by default.

Quoted 24 lines · Corentin Labbe

We have now a HSDK device in our kernelci lab, but kernel builded via the hsdk_defconfig ignore bootargs, so it cannot boot kernelci jobs yet. Furthermore, I think the probability is that devices will be booted more via uboot than by a debugger.

So this patch enable CONFIG_ARC_UBOOT_SUPPORT in hsdk_defconfig.

Signed-off-by Corentin Labbe <clabbe at baylibre.com>
---
 arch/arc/configs/hsdk_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arc/configs/hsdk_defconfig +1 -0
index 0e5fd29ed238..b80e3ac5c93c 100644
@@ -9,6 +9,7 @@ CONFIG_NAMESPACES=y
 # CONFIG_PID_NS is not set
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_BLK_DEV_RAM=y
+CONFIG_ARC_UBOOT_SUPPORT=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_VM_EVENT_COUNTERS is not set
Signature · 1 line
 Eugeniy Paltsev
#4 lore raw

Re: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

Quoted 8 lines · Eugeniy Paltsev

Hi Corentin,

In case of devboards (like HSDK) we really often disable bootloader and load Linux image in memory via JTAG. Enabling CONFIG_ARC_UBOOT_SUPPORT by default will break it as we will try to interpret some junk in a registers as a pointers to bootargs/etc which aren't set by anyone in case of JTAG using.

So it isn't a good idea to have CONFIG_ARC_UBOOT_SUPPORT enabled by default.

Right.

It is difficult to accommodate everyone's needs (often conflicting) in a single defconfig.
Can you folks create an out-of-tree defconfig or some such.

-Vineet

#5 lore raw

RE: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

Hi Vineet, Corentin,

Quoted 16 lines

-----Original Message-----
From: Vineet Gupta <vgupta at synopsys.com>
Sent: Tuesday, February 5, 2019 7:42 PM
To: Eugeniy Paltsev <paltsev at synopsys.com>; clabbe at baylibre.com
Cc: linux-kernel at vger.kernel.org; alexey.brodkin at synopsys.com; khilman at baylibre.com; linux-snps- arc at lists.infradead.org
Subject: Re: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

Quoted 7 lines · Eugeniy Paltsev

Hi Corentin,

In case of devboards (like HSDK) we really often disable bootloader and load Linux image in memory via JTAG. Enabling CONFIG_ARC_UBOOT_SUPPORT by default will break it as we will try to interpret some junk in a registers as a pointers to bootargs/etc which aren't set by anyone in case of JTAG using.

Quoted 7 lines
Quoted 1 line

So it isn't a good idea to have CONFIG_ARC_UBOOT_SUPPORT enabled by default.

Right.

It is difficult to accommodate everyone's needs (often conflicting) in a single defconfig.
Can you folks create an out-of-tree defconfig or some such.

I do think there's a proper solution which [hopefully] makes both parties happy. Eugeniy is about to send-out a patch which allows us to not care about garbage in R0/R2 when running after U-Boot.

-Alexey

#6 lore raw

RE: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

Quoted 22 lines · Alexey Brodkin

Hi Vineet, Corentin,

Quoted 20 lines

-----Original Message-----
From: Vineet Gupta <vgupta at synopsys.com>
Sent: Tuesday, February 5, 2019 7:42 PM
To: Eugeniy Paltsev <paltsev at synopsys.com>; clabbe at baylibre.com
Cc: linux-kernel at vger.kernel.org; alexey.brodkin at synopsys.com; khilman at baylibre.com; linux-snps- arc at lists.infradead.org
Subject: Re: [PATCH 2/2] arc: hsdk_defconfig: enable CONFIG_ARC_UBOOT_SUPPORT

Quoted 8 lines · Eugeniy Paltsev

Hi Corentin,

In case of devboards (like HSDK) we really often disable bootloader and load Linux image in memory via JTAG. Enabling CONFIG_ARC_UBOOT_SUPPORT by default will break it as we will try to interpret some junk in a registers as a pointers to bootargs/etc which aren't set by anyone in case of JTAG using.

So it isn't a good idea to have CONFIG_ARC_UBOOT_SUPPORT enabled by default.

Right.

Quoted 7 lines
Quoted 3 lines

It is difficult to accommodate everyone's needs (often conflicting) in a single defconfig.
Can you folks create an out-of-tree defconfig or some such.

I do think there's a proper solution which [hopefully] makes both parties happy. Eugeniy is about to send-out a patch which allows us to not care about garbage in R0/R2 when running after U-Boot.

OK, cool, that sounds like a good workaround for the JTAG use case.

Just curious: what is the more common case for end-users? u-boot or JTAG?

At least on every other arch/board we use in kernelCI, u-boot is the *much* more common load path than JTAG. IMO, I would suggest that in the case of unresolvable conflicts like, u-boot should be the normal path, and JTAG would be the special case.

Anyways, hopefully the patch from Eugeniy works and gets rid of the conflict.

Related: if you end up accepting this series, they'll also need to be backported to stable branches if we want to support them in kernelCI.

Kevin