ARCv2: support manual regfile save on interrupts
PATCH 1/1 ARCv2: support manual regfile save on interrupts
There's a hardware bug which affects the HSDK platform, triggered by micro-ops for auto-saving regfile on taken interrupt. The workaround is to inhibit autosave.
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
--- arch/arc/Kconfig | 8 ++++++ arch/arc/include/asm/entry-arcv2.h | 54 ++++++++++++++++++++++++++++++++++++++ arch/arc/kernel/entry-arcv2.S | 4 ++- arch/arc/kernel/intc-arcv2.c | 2 ++ arch/arc/plat-hsdk/Kconfig | 1 + 5 files changed, 68 insertions(+), 1 deletion(-)
arch/arc/Kconfig +8 -0
@@ -407,6 +407,14 @@ config ARC_HAS_ACCL_REGS (also referred to as r58:r59). These can also be used by gcc as GPR so kernel needs to save/restore per process +config ARC_IRQ_NO_AUTOSAVE + bool "Disable hardware autosave regfile on interrupts" + default n + help + On HS cores, taken interrupt auto saves the regfile on stack. + This is programmable and can be optionally disabled in which case + software INTERRUPT_PROLOGUE/EPILGUE do the needed work + endif # ISA_ARCV2 endmenu # "ARC CPU Configuration"
arch/arc/include/asm/entry-arcv2.h +54 -0
66 lines not on this page · raw message
arch/arc/kernel/entry-arcv2.S +3 -1
@@ -209,7 +209,9 @@ restore_regs: ;####### Return from Intr ####### debug_marker_l1: - bbit1.nt r0, STATUS_DE_BIT, .Lintr_ret_to_delay_slot + ; bbit1.nt r0, STATUS_DE_BIT, .Lintr_ret_to_delay_slot + btst r0, STATUS_DE_BIT ; Z flag set if bit clear + bnz .Lintr_ret_to_delay_slot ; branch if STATUS_DE_BIT set .Lisr_ret_fast_path: ; Handle special case #1: (Entry via Exception, Return via IRQ)
arch/arc/kernel/intc-arcv2.c +2 -0
@@ -49,11 +49,13 @@ void arc_init_IRQ(void) *(unsigned int *)&ictrl =0 ; +#ifndef CONFIG_ARC_IRQ_NO_AUTOSAVE ictrl.save_nr_gpr_pairs =6 ;/* r0 to r11 (r12 saved manually) */ ictrl.save_blink =1 ; ictrl.save_lp_regs =1 ;/* LP_COUNT, LP_START, LP_END */ ictrl.save_u_to_u =0 ;/* user ctxt saved on kernel stack */ ictrl.save_idx_regs =1 ;/* JLI, LDI, EI */ +#endif WRITE_AUX (AUX_IRQ_CTRL , ictrl);
arch/arc/plat-hsdk/Kconfig +1 -0
@@ -9,6 +9,7 @@ menuconfig ARC_SOC_HSDK bool "ARC HS Development Kit SOC" depends on ISA_ARCV2 select ARC_HAS_ACCL_REGS + select ARC_IRQ_NO_AUTOSAVE select CLK_HSDK select RESET_HSDK select HAVE_PCI
Signature · 1 line
2.7.4