selftests/resctrl: Add resctrl selftest
Subsystems (2)
v6 cover selftests/resctrl: Add resctrl selftest
With more and more resctrl features are being added by Intel, AMD and ARM, a test tool is becoming more and more useful to validate that both hardware and software functionalities work as expected.
We introduce resctrl selftest to cover resctrl features on both X86 and ARM architectures. It first implements MBM (Memory Bandwidth Monitoring), MBA (Memory Bandwidth Allocation), L3 CAT (Cache Allocation Technology), and CQM (Cache QoS Monitoring) tests. We can enhance the selftest tool to include more functionality tests in future.
The tool has been tested on both Intel RDT and AMD QoS.
There is an existing resctrl test suite 'intel_cmt_cat'. But the major purpose of the tool is to test Intel(R) RDT hardware via writing and reading MSR registers. It does access resctrl file system; but the functionalities are very limited. And it doesn't support automatic test and a lot of manual verifications are involved.
So the selftest tool we are introducing here provides a convenient tool which does automatic resctrl testing, is easily available in kernel tree, and will be extended to AMD QoS and ARM MPAM.
The selftest tool is in tools/testing/selftests/resctrl in order to have generic test code for all architectures.
Changelog:
v6:
- Fix a benchmark reading optimized out issue in newer GCC.
- Fix a few coding style issues.
- Re-arrange code among patches to make cleaner code. No change in patches structure.
v5:
- Based the v4 patches submitted by Fenghua Yu and added changes to support AMD.
- Changed the function name get_sock_num to get_resource_id. Intel uses socket number for schemata and AMD uses l3 index id. To generalize, changed the function name to get_resource_id.
- Added the code to detect vendor.
- Disabled the few tests for AMD where the test results are not clear. Also AMD does not have IMC.
- Fixed few compile issues.
- Some cleanup to make each patch independent.
- Tested the patches on AMD system. Fenghua, Need your help to test on Intel box. Please feel free to change and resubmit if something broken.
- Here is the link for previous version.
https://lore.kernel.org/lkml/1545438038-75107-1-git-send-email-fenghua.yu=
@intel.com/
v4:
- address comments from Balu and Randy
- Add CAT and CQM tests
v3:
- Change code based on comments from Babu Moger
- Remove some unnessary code and use pipe to communicate b/w processes
v2:
- Change code based on comments from Babu Moger
- Clean up other places.
Arshiya Hayatkhan Pathan (4):
selftests/resctrl: Add MBM test
selftests/resctrl: Add MBA test
selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest selftests/resctrl: Add Cache Allocation Technology (CAT) selftest
Babu Moger (3):
selftests/resctrl: Add vendor detection mechanism selftests/resctrl: Use cache index3 id for AMD schemata masks selftests/resctrl: Disable MBA and MBM tests for AMD
Fenghua Yu (2):
selftests/resctrl: Add README for resctrl tests
selftests/resctrl: Add the test in MAINTAINERS
Sai Praneeth Prakhya (4):
selftests/resctrl: Add basic resctrl file system operations and data selftests/resctrl: Read memory bandwidth from perf IMC counter and
from resctrl file system
selftests/resctrl: Add callback to start a benchmark selftests/resctrl: Add built in benchmark
MAINTAINERS | 1 + tools/testing/selftests/resctrl/Makefile | 16 + tools/testing/selftests/resctrl/README | 54 ++ tools/testing/selftests/resctrl/cache.c | 274 +++++++++ tools/testing/selftests/resctrl/cat_test.c | 242 ++++++++ tools/testing/selftests/resctrl/cqm_test.c | 173 ++++++ tools/testing/selftests/resctrl/fill_buf.c | 210 +++++++ tools/testing/selftests/resctrl/mba_test.c | 178 ++++++ tools/testing/selftests/resctrl/mbm_test.c | 150 +++++ tools/testing/selftests/resctrl/resctrl.h | 117 ++++ tools/testing/selftests/resctrl/resctrl_tests.c | 238 ++++++++ tools/testing/selftests/resctrl/resctrl_val.c | 723 ++++++++++++++++++++++++ tools/testing/selftests/resctrl/resctrlfs.c | 665 ++++++++++++++++++++++ 13 files changed, 3041 insertions(+) create mode 100644 tools/testing/selftests/resctrl/Makefile create mode 100644 tools/testing/selftests/resctrl/README create mode 100644 tools/testing/selftests/resctrl/cache.c create mode 100644 tools/testing/selftests/resctrl/cat_test.c create mode 100644 tools/testing/selftests/resctrl/cqm_test.c create mode 100644 tools/testing/selftests/resctrl/fill_buf.c create mode 100644 tools/testing/selftests/resctrl/mba_test.c create mode 100644 tools/testing/selftests/resctrl/mbm_test.c create mode 100644 tools/testing/selftests/resctrl/resctrl.h create mode 100644 tools/testing/selftests/resctrl/resctrl_tests.c create mode 100644 tools/testing/selftests/resctrl/resctrl_val.c create mode 100644 tools/testing/selftests/resctrl/resctrlfs.c
Signature · 1 line
2.7.4
PATCH v6 1/13 selftests/resctrl: Add README for resctrl tests
resctrl tests will be implemented. README is added for the tool first.
--- tools/testing/selftests/resctrl/README | 54 ++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 tools/testing/selftests/resctrl/README
tools/testing/selftests/resctrl/README new file +54 -0
@@ -0,0 +1,54 @@ +resctrl_tests - resctrl file system test suit + +Authors: + Fenghua Yu <[email protected]> + Sai Praneeth Prakhya <[email protected]>, + Arshiya Hayatkhan Pathan <[email protected]> + +resctrl_tests tests various resctrl functionalities and interfaces including +both software and hardware. + +Currently it supports Memory Bandwidth Monitoring test and Memory Bandwidth +Allocation test on Intel RDT hardware. More tests will be added in the future. +And the test suit can be extended to cover AMD QoS and ARM MPAM hardware +as well. + +BUILD +----- + +Run "make" to build executable file "resctrl_tests". + +RUN +--- + +To use resctrl_tests, root or sudoer privileges are required. This is because +the test needs to mount resctrl file system and change contents in the file +system. + +Executing the test without any parameter will run all supported tests: + + sudo ./resctrl_tests + +OVERVIEW OF EXECUTION +--------------------- + +A test case has four stages: + + - setup: mount resctrl file system, create group, setup schemata, move test + process pids to tasks, start benchmark. + - execute: let benchmark run + - verify: get resctrl data and verify the data with another source, e.g. + perf event. + - teardown: umount resctrl and clear temporary files. + +ARGUMENTS +--------- + +Parameter '-h' shows usage information. + +usage: resctrl_tests [-h] [-b "benchmark_cmd [options]"] [-t test list] [-n no_of_bits] + -b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CQM default benchmark is builtin fill_buf + -t test list: run tests specified in the test list, e.g. -t mbm, mba, cqm, cat + -n no_of_bits: run cache tests using specified no of bits in cache bit mask + -p cpu_no: specify CPU number to run the test. 1 is default + -h: help
Signature · 1 line
2.7.4
PATCH v6 2/13 selftests/resctrl: Add basic resctrl file system operations and data
In reply to Fenghua YuFrom: Sai Praneeth Prakhya <[email protected]>
The basic resctrl file system operations and data are added for future usage by resctrl selftest tool.
--- tools/testing/selftests/resctrl/Makefile | 10 + tools/testing/selftests/resctrl/resctrl.h | 48 +++ tools/testing/selftests/resctrl/resctrlfs.c | 461 ++++++++++++++++++++++++++++ 3 files changed, 519 insertions(+) create mode 100644 tools/testing/selftests/resctrl/Makefile create mode 100644 tools/testing/selftests/resctrl/resctrl.h create mode 100644 tools/testing/selftests/resctrl/resctrlfs.c
tools/testing/selftests/resctrl/Makefile new file +10 -0
@@ -0,0 +1,10 @@ +CC = gcc +CFLAGS = -g -Wall + +*.o: *.c + $(CC) $(CFLAGS) -c *.c + +.PHONY: clean + +clean: + $(RM) *.o *~
tools/testing/selftests/resctrl/resctrl.h new file +48 -0
48 lines not on this page · raw message
tools/testing/selftests/resctrl/resctrlfs.c new file +461 -0
461 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v6 3/13 selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system
In reply to Fenghua YuFrom: Sai Praneeth Prakhya <[email protected]>
Total memory bandwidth can be monitored from perf IMC counter and from resctrl file system. Later the two will be compared to verify the total memory bandwidth read from resctrl is correct.
--- tools/testing/selftests/resctrl/resctrl_val.c | 118 ++++++++++++++++++++++++++ 1 file changed, 118 insertions(+) create mode 100644 tools/testing/selftests/resctrl/resctrl_val.c
tools/testing/selftests/resctrl/resctrl_val.c new file +118 -0
@@ -0,0 +1,118 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Memory bandwidth monitoring and allocation library +* +* Copyright (C) 2018 Intel Corporation +* +* Authors: +* Arshiya Hayatkhan Pathan <[email protected]> +* Sai Praneeth Prakhya <[email protected]>, +* Fenghua Yu <[email protected]> +*/ +#include "resctrl.h" + +#define UNCORE_IMC "uncore_imc" +#define READ_FILE_NAME "events/cas_count_read" +#define WRITE_FILE_NAME "events/cas_count_write" +#define DYN_PMU_PATH "/sys/bus/event_source/devices" +#define SCALE 0.00006103515625 +#define MAX_IMCS 20 +#define MAX_TOKENS 5 +#define READ 0 +#define WRITE 1 +#define CON_MON_MBM_LOCAL_BYTES_PATH \ + "%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/mbm_local_bytes" + +#define CON_MBM_LOCAL_BYTES_PATH \ + "%s/%s/mon_data/mon_L3_%02d/mbm_local_bytes" + +#define MON_MBM_LOCAL_BYTES_PATH \ + "%s/mon_groups/%s/mon_data/mon_L3_%02d/mbm_local_bytes" + +#define MBM_LOCAL_BYTES_PATH \ + "%s/mon_data/mon_L3_%02d/mbm_local_bytes" + +struct membw_read_format { +__u64 value;/* The value of the event */ +__u64 time_enabled;/* if PERF_FORMAT_TOTAL_TIME_ENABLED */ +__u64 time_running;/* if PERF_FORMAT_TOTAL_TIME_RUNNING */ +__u64 id;/* if PERF_FORMAT_ID */ +}; + +struct imc_counter_config { +__u32 type; +__u64 event; +__u64 umask; +struct perf_event_attr pe; +struct membw_read_format return_value; +int fd; +}; + +static struct imc_counter_config imc_counters_config[MAX_IMCS ][2 ]; + +void membw_initialize_perf_event_attr (int i,int j) +{ +memset (&imc_counters_config[i][j].pe,0 , +sizeof (struct perf_event_attr )); + imc_counters_config[i][j].pe.type = imc_counters_config[i][j].type; + imc_counters_config[i][j].pe.size =sizeof (struct perf_event_attr ); + imc_counters_config[i][j].pe.disabled =1 ; + imc_counters_config[i][j].pe.inherit =1 ; + imc_counters_config[i][j].pe.exclude_guest =1 ; + imc_counters_config[i][j].pe.config = + imc_counters_config[i][j].umask <<8 | + imc_counters_config[i][j].event; + imc_counters_config[i][j].pe.sample_type =PERF_SAMPLE_IDENTIFIER ; + imc_counters_config[i][j].pe.read_format = +PERF_FORMAT_TOTAL_TIME_ENABLED |PERF_FORMAT_TOTAL_TIME_RUNNING ; +} + +void membw_ioctl_perf_event_ioc_reset_enable (int i,int j) +{ +ioctl (imc_counters_config[i][j].fd,PERF_EVENT_IOC_RESET ,0 ); +ioctl (imc_counters_config[i][j].fd,PERF_EVENT_IOC_ENABLE ,0 ); +} + +void membw_ioctl_perf_event_ioc_disable (int i,int j) +{ +ioctl (imc_counters_config[i][j].fd,PERF_EVENT_IOC_DISABLE ,0 ); +} + +/* +* get_event_and_umask: Parse config into event and umask +* @cas_count_cfg: Config +* @count: iMC number +* @op: Operation (read/write) +*/ +void get_event_and_umask (char *cas_count_cfg,int count,bool op) +{ +char *token[MAX_TOKENS ]; +int i =0 ; + +strcat (cas_count_cfg,"," ); + token[0 ] =strtok (cas_count_cfg,"=," ); + +for (i =1 ; i <MAX_TOKENS ; i++) + token[i] =strtok (NULL ,"=," ); + +for (i =0 ; i <MAX_TOKENS ; i++) { +if (!token[i]) +break ; +if (strcmp (token[i],"event" ) ==0 ) { +if (op ==READ ) + imc_counters_config[count][READ ].event = +strtol (token[i +1 ],NULL ,16 ); +else + imc_counters_config[count][WRITE ].event = +strtol (token[i +1 ],NULL ,16 ); + } +if (strcmp (token[i],"umask" ) ==0 ) { +if (op ==READ ) + imc_counters_config[count][READ ].umask = +strtol (token[i +1 ],NULL ,16 ); +else + imc_counters_config[count][WRITE ].umask = +strtol (token[i +1 ],NULL ,16 ); + } + } +}
Signature · 1 line
2.7.4
PATCH v6 4/13 selftests/resctrl: Add callback to start a benchmark
In reply to Fenghua YuFrom: Sai Praneeth Prakhya <[email protected]>
The callback starts a child process and puts the child pid in created resctrl group with specified memory bandwidth in schemata. The child starts running benchmark.
--- tools/testing/selftests/resctrl/resctrl.h | 27 ++ tools/testing/selftests/resctrl/resctrl_val.c | 582 ++++++++++++++++++++++++++ 2 files changed, 609 insertions(+)
tools/testing/selftests/resctrl/resctrl.h +27 -0
@@ -3,6 +3,7 @@#ifndef RESCTRL_H #define RESCTRL_H #include <stdio.h> +#include <stdarg.h> #include <errno.h> #include <sched.h> #include <stdlib.h>
@@ -28,10 +29,35 @@exit (EXIT_FAILURE ); \ }while (0 ) +/* +* resctrl_val_param: resctrl test parameters +* @resctrl_val: Resctrl feature (Eg: mbm, mba.. etc) +* @ctrlgrp: Name of the control monitor group (con_mon grp) +* @mongrp: Name of the monitor group (mon grp) +* @cpu_no: CPU number to which the benchmark would be binded +* @span: Memory bytes accessed in each benchmark iteration +* @mum_resctrlfs: Should the resctrl FS be remounted? +* @filename: Name of file to which the o/p should be written +* @bw_report: Bandwidth report type (reads vs writes) +* @setup: Call back function to setup test environment +*/ +struct resctrl_val_param { +char *resctrl_val; +char ctrlgrp[64 ]; +char mongrp[64 ]; +int cpu_no; +int span; +int mum_resctrlfs; +char filename[64 ]; +char *bw_report; +int (*setup)(int num, ...); +}; +pid_t bm_pid, ppid;int remount_resctrlfs (bool mum_resctrlfs);int get_resource_id (int cpu_no,int *resource_id); +int umount_resctrlfs (void );int validate_bw_report_request (char *bw_report);int validate_resctrl_feature_request (char *resctrl_val);int taskset_benchmark (pid_t bm_pid,int cpu_no);
@@ -44,5 +70,6 @@ int perf_event_open(struct perf_event_attr *hw_event, pid_t pid, int cpu, int group_fd, unsigned long flags);int run_fill_buf (unsigned long span,int malloc_and_init_memory,int memflush,int op,char *resctrl_va); +int resctrl_val (char **benchmark_cmd,struct resctrl_val_param *param);#endif /* RESCTRL_H */
tools/testing/selftests/resctrl/resctrl_val.c +582 -0
597 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v6 5/13 selftests/resctrl: Add built in benchmark
In reply to Fenghua YuFrom: Sai Praneeth Prakhya <[email protected]>
Built-in benchmark fill_buf generates stressful memory bandwidth and cache traffic.
Later it will be used as a default benchmark by various resctrl tests such as MBA (Memory Bandwidth Allocation) and MBM (Memory Bandwidth Monitoring) tests.
--- tools/testing/selftests/resctrl/fill_buf.c | 204 +++++++++++++++++++++++++++++ 1 file changed, 204 insertions(+) create mode 100644 tools/testing/selftests/resctrl/fill_buf.c
tools/testing/selftests/resctrl/fill_buf.c new file +204 -0
@@ -0,0 +1,204 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* fill_buf benchmark +* +* Copyright (C) 2018 Intel Corporation +* +* Authors: +* Arshiya Hayatkhan Pathan <[email protected]> +* Sai Praneeth Prakhya <[email protected]>, +* Fenghua Yu <[email protected]> +*/ +#include <stdio.h> +#include <unistd.h> +#include <stdlib.h> +#include <sys/types.h> +#include <sys/wait.h> +#include <inttypes.h> +#include <malloc.h> +#include <string.h> + +#include "resctrl.h" + +#define CL_SIZE (64) +#define PAGE_SIZE (4 * 1024) +#define MB (1024 * 1024) + +static unsigned char *startptr; + +static void sb (void ) +{ + asmvolatile ("sfence\n\t" + : : :"memory" ); +} + +static void ctrl_handler (int signo) +{ +free (startptr); +printf ("\nEnding\n" ); +sb (); +exit (EXIT_SUCCESS ); +} + +static void cl_flush (void *p) +{ + asmvolatile ("clflush (%0)\n\t" + : :"r" (p) :"memory" ); +} + +static void mem_flush (void *p,size_t s) +{ +char *cp = (char *)p; +size_t i =0 ; + + s = s /CL_SIZE ;/* mem size in cache llines */ + +for (i =0 ; i < s; i++) +cl_flush (&cp[i *CL_SIZE ]); + +sb (); +} + +static void *malloc_and_init_memory (size_t s) +{ +uint64_t *p64; +size_t s64; + +void *p =memalign (PAGE_SIZE , s); + + p64 = (uint64_t *)p; + s64 = s /sizeof (uint64_t ); + +while (s64 >0 ) { + *p64 = (uint64_t )rand (); + p64 += (CL_SIZE /sizeof (uint64_t )); + s64 -= (CL_SIZE /sizeof (uint64_t )); + } + +return p; +} + +static int fill_one_span_read (unsigned char *start_ptr,unsigned char *end_ptr) +{ +unsigned char sum, *p; + + sum =0 ; + p = start_ptr; +while (p < end_ptr) { + sum += *p; + p += (CL_SIZE /2 ); + } + +return sum; +} + +static +void fill_one_span_write (unsigned char *start_ptr,unsigned char *end_ptr) +{ +unsigned char *p; + + p = start_ptr; +while (p < end_ptr) { + *p ='1' ; + p += (CL_SIZE /2 ); + } +} + +static int fill_cache_read (unsigned char *start_ptr,unsigned char *end_ptr, +char *resctrl_val) +{ +int ret =0 ; +FILE *fp; + +while (1 ) + ret =fill_one_span_read (start_ptr, end_ptr); + +/* Consume read result so that reading memory is not optimized out. */ + fp =fopen ("/dev/null" ,"w" ); +if (!fp) +perror ("Unable to write to /dev/null" ); +fprintf (fp,"Sum: %d " , ret); +fclose (fp); + +return 0 ; +} + +static int fill_cache_write (unsigned char *start_ptr,unsigned char *end_ptr, +char *resctrl_val) +{ +while (1 ) +fill_one_span_write (start_ptr, end_ptr); + +return 0 ; +} + +static int +fill_cache (unsigned long long buf_size,int malloc_and_init,int memflush, +int op,char *resctrl_val) +{ +unsigned char *start_ptr, *end_ptr; +unsigned long long i; +int ret; + +if (malloc_and_init) + start_ptr =malloc_and_init_memory (buf_size); +else + start_ptr =malloc (buf_size); + +if (!start_ptr) +return -1 ; + + startptr = start_ptr; + end_ptr = start_ptr + buf_size; + +/* +* It's better to touch the memory once to avoid any compiler +* optimizations +*/ +if (!malloc_and_init) { +for (i =0 ; i < buf_size; i++) + *start_ptr++ = (unsigned char )rand (); + } + + start_ptr = startptr; + +/* Flush the memory before using to avoid "cache hot pages" effect */ +if (memflush) +mem_flush (start_ptr, buf_size); + +if (op ==0 ) + ret =fill_cache_read (start_ptr, end_ptr, resctrl_val); +else + ret =fill_cache_write (start_ptr, end_ptr, resctrl_val); + +if (ret) { +printf ("\n Errror in fill cache read/write...\n" ); +return -1 ; + } + +free (startptr); + +return 0 ; +} + +int run_fill_buf (unsigned long span,int malloc_and_init_memory, +int memflush,int op,char *resctrl_val) +{ +unsigned long long cache_size = span; +int ret; + +/* set up ctrl-c handler */ +if (signal (SIGINT , ctrl_handler) ==SIG_ERR ) +printf ("Failed to catch SIGINT!\n" ); +if (signal (SIGHUP , ctrl_handler) ==SIG_ERR ) +printf ("Failed to catch SIGHUP!\n" ); + + ret =fill_cache (cache_size, malloc_and_init_memory, memflush, op, + resctrl_val); +if (ret) { +printf ("\n Errror in fill cache\n" ); +return -1 ; + } + +return 0 ; +}
Signature · 1 line
2.7.4
PATCH v6 6/13 selftests/resctrl: Add MBM test
In reply to Fenghua YuFrom: Arshiya Hayatkhan Pathan <[email protected]>
MBM (Memory Bandwidth Monitoring) test is the first implemented selftest. It starts a stressful memory bandwidth benchmark and assigns the bandwidth pid in a resctrl monitoring group. Read and compare perf IMC counter and MBM total bytes for the benchmark. The numbers should be close enough to pass the test.
Default benchmark is built-in fill_buf. But users can specify their own benchmark by option "-b".
We can add memory bandwidth monitoring for multiple processes in the future.
--- tools/testing/selftests/resctrl/Makefile | 8 +- tools/testing/selftests/resctrl/mbm_test.c | 149 ++++++++++++++++++++++++ tools/testing/selftests/resctrl/resctrl.h | 3 + tools/testing/selftests/resctrl/resctrl_tests.c | 115 ++++++++++++++++++ tools/testing/selftests/resctrl/resctrl_val.c | 2 + 5 files changed, 276 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/resctrl/mbm_test.c create mode 100644 tools/testing/selftests/resctrl/resctrl_tests.c
tools/testing/selftests/resctrl/Makefile +7 -1
@@ -1,10 +1,16 @@ CC = gcc CFLAGS = -g -Wall +all: resctrl_tests + *.o: *.c $(CC) $(CFLAGS) -c *.c +resctrl_tests: *.o + $(CC) $(CFLAGS) -o resctrl_tests resctrl_tests.o resctrlfs.o \ + resctrl_val.o fill_buf.o mbm_test.o + .PHONY: clean clean: - $(RM) *.o *~ + $(RM) *.o *~ resctrl_tests
tools/testing/selftests/resctrl/mbm_test.c new file +149 -0
149 lines not on this page · raw message
tools/testing/selftests/resctrl/resctrl.h +3 -0
@@ -71,5 +71,8 @@ int perf_event_open(struct perf_event_attr *hw_event, pid_t pid, int cpu,int run_fill_buf (unsigned long span,int malloc_and_init_memory,int memflush,int op,char *resctrl_va);int resctrl_val (char **benchmark_cmd,struct resctrl_val_param *param); +int mbm_bw_change (int span,int cpu_no,char *bw_report,char **benchmark_cmd); +void tests_cleanup (void ); +void mbm_test_cleanup (void );#endif /* RESCTRL_H */
tools/testing/selftests/resctrl/resctrl_tests.c new file +115 -0
115 lines not on this page · raw message
tools/testing/selftests/resctrl/resctrl_val.c +2 -0
@@ -437,6 +437,8 @@ pid_t bm_pid, ppid;static void ctrlc_handler (int signum,siginfo_t *info,void *ptr) {kill (bm_pid,SIGKILL ); +umount_resctrlfs (); +tests_cleanup ();printf ("Ending\n\n" );exit (EXIT_SUCCESS );
Signature · 1 line
2.7.4
PATCH v6 7/13 selftests/resctrl: Add MBA test
In reply to Fenghua YuFrom: Arshiya Hayatkhan Pathan <[email protected]>
MBA (Memory Bandwidth Allocation) test starts a stressful memory bandwidth benchmark and allocates memory bandwidth from 100% down to 10% for the benchmark process. For each allocation, compare perf IMC counter and mbm total bytes from resctrl. The difference between the two values should be within a threshold to pass the test.
Default benchmark is built-in fill_buf. But users can specify their own benchmark by option "-b".
We can add memory bandwidth allocation for multiple processes in the future.
--- tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/mba_test.c | 177 ++++++++++++++++++++++++ tools/testing/selftests/resctrl/resctrl.h | 2 + tools/testing/selftests/resctrl/resctrl_tests.c | 15 +- 4 files changed, 194 insertions(+), 2 deletions(-) create mode 100644 tools/testing/selftests/resctrl/mba_test.c
tools/testing/selftests/resctrl/Makefile +1 -1
@@ -8,7 +8,7 @@ all: resctrl_tests resctrl_tests: *.o $(CC) $(CFLAGS) -o resctrl_tests resctrl_tests.o resctrlfs.o \ - resctrl_val.o fill_buf.o mbm_test.o + resctrl_val.o fill_buf.o mbm_test.o mba_test.o .PHONY: clean
tools/testing/selftests/resctrl/mba_test.c new file +177 -0
177 lines not on this page · raw message
tools/testing/selftests/resctrl/resctrl.h +2 -0
@@ -74,5 +74,7 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param);int mbm_bw_change (int span,int cpu_no,char *bw_report,char **benchmark_cmd);void tests_cleanup (void );void mbm_test_cleanup (void ); +int mba_schemata_change (int cpu_no,char *bw_report,char **benchmark_cmd); +void mba_test_cleanup (void );#endif /* RESCTRL_H */
tools/testing/selftests/resctrl/resctrl_tests.c +14 -1
@@ -27,6 +27,7 @@ static void cmd_help(void)void tests_cleanup (void ) {mbm_test_cleanup (); +mba_test_cleanup (); }int main (int argc,char **argv)
@@ -34,7 +35,7 @@ int main(int argc, char **argv)char benchmark_cmd_area[BENCHMARK_ARGS ][BENCHMARK_ARG_SIZE ];int res, c, cpu_no =1 , span =250 , argc_new = argc, i;int ben_count, ben_ind; -bool has_ben = false, mbm_test = true; +bool has_ben = false, mbm_test = true, mba_test = true;char *benchmark_cmd[BENCHMARK_ARGS ];char bw_report[64 ], bm_type[64 ];
@@ -56,9 +57,12 @@ int main(int argc, char **argv) token =strtok (optarg,"," ); mbm_test = false; + mba_test = false;while (token) {if (!strcmp (token,"mbm" )) { mbm_test = true; + }else if (!strcmp (token,"mba" )) { + mba_test = true; }else {printf ("invalid argument\n" );
@@ -111,5 +115,14 @@ int main(int argc, char **argv)printf ("Error in running tests for mbm bw change!\n" ); } +if (mba_test) { +printf ("\nMBA Schemata Change Starting..\n" ); +if (!has_ben) +sprintf (benchmark_cmd[1 ],"%d" , span); + res =mba_schemata_change (cpu_no, bw_report, benchmark_cmd); +if (res) +printf ("Error in tests for mba-change-schemata!\n" ); + } +return 0 ; }
Signature · 1 line
2.7.4
PATCH v6 8/13 selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest
In reply to Fenghua YuFrom: Arshiya Hayatkhan Pathan <[email protected]>
Cache QoS Monitoring (CQM) selftest starts stressful cache benchmark with specified size of memory to access the cache. Last Level cache occupancy reported by CQM should be close to the size of the memory.
--- tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/cache.c | 101 +++++++++++ tools/testing/selftests/resctrl/cqm_test.c | 173 ++++++++++++++++++ tools/testing/selftests/resctrl/mba_test.c | 1 + tools/testing/selftests/resctrl/mbm_test.c | 1 + tools/testing/selftests/resctrl/resctrl.h | 23 ++- tools/testing/selftests/resctrl/resctrl_tests.c | 53 +++++- tools/testing/selftests/resctrl/resctrl_val.c | 95 ++++++---- tools/testing/selftests/resctrl/resctrlfs.c | 229 ++++++++++++++++++++++-- 9 files changed, 613 insertions(+), 65 deletions(-) create mode 100644 tools/testing/selftests/resctrl/cache.c create mode 100644 tools/testing/selftests/resctrl/cqm_test.c
tools/testing/selftests/resctrl/Makefile +1 -1
@@ -8,7 +8,7 @@ all: resctrl_tests resctrl_tests: *.o $(CC) $(CFLAGS) -o resctrl_tests resctrl_tests.o resctrlfs.o \ - resctrl_val.o fill_buf.o mbm_test.o mba_test.o + resctrl_val.o fill_buf.o mbm_test.o mba_test.o cache.o cqm_test.o .PHONY: clean
tools/testing/selftests/resctrl/cache.c new file +101 -0
101 lines not on this page · raw message
tools/testing/selftests/resctrl/cqm_test.c new file +173 -0
173 lines not on this page · raw message
tools/testing/selftests/resctrl/mba_test.c +1 -0
@@ -57,6 +57,7 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) {int allocation, failed =0 , runs; +printf ("\nResults are displayed in (MB)\n" );/* Memory bandwidth from 100% down to 10% */ for (allocation =0 ; allocation <ALLOCATION_MAX /ALLOCATION_STEP ; allocation++) {
tools/testing/selftests/resctrl/mbm_test.c +1 -0
@@ -36,6 +36,7 @@ show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, int span) avg_bw_resc = sum_bw_resc /4 ; avg_diff = avg_bw_resc - avg_bw_imc; +printf ("\nResults are displayed in (MB)\n" );printf ("\nSpan (MB): %d \t" , span);printf ("avg_bw_imc: %lu\t" , avg_bw_imc);printf ("avg_bw_resc: %lu\t" , avg_bw_resc);
tools/testing/selftests/resctrl/resctrl.h +22 -1
@@ -16,11 +16,18 @@#include <sys/ioctl.h> #include <sys/mount.h> #include <sys/types.h> +#include <sys/select.h> #include <asm/unistd.h> #include <linux/perf_event.h> +#include <sys/time.h> +#include <math.h> +#include <sys/wait.h> +#include <sys/eventfd.h> +#define MB (1024 * 1024)#define RESCTRL_PATH "/sys/fs/resctrl"#define PHYS_ID_PATH "/sys/devices/system/cpu/cpu" +#define CBM_MASK_PATH "/sys/fs/resctrl/info"#define PARENT_EXIT (err_msg) \ do { \
@@ -46,14 +53,20 @@ struct resctrl_val_param {char ctrlgrp[64 ];char mongrp[64 ];int cpu_no; -int span; +unsigned long long span;int mum_resctrlfs;char filename[64 ];char *bw_report; +unsigned long mask; +int num_of_runs;int (*setup)(int num, ...); + };pid_t bm_pid, ppid; +extern char cbm_mask[256 ]; +extern unsigned long long_mask; +extern char llc_occup_path[1024 ];int remount_resctrlfs (bool mum_resctrlfs);int get_resource_id (int cpu_no,int *resource_id);
@@ -76,5 +89,13 @@ void tests_cleanup(void);void mbm_test_cleanup (void );int mba_schemata_change (int cpu_no,char *bw_report,char **benchmark_cmd);void mba_test_cleanup (void ); +int get_cbm_mask (char *cache_type); +int get_cache_size (int cpu_no,char *cache_type,unsigned long *cache_size); +void ctrlc_handler (int signum,siginfo_t *info,void *ptr); +int cqm_resctrl_val (int cpu_no,int n,char **benchmark_cmd); +unsigned int count_bits (unsigned long n); +void cqm_test_cleanup (void ); +int get_core_sibling (int cpu_no); +int measure_cache_vals (struct resctrl_val_param *param,int bm_pid);#endif /* RESCTRL_H */
tools/testing/selftests/resctrl/resctrl_tests.c +44 -9
120 lines not on this page · raw message
tools/testing/selftests/resctrl/resctrl_val.c +58 -37
168 lines not on this page · raw message
tools/testing/selftests/resctrl/resctrlfs.c +212 -17
331 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v6 9/13 selftests/resctrl: Add Cache Allocation Technology (CAT) selftest
In reply to Fenghua YuFrom: Arshiya Hayatkhan Pathan <[email protected]>
Cache Allocation Technology (CAT) selftest allocates a portion of last level cache and starts a benchmark to read each cache line in this portion of cache. Measure the cache misses in perf and the misses should be equal to the number of cache lines in this portion of cache.
We don't use CQM to calculate cache usage because some CAT enabled platforms don't have CQM.
--- tools/testing/selftests/resctrl/Makefile | 2 +- tools/testing/selftests/resctrl/cache.c | 175 ++++++++++++++++- tools/testing/selftests/resctrl/cat_test.c | 242 ++++++++++++++++++++++++ tools/testing/selftests/resctrl/fill_buf.c | 10 +- tools/testing/selftests/resctrl/resctrl.h | 3 + tools/testing/selftests/resctrl/resctrl_tests.c | 14 +- tools/testing/selftests/resctrl/resctrlfs.c | 10 +- 7 files changed, 448 insertions(+), 8 deletions(-) create mode 100644 tools/testing/selftests/resctrl/cat_test.c
tools/testing/selftests/resctrl/Makefile +1 -1
@@ -8,7 +8,7 @@ all: resctrl_tests resctrl_tests: *.o $(CC) $(CFLAGS) -o resctrl_tests resctrl_tests.o resctrlfs.o \ - resctrl_val.o fill_buf.o mbm_test.o mba_test.o cache.o cqm_test.o + resctrl_val.o fill_buf.o mbm_test.o mba_test.o cache.o cqm_test.o cat_test.o .PHONY: clean
tools/testing/selftests/resctrl/cache.c +174 -1
197 lines not on this page · raw message
tools/testing/selftests/resctrl/cat_test.c new file +242 -0
242 lines not on this page · raw message
tools/testing/selftests/resctrl/fill_buf.c +8 -2
@@ -110,8 +110,11 @@ static int fill_cache_read(unsigned char *start_ptr, unsigned char *end_ptr,int ret =0 ;FILE *fp; -while (1 ) +while (1 ) { ret =fill_one_span_read (start_ptr, end_ptr); +if (!strcmp (resctrl_val,"cat" )) +break ; + }/* Consume read result so that reading memory is not optimized out. */ fp =fopen ("/dev/null" ,"w" );
@@ -126,8 +129,11 @@ static int fill_cache_read(unsigned char *start_ptr, unsigned char *end_ptr,static int fill_cache_write (unsigned char *start_ptr,unsigned char *end_ptr,char *resctrl_val) { -while (1 ) +while (1 ) {fill_one_span_write (start_ptr, end_ptr); +if (!strcmp (resctrl_val,"cat" )) +break ; + }return 0 ; }
tools/testing/selftests/resctrl/resctrl.h +3 -0
@@ -92,6 +92,9 @@ void mba_test_cleanup(void);int get_cbm_mask (char *cache_type);int get_cache_size (int cpu_no,char *cache_type,unsigned long *cache_size);void ctrlc_handler (int signum,siginfo_t *info,void *ptr); +int cat_val (struct resctrl_val_param *param); +void cat_test_cleanup (void ); +int cat_perf_miss_val (int cpu_no,int no_of_bits,char *cache_type);int cqm_resctrl_val (int cpu_no,int n,char **benchmark_cmd);unsigned int count_bits (unsigned long n);void cqm_test_cleanup (void );
tools/testing/selftests/resctrl/resctrl_tests.c +13 -1
@@ -20,7 +20,7 @@ static void cmd_help(void)printf ("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CQM" );printf ("\t default benchmark is builtin fill_buf\n" );printf ("\t-t test list: run tests specified in the test list, " ); -printf ("e.g. -t mbm, mba, cqm\n" ); +printf ("e.g. -t mbm, mba, cqm, cat\n" );printf ("\t-n no_of_bits: run cache tests using specified no of bits in cache bit mask\n" );printf ("\t-p cpu_no: specify CPU number to run the test. 1 is default\n" );printf ("\t-h: help\n" );
@@ -31,6 +31,7 @@ void tests_cleanup(void)mbm_test_cleanup ();mba_test_cleanup ();cqm_test_cleanup (); +cat_test_cleanup (); }int main (int argc,char **argv)
@@ -39,6 +40,7 @@ int main(int argc, char **argv)int res, c, cpu_no =1 , span =250 , argc_new = argc, i, no_of_bits =5 ;int ben_count, ben_ind;bool has_ben = false, mbm_test = true, mba_test = true, cqm_test = true; +bool cat_test = true;char *benchmark_cmd[BENCHMARK_ARGS ];char bw_report[64 ], bm_type[64 ];
@@ -62,6 +64,7 @@ int main(int argc, char **argv) mbm_test = false; mba_test = false; cqm_test = false; + cat_test = false;while (token) {if (!strcmp (token,"mbm" )) { mbm_test = true;
@@ -69,6 +72,8 @@ int main(int argc, char **argv) mba_test = true; }else if (!strcmp (token,"cqm" )) { cqm_test = true; + }else if (!strcmp (token,"cat" )) { + cat_test = true; }else {printf ("invalid argument\n" );
@@ -158,6 +163,13 @@ int main(int argc, char **argv)printf ("Error in CQM test!\n" );cqm_test_cleanup (); } +if (cat_test) { +printf ("\nCAT Test Starting..\n" ); + res =cat_perf_miss_val (cpu_no, no_of_bits,"L3" ); +if (res) +printf ("Error in CAT test!\n" ); +cat_test_cleanup (); + }return 0 ; }
tools/testing/selftests/resctrl/resctrlfs.c +7 -3
@@ -14,12 +14,14 @@#define RESCTRL_MBM "L3 monitoring detected"#define RESCTRL_MBA "MB allocation detected"#define RESCTRL_CQM "L3 monitoring detected" +#define RESCTRL_L3_CAT "L3 allocation detected"#define CORE_SIBLINGS_PATH "/sys/bus/cpu/devices/cpu"enum {RESCTRL_FEATURE_MBM ,RESCTRL_FEATURE_MBA ,RESCTRL_FEATURE_CQM , +RESCTRL_FEATURE_L3_CAT ,MAX_RESCTRL_FEATURES };
@@ -490,6 +492,7 @@ int write_schemata(char *ctrlgrp, char *schemata, int cpu_no, char *resctrl_val)FILE *fp;if ((strcmp (resctrl_val,"mba" ) ==0 ) || + (strcmp (resctrl_val,"cat" ) ==0 ) || (strcmp (resctrl_val,"cqm" ) ==0 )) {if (!schemata) {printf ("Schemata empty, so not updating\n" );
@@ -507,7 +510,7 @@ int write_schemata(char *ctrlgrp, char *schemata, int cpu_no, char *resctrl_val)else sprintf (controlgroup,"%s/schemata" ,RESCTRL_PATH ); -if (!strcmp (resctrl_val,"cqm" )) +if (!strcmp (resctrl_val,"cat" ) || !strcmp (resctrl_val,"cqm" ))sprintf (schema,"%s%d%c%s" ,"L3:" , resource_id,'=' , schemata);if (strcmp (resctrl_val,"mba" ) ==0 )
@@ -545,7 +548,7 @@ int validate_resctrl_feature_request(char *resctrl_val) {int resctrl_features_supported[MAX_RESCTRL_FEATURES ] = {0 ,0 ,0 ,0 };const char *resctrl_features_list[MAX_RESCTRL_FEATURES ] = { -"mbm" ,"mba" ,"cqm" }; +"mbm" ,"mba" ,"cat" ,"cqm" };int i, valid_resctrl_feature =-1 ;char line[1024 ];FILE *fp;
@@ -588,7 +591,8 @@ int validate_resctrl_feature_request(char *resctrl_val) resctrl_features_supported[RESCTRL_FEATURE_MBA ] =1 ;if ((strstr (line,RESCTRL_CQM )) !=NULL ) resctrl_features_supported[RESCTRL_FEATURE_CQM ] =1 ; - +if ((strstr (line,RESCTRL_L3_CAT )) !=NULL ) + resctrl_features_supported[RESCTRL_FEATURE_L3_CAT ] =1 ; }fclose (fp);
Signature · 1 line
2.7.4
PATCH v6 10/13 selftests/resctrl: Add vendor detection mechanism
In reply to Fenghua YuFrom: Babu Moger <[email protected]>
RESCTRL feature is supported both on Intel and AMD now. Some features are implemented differently. Add vendor detection mechanism. Use the vendor check where there are differences.
--- tools/testing/selftests/resctrl/resctrl.h | 13 +++++ tools/testing/selftests/resctrl/resctrl_tests.c | 63 +++++++++++++++++++++++++ 2 files changed, 76 insertions(+)
tools/testing/selftests/resctrl/resctrl.h +13 -0
@@ -63,10 +63,23 @@ struct resctrl_val_param { }; +/** +* Results of CPUID operation are stored in this structure. +* It consists of 4x32bits IA registers: EAX, EBX, ECX and EDX. +*/ +struct cpuid_out { +uint32_t eax; +uint32_t ebx; +uint32_t ecx; +uint32_t edx; +}; +pid_t bm_pid, ppid;extern char cbm_mask[256 ];extern unsigned long long_mask;extern char llc_occup_path[1024 ]; +extern int genuine_intel; +extern int authentic_amd;int remount_resctrlfs (bool mum_resctrlfs);int get_resource_id (int cpu_no,int *resource_id);
tools/testing/selftests/resctrl/resctrl_tests.c +63 -0
75 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v6 11/13 selftests/resctrl: Use cache index3 id for AMD schemata masks
In reply to Fenghua YuFrom: Babu Moger <[email protected]>
AMD uses the cache l3 boundary for schemata masks. Update it accordigly.
--- tools/testing/selftests/resctrl/resctrlfs.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
tools/testing/selftests/resctrl/resctrlfs.c +7 -2
@@ -110,8 +110,13 @@ int get_resource_id(int cpu_no, int *resource_id)char phys_pkg_path[1024 ];FILE *fp; -sprintf (phys_pkg_path,"%s%d/topology/physical_package_id" , -PHYS_ID_PATH , cpu_no); +if (authentic_amd) +sprintf (phys_pkg_path,"%s%d/cache/index3/id" , +PHYS_ID_PATH , cpu_no); +else +sprintf (phys_pkg_path,"%s%d/topology/physical_package_id" , +PHYS_ID_PATH , cpu_no); + fp =fopen (phys_pkg_path,"r" );if (!fp) {perror ("Failed to open physical_package_id" );
Signature · 1 line
2.7.4
PATCH v6 12/13 selftests/resctrl: Disable MBA and MBM tests for AMD
In reply to Fenghua YuFrom: Babu Moger <[email protected]>
For now, disable MBA and MBM tests for AMD. Deciding test pass/fail is not clear right now. We can enable when we have some clarity.
--- tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/resctrl/resctrl_tests.c +2 -2
@@ -197,7 +197,7 @@ int main(int argc, char **argv)sprintf (bw_report,"reads" );sprintf (bm_type,"fill_buf" ); -if (mbm_test) { +if (genuine_intel && mbm_test) {printf ("\nMBM BW Change Starting..\n" );if (!has_ben)sprintf (benchmark_cmd[5 ],"%s" ,"mbm" );
@@ -207,7 +207,7 @@ int main(int argc, char **argv)mbm_test_cleanup (); } -if (mba_test) { +if (genuine_intel && mba_test) {printf ("\nMBA Schemata Change Starting..\n" );if (!has_ben)sprintf (benchmark_cmd[5 ],"%s" ,"mba" );
Signature · 1 line
2.7.4
PATCH v6 13/13 selftests/resctrl: Add the test in MAINTAINERS
In reply to Fenghua YuThe resctrl selftest will be maintained by RDT maintainers.
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
@@ -12819,6 +12819,7 @@ S: Supported F: arch/x86/kernel/cpu/resctrl/ F: arch/x86/include/asm/resctrl_sched.h F: Documentation/x86/resctrl* +F: tools/testing/selftests/resctrl/ READ-COPY UPDATE (RCU) M: "Paul E. McKenney" <[email protected]>
Signature · 1 line
2.7.4