Skip to contentSkip to conversation

patch "Revert "selftests: firmware: add" added to driver-core-testing

PATCH [email protected] 1 participant 1 message Feb 8, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Revert "selftests: firmware: add

to my driver-core git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
in the driver-core-testing branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will be merged to the driver-core-next branch sometime soon, after it passes testing, and the merge window is open.

If you have any questions about this process, please let me know.

From d2b284d356e9758d2bafd505d482e3c9433ef424 Mon Sep 17 00:00:00 2001
From: Luis Chamberlain <[email protected]>
Date: Thu, 7 Feb 2019 11:06:00 -0800
Subject: Revert "selftests: firmware: add
CONFIG_FW_LOADER_USER_HELPER_FALLBACK to config"

This reverts commit 7492902e8d22b568463897fa967c0886764cf034.

The commit tried to address an issue discovered by Dan where he got a message saying:

'usermode helper disabled so ignoring test'.

Dans's commit is forcing CONFIG_FW_LOADER_USER_HELPER_FALLBACK but just having CONFIG_FW_LOADER_USER_HELPER suffices to emulate the_FALLBACK functionality.

Dan's commit is trying to fix an issue which is hidden from a previous commit. That issue will be addressed properly next.

Fixes 7492902e8d22 ("selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK to config")
Cc stable <[email protected]>
---
 tools/testing/selftests/firmware/config | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/firmware/config +0 -1
index 913a25a4a32b..bf634dda0720 100644
@@ -1,6 +1,5 @@
 CONFIG_TEST_FIRMWARE=y
 CONFIG_FW_LOADER=y
 CONFIG_FW_LOADER_USER_HELPER=y
-CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y
 CONFIG_IKCONFIG=y
 CONFIG_IKCONFIG_PROC=y
Signature · 1 line
2.20.1