net: hso: do not call unregister if not registered
Subsystems (4)
PATCH 1/1 net: hso: do not call unregister if not registered
On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.
Signed-off-by Tuba Yavuz <[email protected]>
---
drivers/net/usb/hso.c renamed from drivers/net/usb/hso.c.orig +2 -1
@@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct hremove_net_device (hso_net->parent); -if (hso_net->net) +if (hso_net->net && + hso_net->net->reg_state ==NETREG_REGISTERED )unregister_netdev (hso_net->net);/* start freeing */