net: hso: do not unregister if not registered
Subsystems (4)
PATCH 1/1 net: hso: do not unregister if not registered
On an error path inside the hso_create_net_device function of the hso driver, hso_free_net_device gets called. This causes potentially a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.
---
drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 renamed from drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 +2 -1
@@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h remove_net_device(hso_net->parent); - if (hso_net->net) + if (hso_net->net && + hso_net->net->reg_state == NETREG_REGISTERED) unregister_netdev(hso_net->net); /* start freeing */
David Miller
maintainerFrom: "Yavuz, Tuba" <[email protected]>
Date: Wed, 6 Feb 2019 00:40:31 +0000
Quoted 9 lines
On an error path inside the
hso_create_net_devicefunction of the hso driver,hso_free_net_devicegets called. This causes potentially a negative reference count in the net device ifregister_netdevhas not been called yet ashso_free_net_devicecallsunregister_netdevregardless. I think the driver should distinguish these cases and callunregister_netdevonly ifregister_netdevhas been called.Signed-off-by Tuba Yavuz <[email protected]>
This patch is corrupted by your email client.
I just resubmitted the patch and made sure to send it in plaintext. Hopefully, it will work this time.
Best,
Tuba
________________________________________
From: David Miller <[email protected]>
Sent: Friday, February 8, 2019 6:08 PM
To: Yavuz, Tuba
Cc: [email protected]
Subject: Re: [PATCH] net: hso: do not unregister if not registered
From: "Yavuz, Tuba" <[email protected]>
Date: Wed, 6 Feb 2019 00:40:31 +0000
Quoted 9 lines
On an error path inside the
hso_create_net_devicefunction of the hso driver,hso_free_net_devicegets called. This causes potentially a negative reference count in the net device ifregister_netdevhas not been called yet ashso_free_net_devicecallsunregister_netdevregardless. I think the driver should distinguish these cases and callunregister_netdevonly ifregister_netdevhas been called.Signed-off-by Tuba Yavuz <[email protected]>
This patch is corrupted by your email client.
David Miller
maintainerFrom: "Yavuz, Tuba" <[email protected]>
Date: Sat, 9 Feb 2019 00:02:56 +0000
Quoted 2 lines
I just resubmitted the patch and made sure to send it in plaintext. Hopefully, it will work this time.
That's not the problem.
It's still corrupted.
Your email client is formatting the text, and this makes the patch unusable. Specifically, the last line of the patch should have just a single space, but your mail client remove that space and turned it into an empty line.
Please read the Documentation/email-clients.txt file, and it should be able to show you how to do this properly.
Thank you.