drm/rockchip: Add implicit fencing support for planes
Subsystems (4)
Heiko Stuebner
maintainerPATCH 1/1 drm/rockchip: Add implicit fencing support for planes
Render like lima will attach a fence to the framebuffer dma_buf, so the display driver should wait for it to finish before showing the framebufferto prevent tearing.
Generally tested on rk3188, rk3288, rk3328 and rk3399 and together with an actual lima-based kmscube on rk3188 and rk3328.
--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +2 -0
@@ -18,6 +18,7 @@#include <drm/drm_crtc.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_flip_work.h> +#include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_plane_helper.h> #ifdef CONFIG_DRM_ANALOGIX_DP #include <drm/bridge/analogix_dp.h>
@@ -823,6 +824,7 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = { .atomic_check = vop_plane_atomic_check, .atomic_update = vop_plane_atomic_update, .atomic_disable = vop_plane_atomic_disable, + .prepare_fb = drm_gem_fb_prepare_fb, };static const struct drm_plane_funcs vop_plane_funcs = {
Signature · 6 lines
2.18.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 27 lines · Heiko Stuebner
Render like lima will attach a fence to the framebuffer
dma_buf, so the display driver should wait for it to finish before showing the framebufferto prevent tearing.Generally tested on rk3188, rk3288, rk3328 and rk3399 and together with an actual lima-based kmscube on rk3188 and rk3328.
Suggested-by Qiang Yu <[email protected]>Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1
-0@@ -18,6 +18,7 @@#include <drm/drm_crtc.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_flip_work.h> +#include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_plane_helper.h> #ifdef CONFIG_DRM_ANALOGIX_DP #include <drm/bridge/analogix_dp.h>
drivers/gpu/drm/rockchip/rockchip_drm_vop.c static const struct drm_plane_helper_funcs plane_helper_funcs = { · line 830
Quoted 7 lines
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1
-0@@ -823,6 +824,7 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = { .atomic_check = vop_plane_atomic_check, .atomic_update = vop_plane_atomic_update, .atomic_disable = vop_plane_atomic_disable, + .prepare_fb = drm_gem_fb_prepare_fb, };static const struct drm_plane_funcs vop_plane_funcs = {
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am Freitag, 30. November 2018, 11:24:49 CET schrieb Heiko Stuebner:
Quoted 9 lines
Render like lima will attach a fence to the framebuffer
dma_buf, so the display driver should wait for it to finish before showing the framebufferto prevent tearing.Generally tested on rk3188, rk3288, rk3328 and rk3399 and together with an actual lima-based kmscube on rk3188 and rk3328.
Suggested-by Qiang Yu <[email protected]>Signed-off-by Heiko Stuebner <[email protected]>
applied to drm-misc-next with Neils Reviewed-by
Thanks
Heiko
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel