Skip to contentSkip to conversation

powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default

PATCH Applied Thomas Huth 5 participants 6 messages Feb 11, 2019 – Apr 21, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default

Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.

---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/configs/pseries_defconfig +1 -0
index ea79c51..62e12f6 100644
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m
 CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=m
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <[email protected]> wrote:

Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.

Wow, we didn't before? That's bonkers.

Quoted 19 lines
---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/configs/pseries_defconfig +1 -0
index ea79c51..62e12f6 100644
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m
 CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=m
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
Signature · 1 line
1.8.3.1
Signature · 2 lines
David Gibson <[email protected]>
Principal Software Engineer, Virtualization, Red Hat
#2 lore raw
Quoted 21 lines · David Gibson
Quoted 9 lines · On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <[email protected]> wrote:

Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.

Wow, we didn't before? That's bonkers.

Quoted 4 lines
---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines
Quoted 14 lines
arch/powerpc/configs/pseries_defconfig +1 -0
index ea79c51..62e12f6 100644
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m
 CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=m
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
Signature · 1 line
1.8.3.1

Ping?

Thomas

#3 lore raw
Quoted 22 lines · Thomas Huth
Quoted 21 lines · David Gibson
Quoted 9 lines · On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <[email protected]> wrote:

Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.

Wow, we didn't before? That's bonkers.

Quoted 4 lines
---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 6 lines
Quoted 6 lines
arch/powerpc/configs/pseries_defconfig +0 -0
index ea79c51..62e12f6 100644
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m
 CONFIG_USB_EHCI_HCD=y
Quoted 8 lines
Quoted 8 lines
arch/powerpc/configs/pseries_defconfig +1 -0
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=m
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
Signature · 1 line
1.8.3.1

Ping?

Sorry, will pick it up.

cheers

Acked-by on v1 1/1
#4 lore raw
In reply to Thomas Huth
Quoted 5 lines · Thomas Huth

Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

"recent" :D

Quoted 4 lines

So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.

Quoted 19 lines
---
 arch/powerpc/configs/pseries_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/configs/pseries_defconfig +1 -1
index ea79c51..62e12f6 100644
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m
 CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=m
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
--

1.8.3.1

#5 lore raw
In reply to Thomas Huth
Quoted 11 lines · Thomas Huth

Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27

So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/24c174bb23ebcbe4c3979855b220513f

cheers