powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
PATCH 1/1 powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.
--- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/configs/pseries_defconfig +1 -0
@@ -217,6 +217,7 @@ CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=y # CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_STORAGE=m CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=m
Signature · 1 line
1.8.3.1
Quoted 9 lines · On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <[email protected]> wrote:
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.
Signed-off-by Thomas Huth <[email protected]>
Wow, we didn't before? That's bonkers.
Quoted 19 lines
--- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)arch/powerpc/configs/pseries_defconfig +1
-0@@ -217,6 +217,7 @@ CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=y # CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_STORAGE=m CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=mSignature · 1 line
1.8.3.1
Signature · 2 lines
David Gibson <[email protected]> Principal Software Engineer, Virtualization, Red Hat
Quoted 21 lines · David Gibson
Quoted 9 lines · On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <[email protected]> wrote:
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.
Signed-off-by Thomas Huth <[email protected]>Wow, we didn't before? That's bonkers.
Reviewed-by David Gibson <[email protected]>Quoted 4 lines
--- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 14 lines
Quoted 14 lines
arch/powerpc/configs/pseries_defconfig +1
-0@@ -217,6 +217,7 @@ CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=y # CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_STORAGE=m CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=mSignature · 1 line
1.8.3.1
Ping?
Thomas
Michael Ellerman
reviewerQuoted 22 lines · Thomas Huth
Quoted 21 lines · David Gibson
Quoted 9 lines · On Mon, 11 Feb 2019 12:37:12 +0100 Thomas Huth <[email protected]> wrote:
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.
Signed-off-by Thomas Huth <[email protected]>Wow, we didn't before? That's bonkers.
Reviewed-by David Gibson <[email protected]>Quoted 4 lines
--- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 6 lines
Quoted 6 lines
arch/powerpc/configs/pseries_defconfig +0
-0@@ -217,6 +217,7 @@ CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=yQuoted 8 lines
Quoted 8 lines
arch/powerpc/configs/pseries_defconfig +1
-0# CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_STORAGE=m CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=mSignature · 1 line
1.8.3.1Ping?
Sorry, will pick it up.
cheers
Quoted 5 lines · Thomas Huth
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
"recent" :D
Quoted 4 lines
So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.
Signed-off-by Thomas Huth <[email protected]>
Quoted 19 lines
--- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)arch/powerpc/configs/pseries_defconfig +1
-1@@ -217,6 +217,7 @@ CONFIG_USB_MON=m CONFIG_USB_EHCI_HCD=y # CONFIG_USB_EHCI_HCD_PPC_OF is not set CONFIG_USB_OHCI_HCD=y +CONFIG_USB_XHCI_HCD=y CONFIG_USB_STORAGE=m CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=m --1.8.3.1
Michael Ellerman
AppliedQuoted 11 lines · Thomas Huth
Recent versions of QEMU provide a XHCI device by default these days instead of an old-fashioned OHCI device:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
So to get the keyboard working in the graphical console there again, we should now include XHCI support in the kernel by default, too.
Signed-off-by Thomas Huth <[email protected]>Reviewed-by David Gibson <[email protected]>Acked-by Joel Stanley <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/24c174bb23ebcbe4c3979855b220513f
cheers