staging: android: ion: Use low_order_gfp_flags for smaller allocations
PATCH 1/1 staging: android: ion: Use low_order_gfp_flags for smaller allocations
gfp_flags is always set high_order_gfp_flags even if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory.
--- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ion/ion_system_heap.c +1 -1
@@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)static int ion_system_heap_create_pools (struct ion_page_pool **pools) {int i; -gfp_t gfp_flags = low_order_gfp_flags;for (i =0 ; i <NUM_ORDERS ; i++) {struct ion_page_pool *pool; +gfp_t gfp_flags = low_order_gfp_flags;if (orders[i] >4 ) gfp_flags = high_order_gfp_flags;
Signature · 1 line
1.9.1
Quoted 19 lines · Jing Xia
gfp_flagsis always sethigh_order_gfp_flagseven if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory.Signed-off-by Jing Xia <[email protected]>Reviewed-by Yuming Han <[email protected]>Reviewed-by Zhaoyang Huang <[email protected]>Reviewed-by Orson Zhai <[email protected]>--- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ion/ion_system_heap.c +0
-0@@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)static int ion_system_heap_create_pools (struct ion_page_pool **pools)
drivers/staging/android/ion/ion_system_heap.c static void ion_system_heap_destroy_pools(struct ion_page_pool **pools) · line 232
Quoted 10 lines
drivers/staging/android/ion/ion_system_heap.c +1
-1{int i; -gfp_t gfp_flags = low_order_gfp_flags;for (i =0 ; i <NUM_ORDERS ; i++) {struct ion_page_pool *pool; +gfp_t gfp_flags = low_order_gfp_flags;if (orders[i] >4 ) gfp_flags = high_order_gfp_flags;
This was already submitted in
https://lore.kernel.org/lkml/[email protected]/T/#u
(I'm also very behind on Ion e-mail and need to catch up...)
Laura
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks.
Quoted 37 lines · Laura Abbott
Quoted 19 lines · Jing Xia
gfp_flagsis always sethigh_order_gfp_flagseven if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory.Signed-off-by Jing Xia <[email protected]>Reviewed-by Yuming Han <[email protected]>Reviewed-by Zhaoyang Huang <[email protected]>Reviewed-by Orson Zhai <[email protected]>--- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ion/ion_system_heap.c +0
-0@@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)static int ion_system_heap_create_pools (struct ion_page_pool **pools)drivers/staging/android/ion/ion_system_heap.c static void ion_system_heap_destroy_pools(struct ion_page_pool **pools) · line 232
Quoted 10 lines
drivers/staging/android/ion/ion_system_heap.c +1
-1{int i; -gfp_t gfp_flags = low_order_gfp_flags;for (i =0 ; i <NUM_ORDERS ; i++) {struct ion_page_pool *pool; +gfp_t gfp_flags = low_order_gfp_flags;if (orders[i] >4 ) gfp_flags = high_order_gfp_flags;This was already submitted in
https://lore.kernel.org/lkml/[email protected]/T/#u
(I'm also very behind on Ion e-mail and need to catch up...)Laura