Skip to contentSkip to conversation

arm64: Use _rcuidle for smp_cross_call() tracepoints

PATCH In review Mars Cheng 2 participants 2 messages Feb 12, 2019 – Feb 13, 2019

Subsystems (2)
lore
Share & tools
lore

Mars Cheng

author
#0 lore raw

PATCH 1/1 arm64: Use _rcuidle for smp_cross_call() tracepoints

fix similar issue for aarch64 as the commit 7c64cc0531fa ("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed in aarch32

---
 arch/arm64/kernel/smp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/smp.c +1 -1
index 1598d6f..c1cf8f9 100644
@@ -758,7 +758,7 @@ void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int))
 
 static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
 {
-	trace_ipi_raise(target, ipi_types[ipinr]);
+	trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
 	__smp_cross_call(target, ipinr);
 }
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 3 lines · Mars Cheng

fix similar issue for aarch64 as the commit 7c64cc0531fa ("arm: Use _rcuidle for smp_cross_call() tracepoints") fixed in aarch32

I'm not convinced about this justification. As far as I can tell, the commit mentioned above fixed a cross-call from the idle path as a result of ARCH_NEEDS_CPU_IDLE_COUPLED, but this never appears to be selected on arm64 afaict.

Are you actually seeing a problem on arm64 in practice?

Will