iio/gyro/bmg160: Use millidegrees for temperature scale
PATCH 1/1 iio/gyro/bmg160: Use millidegrees for temperature scale
Standard unit for temperature is millidegrees Celcius, whereas this driver was reporting in degrees. Fix the scale factor in the driver.
--- drivers/iio/gyro/bmg160_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/gyro/bmg160_core.c +3 -2
@@ -585,8 +585,9 @@ static int bmg160_read_raw(struct iio_dev *indio_dev, *val =0 ;switch (chan->type) {case IIO_TEMP : - *val2 =500000 ; -return IIO_VAL_INT_PLUS_MICRO ; + *val =500 ; + *val2 =0 ; +return IIO_VAL_INT ;case IIO_ANGL_VEL : {int i;
Signature · 1 line
1.9.1
Quoted 13 lines · Mike Looijmans
Standard unit for temperature is millidegrees Celcius, whereas this driver was reporting in degrees. Fix the scale factor in the driver.
Signed-off-by Mike Looijmans <[email protected]>--- drivers/iio/gyro/bmg160_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/gyro/bmg160_core.c +0
-0
drivers/iio/gyro/bmg160_core.c static int bmg160_read_raw(struct iio_dev *indio_dev, · line 590
Quoted 8 lines
drivers/iio/gyro/bmg160_core.c +3
-2@@ -585,8 +585,9 @@ static int bmg160_read_raw(struct iio_dev *indio_dev, *val =0 ;switch (chan->type) {case IIO_TEMP : - *val2 =500000 ; -return IIO_VAL_INT_PLUS_MICRO ; + *val =500 ; + *val2 =0 ; +return IIO_VAL_INT ;
You are returning integer type to iio so there's no point in touching val2. iio will ignore it anyway.
Quoted 6 lines
drivers/iio/gyro/bmg160_core.c +0
-1case IIO_ANGL_VEL : {int i; --1.9.1
Quoted 9 lines · Tomasz Duszynski
Quoted 8 lines · Mike Looijmans
Standard unit for temperature is millidegrees Celcius, whereas this driver was reporting in degrees. Fix the scale factor in the driver.
Signed-off-by Mike Looijmans <[email protected]>--- drivers/iio/gyro/bmg160_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 16 lines
drivers/iio/gyro/bmg160_core.c static int bmg160_read_raw(struct iio_dev *indio_dev, · line 590
Quoted 13 lines
drivers/iio/gyro/bmg160_core.c +3
-2@@ -585,8 +585,9 @@ static int bmg160_read_raw(struct iio_dev *indio_dev, *val =0 ;switch (chan->type) {case IIO_TEMP : - *val2 =500000 ; -return IIO_VAL_INT_PLUS_MICRO ; + *val =500 ; + *val2 =0 ; +return IIO_VAL_INT ;You are returning integer type to iio so there's no point in touching val2. iio will ignore it anyway.
Indeed, I'll post a v2 for that.
Quoted 7 lines
Quoted 7 lines
drivers/iio/gyro/bmg160_core.c +0
-1case IIO_ANGL_VEL : {int i; --1.9.1
PATCH v2 1/1 iio/gyro/bmg160: Use millidegrees for temperature scale
In reply to Mike LooijmansStandard unit for temperature is millidegrees Celcius, whereas this driver was reporting in degrees. Fix the scale factor in the driver.
---
v2: Don't touch val2 when returning IIO_VAL_INT
Only touch val when returning a value
drivers/iio/gyro/bmg160_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/gyro/bmg160_core.c +3 -3
@@ -582,11 +582,10 @@ static int bmg160_read_raw(struct iio_dev *indio_dev,case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY :return bmg160_get_filter (data, val);case IIO_CHAN_INFO_SCALE : - *val =0 ;switch (chan->type) {case IIO_TEMP : - *val2 =500000 ; -return IIO_VAL_INT_PLUS_MICRO ; + *val =500 ; +return IIO_VAL_INT ;case IIO_ANGL_VEL : {int i;
@@ -594,6 +593,7 @@ static int bmg160_read_raw(struct iio_dev *indio_dev,for (i =0 ; i <ARRAY_SIZE (bmg160_scale_table); ++i) {if (bmg160_scale_table[i].dps_range == data->dps_range) { + *val =0 ; *val2 = bmg160_scale_table[i].scale;return IIO_VAL_INT_PLUS_MICRO ; }
Signature · 1 line
1.9.1
Quoted 4 lines · On Wed, 13 Feb 2019 08:41:47 +0100 Mike Looijmans <[email protected]>…
Standard unit for temperature is millidegrees Celcius, whereas this driver was reporting in degrees. Fix the scale factor in the driver.
Signed-off-by Mike Looijmans <[email protected]>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
Quoted 33 lines
---
v2: Don't touch val2 when returningIIO_VAL_INT
Only touch val when returning a valuedrivers/iio/gyro/bmg160_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/iio/gyro/bmg160_core.c +3
-3@@ -582,11 +582,10 @@ static int bmg160_read_raw(struct iio_dev *indio_dev,case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY :return bmg160_get_filter (data, val);case IIO_CHAN_INFO_SCALE : - *val =0 ;switch (chan->type) {case IIO_TEMP : - *val2 =500000 ; -return IIO_VAL_INT_PLUS_MICRO ; + *val =500 ; +return IIO_VAL_INT ;case IIO_ANGL_VEL : {int i;@@ -594,6 +593,7 @@ static int bmg160_read_raw(struct iio_dev *indio_dev,for (i =0 ; i <ARRAY_SIZE (bmg160_scale_table); ++i) {if (bmg160_scale_table[i].dps_range == data->dps_range) { + *val =0 ; *val2 = bmg160_scale_table[i].scale;return IIO_VAL_INT_PLUS_MICRO ; }