Skip to contentSkip to conversation

net: atheros: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

PATCH Applied Yang Wei 2 participants 2 messages Feb 12, 2019 – Feb 14, 2019

Subsystems (3)
lore
Share & tools
lore

Yang Wei

author
#0 lore raw

PATCH 1/1 net: atheros: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

From: Yang Wei <[email protected]>

dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.

---
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 +-
 drivers/net/ethernet/atheros/atlx/atl1.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/atheros/atl1e/atl1e_main.c +1 -1
index 3164aad..9dfe6a9 100644
@@ -1259,7 +1259,7 @@ static bool atl1e_clean_tx_irq(struct atl1e_adapter *adapter)
 		}
 
 		if (tx_buffer->skb) {
-			dev_kfree_skb_irq(tx_buffer->skb);
+			dev_consume_skb_irq(tx_buffer->skb);
 			tx_buffer->skb = NULL;
 		}
 
drivers/net/ethernet/atheros/atlx/atl1.c +1 -1
index 63edc57..9e07b469 100644
@@ -2088,7 +2088,7 @@ static int atl1_intr_tx(struct atl1_adapter *adapter)
 		}
 
 		if (buffer_info->skb) {
-			dev_kfree_skb_irq(buffer_info->skb);
+			dev_consume_skb_irq(buffer_info->skb);
 			buffer_info->skb = NULL;
 		}
 
Signature · 1 line
2.7.4