Add Colorspace connector property interface
Subsystems (3)
v16 cover Add Colorspace connector property interface
This patch series creates a new connector property to program colorspace to sink devices. Modern sink devices support more than 1 type of colorspace like 601, 709, BT2020 etc. This helps to switch based on content type which is to be displayed. The decision lies with compositors as to in which scenarios, a particular colorspace will be picked.
This will be helpful mostly to switch to higher gamut colorspaces like BT2020 when the media content is encoded as BT2020. Thereby giving a good visual experience to users.
The expectation from userspace is that it should parse the EDID and get supported colorspaces. Use this property and switch to the one supported. Sink supported colorspaces should be retrieved by userspace from EDID and driver will not explicitly expose them.
Basically the expectation from userspace is:
- Set up CRTC DEGAMMA/CTM/GAMMA to convert to some sink colorspace
- Set this new property to let the sink know what it converted the CRTC output to.
- This property is just to inform sink what colorspace source is trying to drive.
Have tested this using xrandr by using below command:
xrandr --output HDMI2 --set "Colorspace" "BT2020_rgb"
v2: Addressed Ville and Maarten's review comments. Merged the 2nd and 3rd patch into one common logical patch.
v3: Removed Adobe references from enum definitions as per Ville, Hans Verkuil and Jonas Karlman suggestions. Changed default to an unset state where driver will assign the colorspace when not chosen by user, suggested by Ville and Maarten. Addressed other misc review comments from Maarten. Split the changes to have separate colorspace property for DP and HDMI.
v4: Addressed Chris and Ville's review comments, and created a common colorspace property for DP and HDMI, filtered the list
v5: Modified the colorspace property creation helper to take platform specific enum list based on the capabilities of the platform as suggested by Shashank. With this there is no need for segregation between DP and HDMI.
v6: Addressed Shashank's review comments.
v7: Added defines instead of enum in uapi as per Brian Starkey's suggestion in order to go with string matching at userspace. Updated the kernel doc as well with more details.
v8: Addressed Maarten's review comments.
v9: Removed macro defines from uapi as per Brian Starkey and Daniel Stone's comments and moved to drm include file. Moved back to older design with exposing all HDMI colorspaces to userspace since infoframe capability is there even on legacy platforms, as per Ville's review comments.
v10: Addressed Maarten' review comment, updated the RB from Maarten and Jani Nikula's ack. Also fixed sparse warnings and checkpatch complaints.
v11: Addressed Ville's review comments. Modified MACRO names, added infoframe helper for colorspace to drm layer. Added DCI-P3 colorspace macro definitions defined in CTA 861.G. Currently linux/hdmi lacks support for ACE formats, will be added as a separate series.
v12: Exported the helper API.
v13: As per Ville's suggestion, added separate CTA 861.G spec defined HDMI specific macros. This is separate from user exposed enum values. Fixed some macro naming inconsistencies.
v14: Appended BT709 and SMPTE 170M with YCC information as per Ville's review comment to be clear and not to be confused with RGB. Added a check to allow only RGB colorspaces to be set in infoframe through the colorspace property, since there is no output csc property to control planar formats and it will be added later.
v15: Fixed an error in one of the if check.
v16: Added bit wise macro for various fields of colorimetry for easier understanding and review as per Ville's comments. Moved the same out of header file to avoid any namespace issues. Dropped the check for planar vs RGB and allow all the colorspaces.
Uma Shankar (4):
drm: Add HDMI colorspace property
drm: Add DP colorspace property
drm: Add colorspace info to AVI Infoframe drm/i915: Attach colorspace property and enable modeset
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ drivers/gpu/drm/drm_connector.c | 104 +++++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_edid.c | 66 +++++++++++++++++++++ drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_connector.c | 8 +++ drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 13 +++++ include/drm/drm_connector.h | 49 ++++++++++++++++ include/drm/drm_edid.h | 6 ++ 9 files changed, 252 insertions(+)
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v16 1/4 drm: Add HDMI colorspace property
Create a new connector property to program colorspace to sink devices. Modern sink devices support more than 1 type of colorspace like 601, 709, BT2020 etc. This helps to switch based on content type which is to be displayed. The decision lies with compositors as to in which scenarios, a particular colorspace will be picked.
This will be helpful mostly to switch to higher gamut colorspaces like BT2020 when the media content is encoded as BT2020. Thereby giving a good visual experience to users.
The expectation from userspace is that it should parse the EDID and get supported colorspaces. Use this property and switch to the one supported. Sink supported colorspaces should be retrieved by userspace from EDID and driver will not explicitly expose them.
Basically the expectation from userspace is:
- Set up CRTC DEGAMMA/CTM/GAMMA to convert to some sink colorspace
- Set this new property to let the sink know what it converted the CRTC output to.
v2: Addressed Maarten and Ville's review comments. Enhanced the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.
v3: Removed Adobe references from enum definitions as per Ville, Hans Verkuil and Jonas Karlman suggestions. Changed Default to an unset state where driver will assign the colorspace is not chosen by user, suggested by Ville and Maarten. Addressed other misc review comments from Maarten. Split the changes to have separate colorspace property for DP and HDMI.
v4: Addressed Chris and Ville's review comments, and created a common colorspace property for DP and HDMI, filtered the list based on the colorspaces supported by the respective protocol standard.
v5: Made the property creation helper accept enum list based on platform capabilties as suggested by Shashank. Consolidated HDMI and DP property creation in the common helper.
v6: Addressed Shashank's review comments.
v7: Added defines instead of enum in uapi as per Brian Starkey's suggestion in order to go with string matching at userspace. Updated the commit message to add more details as well kernel docs.
v8: Addressed Maarten's review comments.
v9: Removed macro defines from uapi as per Brian Starkey and Daniel Stone's comments and moved to drm include file. Moved back to older design with exposing all HDMI colorspaces to userspace since infoframe capability is there even on legacy platforms, as per Ville's review comments.
v10: Fixed sparse warnings, updated the RB from Maarten and Jani's ack.
v11: Addressed Ville's review comments. Updated the Macro naming and added DCI-P3 colorspace as well, defined in CTA 861.G spec.
v12: Appended BT709 and SMPTE 170M with YCC information as per Ville's review comment to be clear and not to be confused with RGB.
v13: Reorder the colorspace macros.
--- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ drivers/gpu/drm/drm_connector.c | 78 +++++++++++++++++++++++++++++++++++++++ include/drm/drm_connector.h | 49 ++++++++++++++++++++++++ 3 files changed, 131 insertions(+)
drivers/gpu/drm/drm_atomic_uapi.c +4 -0
@@ -746,6 +746,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,return -EINVAL ; } state->content_protection = val; + }else if (property == connector->colorspace_property) { + state->colorspace = val; }else if (property == config->writeback_fb_id_property) {struct drm_framebuffer *fb =drm_framebuffer_lookup (dev,NULL , val);int ret =drm_atomic_set_writeback_fb_for_connector (state, fb);
@@ -814,6 +816,8 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector, *val = state->picture_aspect_ratio; }else if (property == config->content_type_property) { *val = state->content_type; + }else if (property == connector->colorspace_property) { + *val = state->colorspace; }else if (property == connector->scaling_mode_property) { *val = state->scaling_mode; }else if (property == connector->content_protection_property) {
drivers/gpu/drm/drm_connector.c +78 -0
90 lines not on this page · raw message
include/drm/drm_connector.h +49 -0
73 lines not on this page · raw message
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v16 2/4 drm: Add DP colorspace property
In reply to Uma Shankar via dri-develThis patch adds a DP colorspace property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces.
v2: Addressed Maarten and Ville's review comments. Enhanced
the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.
v3: Split the changes to have separate colorspace property for DP and HDMI.
v4: Addressed Chris and Ville's review comments, and created a common colorspace property for DP and HDMI, filtered the list based on the colorspaces supported by the respective protocol standard.
v5: Merged the DP handling along with platform colorspace handling as per Shashank's comments.
v6: Reverted to old design of exposing all colorspaces to userspace as per Ville's review comment
v7: Fixed sparse warnings, updated the RB from Maarten and Jani's ack.
v8: Addressed Ville's review comments and updated the colorspace macro definitions.
--- drivers/gpu/drm/drm_connector.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/drm_connector.c +26 -0
@@ -853,6 +853,24 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info, { DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, "DCI-P3_RGB_Theater" }, }; +static const struct drm_prop_enum_list dp_colorspaces[] = { +/* For Default case, driver will set the colorspace */ + {DRM_MODE_COLORIMETRY_DEFAULT ,"Default" }, +/* Standard Definition Colorimetry based on IEC 61966-2-4 */ + {DRM_MODE_COLORIMETRY_XVYCC_601 ,"XVYCC_601" }, +/* High Definition Colorimetry based on IEC 61966-2-4 */ + {DRM_MODE_COLORIMETRY_XVYCC_709 ,"XVYCC_709" }, +/* Colorimetry based on IEC 61966-2-5 */ + {DRM_MODE_COLORIMETRY_OPRGB ,"opRGB" }, + {DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65 ,"DCI-P3_RGB_D65" }, +/* DP MSA Colorimetry */ + {DRM_MODE_DP_COLORIMETRY_BT601_YCC ,"BT601_YCC" }, + {DRM_MODE_DP_COLORIMETRY_BT709_YCC ,"BT709_YCC" }, + {DRM_MODE_DP_COLORIMETRY_SRGB ,"sRGB" }, + {DRM_MODE_DP_COLORIMETRY_RGB_WIDE_GAMUT ,"RGB Wide Gamut" }, + {DRM_MODE_DP_COLORIMETRY_SCRGB ,"scRGB" }, +}; +/** * DOC: standard connector properties *
@@ -1614,6 +1632,14 @@ int drm_mode_create_colorspace_property(struct drm_connector *connector) ARRAY_SIZE(hdmi_colorspaces));if (!prop)return -ENOMEM ; + }else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) { + prop =drm_property_create_enum (dev,DRM_MODE_PROP_ENUM , +"Colorspace" , dp_colorspaces, +ARRAY_SIZE (dp_colorspaces)); + +if (!prop) +return -ENOMEM ; }else {DRM_DEBUG_KMS ("Colorspace property not supported\n" );return 0 ;
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [v16 2/4] drm: Add DP colorspace property
Quoted 49 lines · Uma Shankar
This patch adds a DP colorspace property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces.
v2: Addressed Maarten and Ville's review comments. Enhanced
the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.v3: Split the changes to have separate colorspace property for DP and HDMI.
v4: Addressed Chris and Ville's review comments, and created a common colorspace property for DP and HDMI, filtered the list based on the colorspaces supported by the respective protocol standard.
v5: Merged the DP handling along with platform colorspace handling as per Shashank's comments.
v6: Reverted to old design of exposing all colorspaces to userspace as per Ville's review comment
v7: Fixed sparse warnings, updated the RB from Maarten and Jani's ack.
v8: Addressed Ville's review comments and updated the colorspace macro definitions.
Signed-off-by Uma Shankar <[email protected]>Acked-by Jani Nikula <[email protected]>Reviewed-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/drm_connector.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/drm_connector.c +7
-0@@ -853,6 +853,24 @@ int drm_display_info_set_bus_formats(struct drm_display_info *info, { DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, "DCI-P3_RGB_Theater" }, }; +static const struct drm_prop_enum_list dp_colorspaces[] = { +/* For Default case, driver will set the colorspace */ + {DRM_MODE_COLORIMETRY_DEFAULT ,"Default" }, +/* Standard Definition Colorimetry based on IEC 61966-2-4 */ + {DRM_MODE_COLORIMETRY_XVYCC_601 ,"XVYCC_601" }, +/* High Definition Colorimetry based on IEC 61966-2-4 */ + { DRM_MODE_COLORIMETRY_XVYCC_709, "XVYCC_709" },
drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct drm_display_info *info, · line 872
Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10
-0+/* Colorimetry based on IEC 61966-2-5 */ + { DRM_MODE_COLORIMETRY_OPRGB, "opRGB" }, + { DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, "DCI-P3_RGB_D65" }, +/* DP MSA Colorimetry */ + { DRM_MODE_DP_COLORIMETRY_BT601_YCC, "BT601_YCC" }, + { DRM_MODE_DP_COLORIMETRY_BT709_YCC, "BT709_YCC" }, + { DRM_MODE_DP_COLORIMETRY_SRGB, "sRGB" }, + { DRM_MODE_DP_COLORIMETRY_RGB_WIDE_GAMUT, "RGB Wide Gamut" }, + { DRM_MODE_DP_COLORIMETRY_SCRGB, "scRGB" }, +};
I think we should postpone this patch (and the DP related bits in the previous patch) until we have the implementation done. Ie. let's just get HDMI working initially.
Quoted 26 lines
drivers/gpu/drm/drm_connector.c +9
-0+/** * DOC: standard connector properties * @@ -1614,6 +1632,14 @@ int drm_mode_create_colorspace_property(struct drm_connector *connector) ARRAY_SIZE(hdmi_colorspaces));if (!prop)return -ENOMEM ; + }else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) { + prop =drm_property_create_enum (dev,DRM_MODE_PROP_ENUM , +"Colorspace" , dp_colorspaces, +ARRAY_SIZE (dp_colorspaces)); + +if (!prop) +return -ENOMEM ; }else {DRM_DEBUG_KMS ("Colorspace property not supported\n" );return 0 ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
RE: [Intel-gfx] [v16 2/4] drm: Add DP colorspace property
Quoted 70 lines
-----Original Message-----
From: Ville Syrjälä [mailto:[email protected]]
Sent: Tuesday, February 19, 2019 1:39 AM
To: Shankar, Uma <[email protected]>
Cc: [email protected]; [email protected]; Syrjala, Ville <[email protected]>; Lankhorst, Maarten <[email protected]>
Subject: Re: [Intel-gfx] [v16 2/4] drm: Add DP colorspace propertydrivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct
Quoted 38 lines · Uma Shankar
This patch adds a DP colorspace property, enabling userspace to switch to various supported colorspaces.
This will help enable BT2020 along with other colorspaces.v2: Addressed Maarten and Ville's review comments. Enhanced
the colorspace enum to incorporate both HDMI and DP supported colorspaces. Also, added a default option for colorspace.v3: Split the changes to have separate colorspace property for DP and HDMI.
v4: Addressed Chris and Ville's review comments, and created a common colorspace property for DP and HDMI, filtered the list based on the colorspaces supported by the respective protocol standard.
v5: Merged the DP handling along with platform colorspace handling as per Shashank's comments.
v6: Reverted to old design of exposing all colorspaces to userspace as per Ville's review comment
v7: Fixed sparse warnings, updated the RB from Maarten and Jani's ack.
v8: Addressed Ville's review comments and updated the colorspace macro definitions.
Signed-off-by Uma Shankar <[email protected]>Acked-by Jani Nikula <[email protected]>Reviewed-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/drm_connector.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/drm_connector.cindex 07d65a1..5473bea 100644drivers/gpu/drm/drm_connector.c +0
-0@@ -853,6 +853,24 @@ int drm_display_info_set_bus_formats(struct
drm_display_info*info,drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct · line 853
Quoted 1 line
drivers/gpu/drm/drm_connector.c +0
-0{ DRM_MODE_COLORIMETRY_DCI_P3_RGB_THEATER, "DCI-
P3_RGB_Theater" },Quoted 7 lines
drivers/gpu/drm/drm_connector.c +5
-0}; +static const struct drm_prop_enum_list dp_colorspaces[] = { +/* For Default case, driver will set the colorspace */ + {DRM_MODE_COLORIMETRY_DEFAULT ,"Default" }, +/* Standard Definition Colorimetry based on IEC 61966-2-4 */ + {DRM_MODE_COLORIMETRY_XVYCC_601 ,"XVYCC_601" },drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct drm_display_info *info,
Quoted 10 lines
drivers/gpu/drm/drm_connector.c +10
-0+/* High Definition Colorimetry based on IEC 61966-2-4 */ + { DRM_MODE_COLORIMETRY_XVYCC_709, "XVYCC_709" }, +/* Colorimetry based on IEC 61966-2-5 */ + { DRM_MODE_COLORIMETRY_OPRGB, "opRGB" }, + { DRM_MODE_COLORIMETRY_DCI_P3_RGB_D65, "DCI-P3_RGB_D65" }, +/* DP MSA Colorimetry */ + { DRM_MODE_DP_COLORIMETRY_BT601_YCC, "BT601_YCC" }, + { DRM_MODE_DP_COLORIMETRY_BT709_YCC, "BT709_YCC" }, + { DRM_MODE_DP_COLORIMETRY_SRGB, "sRGB" }, + { DRM_MODE_DP_COLORIMETRY_RGB_WIDE_GAMUT, "RGB Wide Gamut"},
Quoted 4 lines
drivers/gpu/drm/drm_connector.c int drm_display_info_set_bus_formats(struct · line 871
Quoted 1 line
drivers/gpu/drm/drm_connector.c +1
-0+ { DRM_MODE_DP_COLORIMETRY_SCRGB, "scRGB" }, };I think we should postpone this patch (and the DP related bits in the previous patch) until we have the implementation done. Ie. let's just get HDMI working initially.
Sure, will drop this.
Quoted 24 lines
drivers/gpu/drm/drm_connector.c int drm_mode_create_colorspace_property(struct
Quoted 5 lines
drivers/gpu/drm/drm_connector.c +1
-0+/** * DOC: standard connector properties * @@ -1614,6 +1632,14 @@ int drm_mode_create_colorspace_property(struct
drm_connector*connector)drivers/gpu/drm/drm_connector.c int drm_mode_create_colorspace_property(struct drm_connector *connector)
Quoted 5 lines
drivers/gpu/drm/drm_connector.c +2
-0ARRAY_SIZE(hdmi_colorspaces));if (!prop)return -ENOMEM ; + } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==
DRM_MODE_CONNECTOR_DisplayPort) {Quoted 12 lines
drivers/gpu/drm/drm_connector.c +6
-1+ prop =drm_property_create_enum (dev,DRM_MODE_PROP_ENUM , +"Colorspace" , dp_colorspaces, +ARRAY_SIZE (dp_colorspaces)); + +if (!prop) +return -ENOMEM ; }else {DRM_DEBUG_KMS ("Colorspace property not supported\n" );return 0 ; --1.9.1
Quoted 8 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v16 3/4 drm: Add colorspace info to AVI Infoframe
In reply to Uma Shankar via dri-develThis adds colorspace information to HDMI AVI infoframe. A helper function is added to program the same.
v2: Moved this to drm core instead of i915 driver.
v3: Exported the helper function.
v4: Added separate HDMI specific macro as per CTA spec. This is separate from user exposed enum values. This is as per Ville's suggestion.
v5: Appended BT709 and SMPTE 170M with YCC information as per Ville's review comment to be clear and not to be confused with RGB.
v6: Added bit wise macro for various fields of colorimetry for easier understanding and review as per Ville's comments. Moved the same out of header file to avoid any namespace issues.
--- drivers/gpu/drm/drm_edid.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_edid.h | 6 +++++ 2 files changed, 72 insertions(+)
drivers/gpu/drm/drm_edid.c +66 -0
@@ -4924,6 +4924,72 @@ static bool is_hdmi2_sink(struct drm_connector *connector) }EXPORT_SYMBOL (drm_hdmi_avi_infoframe_from_display_mode); +/* HDMI Colorspace Spec Definitions */ +#define FULL_COLORIMETRY_MASK 0x1FF +#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define EXTENDED_ACE_COLORIMETRY_MASK 0xF + +#define C (x) ((x) << 0) +#define EC (x) ((x) << 2) +#define ACE (x) ((x) << 5) + +#define HDMI_COLORIMETRY_NO_DATA 0x0 +#define HDMI_COLORIMETRY_SMPTE_170M_YCC (C(1) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_BT709_YCC (C(2) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_601 (C(3) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_709 (C(3) | EC(1) | ACE(0)) +#define HDMI_COLORIMETRY_SYCC_601 (C(3) | EC(2) | ACE(0)) +#define HDMI_COLORIMETRY_OPYCC_601 (C(3) | EC(3) | ACE(0)) +#define HDMI_COLORIMETRY_OPRGB (C(3) | EC(4) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_CYCC (C(3) | EC(5) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_RGB (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_YCC (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_DCI_P3_RGB_D65 (C(3) | EC(7) | ACE(0)) +#define HDMI_COLORIMETRY_DCI_P3_RGB_THEATER (C(3) | EC(7) | ACE(1)) + +static const u32 hdmi_colorimetry_val[] = { + [DRM_MODE_COLORIMETRY_NO_DATA ] =HDMI_COLORIMETRY_NO_DATA , + [DRM_MODE_COLORIMETRY_SMPTE_170M_YCC ] =HDMI_COLORIMETRY_SMPTE_170M_YCC , + [DRM_MODE_COLORIMETRY_BT709_YCC ] =HDMI_COLORIMETRY_BT709_YCC , + [DRM_MODE_COLORIMETRY_XVYCC_601 ] =HDMI_COLORIMETRY_XVYCC_601 , + [DRM_MODE_COLORIMETRY_XVYCC_709 ] =HDMI_COLORIMETRY_XVYCC_709 , + [DRM_MODE_COLORIMETRY_SYCC_601 ] =HDMI_COLORIMETRY_SYCC_601 , + [DRM_MODE_COLORIMETRY_OPYCC_601 ] =HDMI_COLORIMETRY_OPYCC_601 , + [DRM_MODE_COLORIMETRY_OPRGB ] =HDMI_COLORIMETRY_OPRGB , + [DRM_MODE_COLORIMETRY_BT2020_CYCC ] =HDMI_COLORIMETRY_BT2020_CYCC , + [DRM_MODE_COLORIMETRY_BT2020_RGB ] =HDMI_COLORIMETRY_BT2020_RGB , + [DRM_MODE_COLORIMETRY_BT2020_YCC ] =HDMI_COLORIMETRY_BT2020_YCC , +}; + +/** +* drm_hdmi_avi_infoframe_colorspace() - fill the HDMI AVI infoframe +* colorspace information +* @frame: HDMI AVI infoframe +* @conn_state: connector state +*/ +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state) +{ +u32 colorimetry_val; +u32 colorimetry_index = conn_state->colorspace &FULL_COLORIMETRY_MASK ; + +if (colorimetry_index >=ARRAY_SIZE (hdmi_colorimetry_val)) + colorimetry_val =HDMI_COLORIMETRY_NO_DATA ; +else + colorimetry_val = hdmi_colorimetry_val[colorimetry_index]; + + frame->colorimetry = colorimetry_val &NORMAL_COLORIMETRY_MASK ; +/* +* ToDo: Extend it for ACE formats as well. Modify the infoframe +* structure and extend it in drivers/video/hdmi +*/ + frame->extended_colorimetry = (colorimetry_val >>2 ) & +EXTENDED_COLORIMETRY_MASK ; +} +EXPORT_SYMBOL (drm_hdmi_avi_infoframe_colorspace); +/** * drm_hdmi_avi_infoframe_quant_range() - fill the HDMI AVI infoframe * quantization range information
include/drm/drm_edid.h +6 -0
@@ -331,6 +331,7 @@ struct cea_sad {struct drm_encoder ;struct drm_connector ; +struct drm_connector_state ;struct drm_display_mode ;int drm_edid_to_sad (struct edid *edid,struct cea_sad **sads);
@@ -358,6 +359,11 @@ int drm_av_sync_delay(struct drm_connector *connector, drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame, struct drm_connector *connector, const struct drm_display_mode *mode); + +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state); + void drm_hdmi_avi_infoframe_quant_range(struct hdmi_avi_infoframe *frame, struct drm_connector *connector,
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v16 3/4] drm: Add colorspace info to AVI Infoframe
Quoted 59 lines · Uma Shankar
This adds colorspace information to HDMI AVI infoframe. A helper function is added to program the same.
v2: Moved this to drm core instead of i915 driver.
v3: Exported the helper function.
v4: Added separate HDMI specific macro as per CTA spec. This is separate from user exposed enum values. This is as per Ville's suggestion.
v5: Appended BT709 and SMPTE 170M with YCC information as per Ville's review comment to be clear and not to be confused with RGB.
v6: Added bit wise macro for various fields of colorimetry for easier understanding and review as per Ville's comments. Moved the same out of header file to avoid any namespace issues.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/drm_edid.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_edid.h | 6 +++++ 2 files changed, 72 insertions(+)drivers/gpu/drm/drm_edid.c +27
-0@@ -4924,6 +4924,72 @@ static bool is_hdmi2_sink(struct drm_connector *connector) }EXPORT_SYMBOL (drm_hdmi_avi_infoframe_from_display_mode); +/* HDMI Colorspace Spec Definitions */ +#define FULL_COLORIMETRY_MASK 0x1FF +#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define EXTENDED_ACE_COLORIMETRY_MASK 0xF + +#define C (x) ((x) << 0) +#define EC (x) ((x) << 2) +#define ACE (x) ((x) << 5) + +#define HDMI_COLORIMETRY_NO_DATA 0x0 +#define HDMI_COLORIMETRY_SMPTE_170M_YCC (C(1) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_BT709_YCC (C(2) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_601 (C(3) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_709 (C(3) | EC(1) | ACE(0)) +#define HDMI_COLORIMETRY_SYCC_601 (C(3) | EC(2) | ACE(0)) +#define HDMI_COLORIMETRY_OPYCC_601 (C(3) | EC(3) | ACE(0)) +#define HDMI_COLORIMETRY_OPRGB (C(3) | EC(4) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_CYCC (C(3) | EC(5) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_RGB (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_YCC (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_DCI_P3_RGB_D65 (C(3) | EC(7) | ACE(0)) +#define HDMI_COLORIMETRY_DCI_P3_RGB_THEATER (C(3) | EC(7) | ACE(1)) + +static const u32 hdmi_colorimetry_val[] = { + [DRM_MODE_COLORIMETRY_NO_DATA ] =HDMI_COLORIMETRY_NO_DATA , + [DRM_MODE_COLORIMETRY_SMPTE_170M_YCC ] =HDMI_COLORIMETRY_SMPTE_170M_YCC ,
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector) · line 4963
Quoted 10 lines
drivers/gpu/drm/drm_edid.c +10
-0+ [DRM_MODE_COLORIMETRY_BT709_YCC] = HDMI_COLORIMETRY_BT709_YCC, + [DRM_MODE_COLORIMETRY_XVYCC_601] = HDMI_COLORIMETRY_XVYCC_601, + [DRM_MODE_COLORIMETRY_XVYCC_709] = HDMI_COLORIMETRY_XVYCC_709, + [DRM_MODE_COLORIMETRY_SYCC_601] = HDMI_COLORIMETRY_SYCC_601, + [DRM_MODE_COLORIMETRY_OPYCC_601] = HDMI_COLORIMETRY_OPYCC_601, + [DRM_MODE_COLORIMETRY_OPRGB] = HDMI_COLORIMETRY_OPRGB, + [DRM_MODE_COLORIMETRY_BT2020_CYCC] = HDMI_COLORIMETRY_BT2020_CYCC, + [DRM_MODE_COLORIMETRY_BT2020_RGB] = HDMI_COLORIMETRY_BT2020_RGB, + [DRM_MODE_COLORIMETRY_BT2020_YCC] = HDMI_COLORIMETRY_BT2020_YCC, +};
Probably best to
#undef C
#undef EC
#undef ACE
here to avoid accidents.
With that
Quoted 63 lines
drivers/gpu/drm/drm_edid.c +29
-0+ +/** +* drm_hdmi_avi_infoframe_colorspace() - fill the HDMI AVI infoframe +* colorspace information +* @frame: HDMI AVI infoframe +* @conn_state: connector state +*/ +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state) +{ +u32 colorimetry_val; +u32 colorimetry_index = conn_state->colorspace &FULL_COLORIMETRY_MASK ; + +if (colorimetry_index >=ARRAY_SIZE (hdmi_colorimetry_val)) + colorimetry_val =HDMI_COLORIMETRY_NO_DATA ; +else + colorimetry_val = hdmi_colorimetry_val[colorimetry_index]; + + frame->colorimetry = colorimetry_val &NORMAL_COLORIMETRY_MASK ; +/* +* ToDo: Extend it for ACE formats as well. Modify the infoframe +* structure and extend it in drivers/video/hdmi +*/ + frame->extended_colorimetry = (colorimetry_val >>2 ) & +EXTENDED_COLORIMETRY_MASK ; +} +EXPORT_SYMBOL (drm_hdmi_avi_infoframe_colorspace); +/** * drm_hdmi_avi_infoframe_quant_range() - fill the HDMI AVI infoframe * quantization range information include/drm/drm_edid.h +6
-0@@ -331,6 +331,7 @@ struct cea_sad {struct drm_encoder ;struct drm_connector ; +struct drm_connector_state ;struct drm_display_mode ;int drm_edid_to_sad (struct edid *edid,struct cea_sad **sads);@@ -358,6 +359,11 @@ int drm_av_sync_delay(struct drm_connector *connector, drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame, struct drm_connector *connector, const struct drm_display_mode *mode); + +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state); + void drm_hdmi_avi_infoframe_quant_range(struct hdmi_avi_infoframe *frame, struct drm_connector *connector,Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [Intel-gfx] [v16 3/4] drm: Add colorspace info to AVI Infoframe
Quoted 96 lines
-----Original Message-----
From: dri-devel [mailto:[email protected]] On Behalf Of Ville Syrjälä
Sent: Tuesday, February 19, 2019 1:37 AM
To: Shankar, Uma <[email protected]>
Cc: [email protected]; Syrjala, Ville <[email protected]>; Lankhorst, Maarten <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [v16 3/4] drm: Add colorspace info to AVI InfoframeQuoted 14 lines · Uma Shankar
This adds colorspace information to HDMI AVI infoframe. A helper function is added to program the same.
v2: Moved this to drm core instead of i915 driver.
v3: Exported the helper function.
v4: Added separate HDMI specific macro as per CTA spec. This is separate from user exposed enum values. This is as per Ville's suggestion.
v5: Appended BT709 and SMPTE 170M with YCC information as per Ville's review comment to be clear and not to be confused with RGB.
Quoted 7 lines
v6: Added bit wise macro for various fields of colorimetry for easier understanding and review as per Ville's comments. Moved the same out of header file to avoid any namespace issues.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/drm_edid.c | 66++++++++++++++++++++++++++++++++++++++++++++++
Quoted 13 lines
include/drm/drm_edid.h | 6 +++++ 2 files changed, 72 insertions(+)drivers/gpu/drm/drm_edid.c +2
-0@@ -4924,6 +4924,72 @@ static bool is_hdmi2_sink(struct drm_connector *connector) }EXPORT_SYMBOL (drm_hdmi_avi_infoframe_from_display_mode); +/* HDMI Colorspace Spec Definitions */ +#define FULL_COLORIMETRY_MASK 0x1FFdrivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4938
Quoted 10 lines
drivers/gpu/drm/drm_edid.c +10
-0+#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define EXTENDED_ACE_COLORIMETRY_MASK 0xF + +#define C (x) ((x) << 0) +#define EC (x) ((x) << 2) +#define ACE (x) ((x) << 5) + +#define HDMI_COLORIMETRY_NO_DATA 0x0 +#define HDMI_COLORIMETRY_SMPTE_170M_YCC (C(1) | EC(0) |ACE(0))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector)
Quoted 6 lines
drivers/gpu/drm/drm_edid.c +6
-0+#define HDMI_COLORIMETRY_BT709_YCC (C(2) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_601 (C(3) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_709 (C(3) | EC(1) | ACE(0)) +#define HDMI_COLORIMETRY_SYCC_601 (C(3) | EC(2) | ACE(0)) +#define HDMI_COLORIMETRY_OPYCC_601 (C(3) | EC(3) | ACE(0)) +#define HDMI_COLORIMETRY_OPRGB (C(3) | EC(4) |ACE(0))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector)
Quoted 4 lines
drivers/gpu/drm/drm_edid.c +4
-0+#define HDMI_COLORIMETRY_BT2020_CYCC (C(3) | EC(5) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_RGB (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_YCC (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_DCI_P3_RGB_D65 (C(3) | EC(7) |ACE(0))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4949
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+#define HDMI_COLORIMETRY_DCI_P3_RGB_THEATER (C(3) | EC(7) |ACE(1))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector)
Quoted 3 lines
drivers/gpu/drm/drm_edid.c +3
-0+ +static const u32 hdmi_colorimetry_val[] = { + [DRM_MODE_COLORIMETRY_NO_DATA] =
HDMI_COLORIMETRY_NO_DATA,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4953
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_SMPTE_170M_YCC] =
HDMI_COLORIMETRY_SMPTE_170M_YCC,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4954
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_BT709_YCC] =
HDMI_COLORIMETRY_BT709_YCC,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4955
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_XVYCC_601] =
HDMI_COLORIMETRY_XVYCC_601,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4956
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_XVYCC_709] =
HDMI_COLORIMETRY_XVYCC_709,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4957
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_SYCC_601] =
HDMI_COLORIMETRY_SYCC_601,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4958
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_OPYCC_601] =
HDMI_COLORIMETRY_OPYCC_601,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4960
Quoted 2 lines
drivers/gpu/drm/drm_edid.c +2
-0+ [DRM_MODE_COLORIMETRY_OPRGB] = HDMI_COLORIMETRY_OPRGB, + [DRM_MODE_COLORIMETRY_BT2020_CYCC] =
HDMI_COLORIMETRY_BT2020_CYCC,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4961
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_BT2020_RGB] =
HDMI_COLORIMETRY_BT2020_RGB,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4962
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_BT2020_YCC] =
HDMI_COLORIMETRY_BT2020_YCC, };
Quoted 7 lines
Probably best to
#undef C
#undef EC
#undef ACEhere to avoid accidents.
Sure will add that. So with this fixed and DP stuff dropped, can I mark your RB on all the remaining 2 patches (DP patch will get dropped). If you confirm will resend with your RB for merge.
Thanks & Regards,
Uma Shankar
Quoted 64 lines
With that
Reviewed-by Ville Syrjälä <[email protected]>Quoted 45 lines
drivers/gpu/drm/drm_edid.c +29
-0+ +/** +* drm_hdmi_avi_infoframe_colorspace() - fill the HDMI AVI infoframe +* colorspace information +* @frame: HDMI AVI infoframe +* @conn_state: connector state +*/ +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state) { +u32 colorimetry_val; +u32 colorimetry_index = conn_state->colorspace & +FULL_COLORIMETRY_MASK ; + +if (colorimetry_index >=ARRAY_SIZE (hdmi_colorimetry_val)) + colorimetry_val =HDMI_COLORIMETRY_NO_DATA ; +else + colorimetry_val = hdmi_colorimetry_val[colorimetry_index]; + + frame->colorimetry = colorimetry_val &NORMAL_COLORIMETRY_MASK ; +/* +* ToDo: Extend it for ACE formats as well. Modify the infoframe +* structure and extend it in drivers/video/hdmi +*/ + frame->extended_colorimetry = (colorimetry_val >>2 ) & +EXTENDED_COLORIMETRY_MASK ; +} +EXPORT_SYMBOL (drm_hdmi_avi_infoframe_colorspace); +/** * drm_hdmi_avi_infoframe_quant_range() - fill the HDMI AVI infoframe * quantization range information include/drm/drm_edid.h index renamed from include/drm/drm_edid.h +0
-08dc1a08..9d3b5b9 100644
include/drm/drm_edid.h +1
-1@@ -331,6 +331,7 @@ struct cea_sad {struct drm_encoder ;struct drm_connector ; +struct drm_connector_state ;struct drm_display_mode ; int drm_edid_to_sad(struct edid *edid, struct cea_sad **sads); @@ -358,6 +359,11 @@ int drm_av_sync_delay(struct drm_connectorQuoted 1 line
*connector, drm_hdmi_vendor_infoframe_from_display_mode(struct
hdmi_vendor_infoframe*frame,Quoted 13 lines
include/drm/drm_edid.h +5
-1struct drm_connector *connector, const struct drm_display_mode *mode); + +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state); + void drm_hdmi_avi_infoframe_quant_range(struct hdmi_avi_infoframe *frame, struct drm_connector *connector, --1.9.1
Quoted 12 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Intel-gfx] [v16 3/4] drm: Add colorspace info to AVI Infoframe
Quoted 98 lines · Uma
Quoted 98 lines
-----Original Message-----
From: dri-devel [mailto:[email protected]] On Behalf Of Ville Syrjälä
Sent: Tuesday, February 19, 2019 1:37 AM
To: Shankar, Uma <[email protected]>
Cc: [email protected]; Syrjala, Ville <[email protected]>; Lankhorst, Maarten <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [v16 3/4] drm: Add colorspace info to AVI InfoframeQuoted 14 lines · Uma Shankar
This adds colorspace information to HDMI AVI infoframe. A helper function is added to program the same.
v2: Moved this to drm core instead of i915 driver.
v3: Exported the helper function.
v4: Added separate HDMI specific macro as per CTA spec. This is separate from user exposed enum values. This is as per Ville's suggestion.
v5: Appended BT709 and SMPTE 170M with YCC information as per Ville's review comment to be clear and not to be confused with RGB.
Quoted 7 lines
v6: Added bit wise macro for various fields of colorimetry for easier understanding and review as per Ville's comments. Moved the same out of header file to avoid any namespace issues.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/drm_edid.c | 66++++++++++++++++++++++++++++++++++++++++++++++
Quoted 13 lines
include/drm/drm_edid.h | 6 +++++ 2 files changed, 72 insertions(+)drivers/gpu/drm/drm_edid.c +2
-0@@ -4924,6 +4924,72 @@ static bool is_hdmi2_sink(struct drm_connector *connector) }EXPORT_SYMBOL (drm_hdmi_avi_infoframe_from_display_mode); +/* HDMI Colorspace Spec Definitions */ +#define FULL_COLORIMETRY_MASK 0x1FFdrivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4938
Quoted 10 lines
drivers/gpu/drm/drm_edid.c +10
-0+#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define EXTENDED_ACE_COLORIMETRY_MASK 0xF + +#define C (x) ((x) << 0) +#define EC (x) ((x) << 2) +#define ACE (x) ((x) << 5) + +#define HDMI_COLORIMETRY_NO_DATA 0x0 +#define HDMI_COLORIMETRY_SMPTE_170M_YCC (C(1) | EC(0) |ACE(0))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector)
Quoted 6 lines
drivers/gpu/drm/drm_edid.c +6
-0+#define HDMI_COLORIMETRY_BT709_YCC (C(2) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_601 (C(3) | EC(0) | ACE(0)) +#define HDMI_COLORIMETRY_XVYCC_709 (C(3) | EC(1) | ACE(0)) +#define HDMI_COLORIMETRY_SYCC_601 (C(3) | EC(2) | ACE(0)) +#define HDMI_COLORIMETRY_OPYCC_601 (C(3) | EC(3) | ACE(0)) +#define HDMI_COLORIMETRY_OPRGB (C(3) | EC(4) |ACE(0))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector)
Quoted 4 lines
drivers/gpu/drm/drm_edid.c +4
-0+#define HDMI_COLORIMETRY_BT2020_CYCC (C(3) | EC(5) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_RGB (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_BT2020_YCC (C(3) | EC(6) | ACE(0)) +#define HDMI_COLORIMETRY_DCI_P3_RGB_D65 (C(3) | EC(7) |ACE(0))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4949
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+#define HDMI_COLORIMETRY_DCI_P3_RGB_THEATER (C(3) | EC(7) |ACE(1))
drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector *connector)
Quoted 3 lines
drivers/gpu/drm/drm_edid.c +3
-0+ +static const u32 hdmi_colorimetry_val[] = { + [DRM_MODE_COLORIMETRY_NO_DATA] =
HDMI_COLORIMETRY_NO_DATA,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4953
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_SMPTE_170M_YCC] =
HDMI_COLORIMETRY_SMPTE_170M_YCC,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4954
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_BT709_YCC] =
HDMI_COLORIMETRY_BT709_YCC,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4955
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_XVYCC_601] =
HDMI_COLORIMETRY_XVYCC_601,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4956
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_XVYCC_709] =
HDMI_COLORIMETRY_XVYCC_709,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4957
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_SYCC_601] =
HDMI_COLORIMETRY_SYCC_601,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4958
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_OPYCC_601] =
HDMI_COLORIMETRY_OPYCC_601,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4960
Quoted 2 lines
drivers/gpu/drm/drm_edid.c +2
-0+ [DRM_MODE_COLORIMETRY_OPRGB] = HDMI_COLORIMETRY_OPRGB, + [DRM_MODE_COLORIMETRY_BT2020_CYCC] =
HDMI_COLORIMETRY_BT2020_CYCC,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4961
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_BT2020_RGB] =
HDMI_COLORIMETRY_BT2020_RGB,drivers/gpu/drm/drm_edid.c static bool is_hdmi2_sink(struct drm_connector · line 4962
Quoted 1 line
drivers/gpu/drm/drm_edid.c +1
-0+ [DRM_MODE_COLORIMETRY_BT2020_YCC] =
HDMI_COLORIMETRY_BT2020_YCC, };Probably best to
Quoted 8 lines
Quoted 5 lines
#undef C
#undef EC
#undef ACEhere to avoid accidents.
Sure will add that. So with this fixed and DP stuff dropped, can I mark your RB on all the remaining 2 patches (DP patch will get dropped). If you confirm will resend with your RB for merge.
Yeah, I think it should be good to go in.
Quoted 80 lines
Thanks & Regards,
Uma ShankarQuoted 76 lines
With that
Reviewed-by Ville Syrjälä <[email protected]>Quoted 45 lines
drivers/gpu/drm/drm_edid.c +29
-0+ +/** +* drm_hdmi_avi_infoframe_colorspace() - fill the HDMI AVI infoframe +* colorspace information +* @frame: HDMI AVI infoframe +* @conn_state: connector state +*/ +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state) { +u32 colorimetry_val; +u32 colorimetry_index = conn_state->colorspace & +FULL_COLORIMETRY_MASK ; + +if (colorimetry_index >=ARRAY_SIZE (hdmi_colorimetry_val)) + colorimetry_val =HDMI_COLORIMETRY_NO_DATA ; +else + colorimetry_val = hdmi_colorimetry_val[colorimetry_index]; + + frame->colorimetry = colorimetry_val &NORMAL_COLORIMETRY_MASK ; +/* +* ToDo: Extend it for ACE formats as well. Modify the infoframe +* structure and extend it in drivers/video/hdmi +*/ + frame->extended_colorimetry = (colorimetry_val >>2 ) & +EXTENDED_COLORIMETRY_MASK ; +} +EXPORT_SYMBOL (drm_hdmi_avi_infoframe_colorspace); +/** * drm_hdmi_avi_infoframe_quant_range() - fill the HDMI AVI infoframe * quantization range information include/drm/drm_edid.h index renamed from include/drm/drm_edid.h +0
-08dc1a08..9d3b5b9 100644
include/drm/drm_edid.h +1
-1@@ -331,6 +331,7 @@ struct cea_sad {struct drm_encoder ;struct drm_connector ; +struct drm_connector_state ;struct drm_display_mode ; int drm_edid_to_sad(struct edid *edid, struct cea_sad **sads); @@ -358,6 +359,11 @@ int drm_av_sync_delay(struct drm_connectorQuoted 1 line
*connector, drm_hdmi_vendor_infoframe_from_display_mode(struct
hdmi_vendor_infoframe*frame,Quoted 13 lines
include/drm/drm_edid.h +5
-1struct drm_connector *connector, const struct drm_display_mode *mode); + +void +drm_hdmi_avi_infoframe_colorspace (struct hdmi_avi_infoframe *frame, +const struct drm_connector_state *conn_state); + void drm_hdmi_avi_infoframe_quant_range(struct hdmi_avi_infoframe *frame, struct drm_connector *connector, --1.9.1
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v16 4/4 drm/i915: Attach colorspace property and enable modeset
In reply to Uma Shankar via dri-develThis patch attaches the colorspace connector property to the hdmi connector. Based on colorspace change, modeset will be triggered to switch to new colorspace.
Based on colorspace property value create an infoframe with appropriate colorspace. This can be used to send an infoframe packet with proper colorspace value set which will help to enable wider color gamut like BT2020 on sink.
This patch attaches and enables HDMI colorspace, DP will be taken care separately.
v2: Merged the changes of creating infoframe as well to this patch as per Maarten's suggestion.
v3: Addressed review comments from Shashank. Separated HDMI and DP colorspaces as suggested by Ville and Maarten.
v4: Addressed Chris and Ville's review comments, and created a common colorspace property for DP and HDMI, filtered the list based on the colorspaces supported by the respective protocol standard. Handle the default case properly.
v5: Merged the DP handling along with platform colorspace handling as per Shashank's comments.
v6: Reverted to old design of exposing all colorspaces to userspace as per Ville's review comment
v7: Fixed a checkpatch complaint, Addressed Maarten' review comment, updated the RB from Maarten and Jani's ack.
v8: Moved colorspace AVI Infoframe programming to drm core and removed from driver as per Ville's suggestion.
v9: Added a check to only allow RGB colorpsaces to be set in infoframe though the colorspace property. Since there is no output csc property to control planar formats and it will be added later. Changes for RGB->YUV conversion inside driver without userspace knowledge is still supported. This is as per Ville's suggestion.
v10: Fixed an error in if check.
v11: Dropped the check for planar vs RGB and allow all the colorspaces. Onus will be on userspace to pick whatever pipe output it is able to drive.
--- drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_connector.c | 8 ++++++++ drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_hdmi.c | 13 +++++++++++++ 4 files changed, 23 insertions(+)
drivers/gpu/drm/i915/intel_atomic.c +1 -0
@@ -126,6 +126,7 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,*/ if (new_conn_state->force_audio != old_conn_state->force_audio || new_conn_state->broadcast_rgb != old_conn_state->broadcast_rgb || + new_conn_state->base.colorspace != old_conn_state->base.colorspace || new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio || new_conn_state->base.content_type != old_conn_state->base.content_type || new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode)
drivers/gpu/drm/i915/intel_connector.c +8 -0
@@ -265,3 +265,11 @@ int intel_ddc_get_modes(struct drm_connector *connector, connector->dev->mode_config.aspect_ratio_property, DRM_MODE_PICTURE_ASPECT_NONE); } + +void +intel_attach_colorspace_property (struct drm_connector *connector) +{ +if (!drm_mode_create_colorspace_property (connector)) +drm_object_attach_property (&connector->base, + connector->colorspace_property,0 ); +}
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1803,6 +1803,7 @@ int intel_connector_update_modes(struct drm_connector *connector,void intel_attach_force_audio_property (struct drm_connector *connector);void intel_attach_broadcast_rgb_property (struct drm_connector *connector);void intel_attach_aspect_ratio_property (struct drm_connector *connector); +void intel_attach_colorspace_property (struct drm_connector *connector);/* intel_csr.c */ void intel_csr_ucode_init (struct drm_i915_private *);
drivers/gpu/drm/i915/intel_hdmi.c +13 -0
@@ -498,6 +498,8 @@ static void intel_hdmi_set_avi_infoframe(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +drm_hdmi_avi_infoframe_colorspace (&frame.avi, conn_state); + drm_hdmi_avi_infoframe_quant_range(&frame.avi, conn_state->connector, adjusted_mode,
@@ -2143,10 +2145,21 @@ static void intel_hdmi_destroy(struct drm_connector *connector) intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector) { struct drm_i915_private *dev_priv = to_i915(connector->dev); +struct intel_digital_port *intel_dig_port = +hdmi_to_dig_port (intel_hdmi);intel_attach_force_audio_property (connector);intel_attach_broadcast_rgb_property (connector);intel_attach_aspect_ratio_property (connector); + +/* +* Attach Colorspace property for Non LSPCON based device +* ToDo: This needs to be extended for LSPCON implementation +* as well. Will be implemented separately. +*/ +if (!intel_dig_port->lspcon.active) +intel_attach_colorspace_property (connector); +drm_connector_attach_content_type_property (connector); connector->state->picture_aspect_ratio =HDMI_PICTURE_ASPECT_NONE ;
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✓ Fi.CI.BAT: success for Add Colorspace connector property interface (rev15)
In reply to Uma Shankar via dri-devel== Series Details ==
== Series Details ==
Series: Add Colorspace connector property interface (rev15)
URL : https://patchwork.freedesktop.org/series/47132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5596 -> Patchwork_12208
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47132/revisions/15/mbox/
Known issues
------------
Here are the changes found in Patchwork_12208 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: NOTRUN -> INCOMPLETE [fdo#103927]
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@prime_vgem@basic-fence-flip:
- fi-skl-6700k2: FAIL [fdo#104008] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (40 -> 36)
------------------------------
Additional (2): fi-gdg-551 fi-apl-guc
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-icl-y
Build changes
-------------
* Linux: CI_DRM_5596 -> Patchwork_12208
CI_DRM_5596: aaaccba122fe89ef87706ae2642dc3e3b0d256e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4820: 368237db1149033d8274248489ffec671ea1f7d8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12208: c406330e311d02c548138ba2a203e98855b1888f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c406330e311d drm/i915: Attach colorspace property and enable modeset add21f532f76 drm: Add colorspace info to AVI Infoframe 1d76daec5a79 drm: Add DP colorspace propertyf210c619441e drm: Add HDMI colorspace property
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12208/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Add Colorspace connector property interface (rev15)
In reply to Uma Shankar via dri-devel== Series Details ==
== Series Details ==
Series: Add Colorspace connector property interface (rev15)
URL : https://patchwork.freedesktop.org/series/47132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5596_full -> Patchwork_12208_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12208_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@reset-stress:
- shard-snb: PASS -> FAIL [fdo#107799]
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#103313]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-kbl: NOTRUN -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956] +7
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-c-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> FAIL [fdo#108597] +1
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-apl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#104873]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: NOTRUN -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-apl: NOTRUN -> FAIL [fdo#103167]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] +7
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590] +5
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-kbl: NOTRUN -> FAIL [fdo#103166] +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: NOTRUN -> INCOMPLETE [fdo#103665]
* igt@kms_setmode@basic:
- shard-kbl: NOTRUN -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-kbl: NOTRUN -> FAIL [fdo#100047]
#### Possible fixes ####
* igt@gem_exec_create@forked:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: FAIL [fdo#109350] -> PASS
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_flip@basic-flip-vs-modeset:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@clone-exclusive-crtc:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS +1
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-glk: INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133] -> DMESG-WARN [fdo#109244]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107799]: https://bugs.freedesktop.org/show_bug.cgi?id=107799
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (6 -> 5)
------------------------------
Additional (1): shard-kbl
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5596 -> Patchwork_12208
CI_DRM_5596: aaaccba122fe89ef87706ae2642dc3e3b0d256e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4820: 368237db1149033d8274248489ffec671ea1f7d8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12208: c406330e311d02c548138ba2a203e98855b1888f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12208/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx