net/avf: enable admin queue interrupt
PATCH 1/1 net/avf: enable admin queue interrupt
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to enable admin queue interrupt in avf mode. If not, avf will not work.
--- drivers/net/avf/avf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/avf/avf_ethdev.c +1 -1
@@ -1159,7 +1159,7 @@ avf_enable_irq0(struct avf_hw *hw)AVF_WRITE_REG (hw,AVFINT_ICR0_ENA1 ,AVFINT_ICR0_ENA1_ADMINQ_MASK );AVF_WRITE_REG (hw,AVFINT_DYN_CTL01 ,AVFINT_DYN_CTL01_INTENA_MASK | -AVFINT_DYN_CTL01_ITR_INDX_MASK ); +AVFINT_DYN_CTL01_CLEARPBA_MASK |AVFINT_DYN_CTL01_ITR_INDX_MASK );AVF_WRITE_FLUSH (hw); }
Signature · 1 line
2.7.5
Quoted 2 lines
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to enable admin queue interrupt in avf mode.
Minor nit: You misspelled enable above
Quoted 10 lines
-----Original Message-----
From: Zhao1, Wei
Sent: Wednesday, February 13, 2019 4:54 PM
To: [email protected]
Cc: Wu, Jingjing <[email protected]>; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/avf: enable admin queue interrupt
Change title to "enable CLEARPBA bit"
Quoted 3 lines
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to enable admin queue interrupt in avf mode.
If not, avf will not work.
Reword to
Enable CLEARPBA bit is required by ice NIC of A0/A1 version to enable admin queue interrupt.
Also enable CLEARPBA bit does no impact on AVF behaviour when be hosted by other devices, so we can make it as default.
Quoted 2 lines
Signed-off-by Wei Zhao <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi