Skip to contentSkip to conversation

libdrm: Fix issue about differrent domainID but same BDF

PATCH In review Emily Deng 6 participants 18 messages Feb 14, 2019 – Apr 24, 2019 7 messages not in the archive

lore
Share & tools
lore

Emily Deng

author
#0 lore raw

PATCH 1/1 libdrm: Fix issue about differrent domainID but same BDF

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then return the wrong fd for Card1.

Solution:
First loop search the best match fd about drm 1.4.

---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +23 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int type)
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1550130818-28008-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Ping ......

Quoted 71 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Emily Deng
Sent: Thursday, February 14, 2019 3:54 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>
Subject: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then return the wrong fd for Card1.

Solution:
First loop search the best match fd about drm 1.4.

---
xf86drm.c | 23 +++++++++++++++++++++++

1 file changed, 23 insertions(+)
xf86drm.c +23 -1
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int type)
    if (base < 0)
        return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
    drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
    for (i = base; i < base + DRM_MAX_MINOR; i++) {
        fd = drmOpenMinor(i, 1, type);
        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
        if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
            /* We need to try for 1.4 first for proper PCI domain support
             * and if that fails, we know the kernel is busted
             */
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN7PR12MB2644A7102ED822368B763A078F600-Zx/IyJUqfGKoYeSiBV3SvgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#4 lore raw

Ping ......

Best wishes
Emily Deng

Quoted 41 lines

-----Original Message-----
From: Deng, Emily <[email protected]>
Sent: Friday, February 15, 2019 11:51 AM
To: Deng, Emily <[email protected]>; [email protected]
Subject: RE: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Ping ......

Quoted 12 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Emily Deng
Sent: Thursday, February 14, 2019 3:54 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>
Subject: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 10 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open
Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 9 lines

Solution:
First loop search the best match fd about drm 1.4.

---
xf86drm.c | 23 +++++++++++++++++++++++

1 file changed, 23 insertions(+)
Quoted 47 lines

xf86drm.c static int drmOpenByBusid(const char *busid, int

Quoted 5 lines
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int

type)

Quoted 41 lines
xf86drm.c +23 -1
    if (base < 0)
        return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
    drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
    for (i = base; i < base + DRM_MAX_MINOR; i++) {
        fd = drmOpenMinor(i, 1, type);
        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
        if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
            /* We need to try for 1.4 first for proper PCI domain support
             * and if that fails, we know the kernel is busted
             */
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive

Hi Emily,

Please note that code outside of amdgpu/ is used by all open source drivers. Thus patches should have dri-deve@ in to/cc as mentioned in CONTRIBUTING

Quoted 13 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then return the wrong fd for Card1.

Quoted 3 lines

Solution:
First loop search the best match fd about drm 1.4.

First and foremost, I wish we can stop using using these legacy APIs. They're fairly fragile and as you can see the are strange things happening.
We could instead use drmGetDevices2() to gather a list of devices and pick the one we're interested.

That aside, I think we can do a slightly better fix. Have you tried:
- resetting the pci_domain_ok=1 on each iteration, and
- continuing to the next device when the second
drmSetInterfaceVersion() call fails

AFAICT it should produce the same result, while being shorter and faster.

Thanks
-Emil
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CACvgo53wFUrLsLoj4gbAVfJDUPX_cGPP73RNsCqJCvN6sQ3nFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#7 lore raw

Hi Emil,
Understand, thanks.

Best wishes
Emily Deng

Quoted 42 lines

-----Original Message-----
From: Emil Velikov <[email protected]>
Sent: Friday, February 15, 2019 11:02 PM
To: Deng, Emily <[email protected]>
Cc: amd-gfx mailing list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Hi Emily,

Please note that code outside of amdgpu/ is used by all open source drivers. Thus patches should have dri-deve@ in to/cc as mentioned in CONTRIBUTING

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 9 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 4 lines

Solution:
First loop search the best match fd about drm 1.4.

First and foremost, I wish we can stop using using these legacy APIs. They're fairly fragile and as you can see the are strange things happening. We could instead use drmGetDevices2() to gather a list of devices and pick the one we're interested.

That aside, I think we can do a slightly better fix. Have you tried:
- resetting the pci_domain_ok=1 on each iteration, and
- continuing to the next device when the second drmSetInterfaceVersion() call fails

Quoted 4 lines

AFAICT it should produce the same result, while being shorter and faster.

Thanks
-Emil

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#8 lore raw
In reply to a message not in the archive

Hi Emil,
I don't understand your idea clear about follow, what about the case that only has 1 GPU, and don't support pci_domain? For this case, it still need to fallback to pci_domain_ok=0.

Quoted 4 lines

That aside, I think we can do a slightly better fix. Have you tried:
- resetting the pci_domain_ok=1 on each iteration, and
- continuing to the next device when the second drmSetInterfaceVersion() call fails

Best wishes
Emily Deng

Quoted 42 lines

-----Original Message-----
From: Emil Velikov <[email protected]>
Sent: Friday, February 15, 2019 11:02 PM
To: Deng, Emily <[email protected]>
Cc: amd-gfx mailing list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Hi Emily,

Please note that code outside of amdgpu/ is used by all open source drivers. Thus patches should have dri-deve@ in to/cc as mentioned in CONTRIBUTING

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 9 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 4 lines

Solution:
First loop search the best match fd about drm 1.4.

First and foremost, I wish we can stop using using these legacy APIs. They're fairly fragile and as you can see the are strange things happening. We could instead use drmGetDevices2() to gather a list of devices and pick the one we're interested.

That aside, I think we can do a slightly better fix. Have you tried:
- resetting the pci_domain_ok=1 on each iteration, and
- continuing to the next device when the second drmSetInterfaceVersion() call fails

Quoted 4 lines

AFAICT it should produce the same result, while being shorter and faster.

Thanks
-Emil

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#9 lore raw

Hi Emily,

Quoted 3 lines · Emily

Hi Emil,
I don't understand your idea clear about follow, what about the case that only has 1 GPU, and don't support pci_domain? For this case, it still need to fallback to pci_domain_ok=0.

I'm struggling to understand - seems like some of the grammar is off. Can you elaborate?

Aside: interleaved posting style is used for open-source development (kernel&libdrm at least). Please use tweak your apps to produce it.

Thanks
Emil

[1] https://www.extendoffice.com/documents/outlook/4006-outlook-reply-quote.html
See "Reply With Quoting Original Message In Outlook" although try to use interleaved [2]/bottom posting style.
[2] https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw
In reply to a message not in the archive

Adding dri-devel.

Quoted 63 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then return the wrong fd for Card1.

Solution:
First loop search the best match fd about drm 1.4.

---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +23 -1
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int type)
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_NSE5bGqYQskncJ3opUVtnjrOWu8vg-Vt5cZVwZ-Woqaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#12 lore raw

Thanks Alex to help to add the dri-devel.

Best wishes
Emily Deng

Quoted 35 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 15, 2019 11:14 PM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Adding dri-devel.

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 9 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 9 lines

Solution:
First loop search the best match fd about drm 1.4.

---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Quoted 47 lines

xf86drm.c static int drmOpenByBusid(const char *busid, int

Quoted 5 lines
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int

type)

Quoted 41 lines
xf86drm.c +23 -1
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#13 lore raw

Ping ......

Quoted 96 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Deng, Emily
Sent: Monday, February 18, 2019 10:17 AM
To: Alex Deucher <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: RE: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Thanks Alex to help to add the dri-devel.

Best wishes
Emily Deng

Quoted 80 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 15, 2019 11:14 PM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Adding dri-devel.

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 10 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 14 lines

Solution:
First loop search the best match fd about drm 1.4.

---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid,
Quoted 1 line

int

type)

Quoted 37 lines
     if (base < 0)
         return -1;
xf86drm.c +23 -1
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by
#14 lore raw
In reply to a message not in the archive
Quoted 13 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then return the wrong fd for Card1.

Quoted 4 lines

Solution:
First loop search the best match fd about drm 1.4.

Do you need someone to commit this for you?

Alex

Quoted 46 lines
---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +23 -1
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int type)
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_Mny2NtWS1g07k+mKJngrCYk+9HzKiTVE9rMxM9vy9Uug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#16 lore raw

Hi Alex,
Please help, thanks.

Best wishes
Emily Deng

Quoted 40 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 22, 2019 12:13 AM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 9 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 5 lines

Solution:
First loop search the best match fd about drm 1.4.

Do you need someone to commit this for you?

Alex

Quoted 4 lines
---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Quoted 47 lines

xf86drm.c static int drmOpenByBusid(const char *busid, int

Quoted 5 lines
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int

type)

Quoted 41 lines
xf86drm.c +23 -1
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN7PR12MB2644451E74B12311A8F32CE28F7F0-Zx/IyJUqfGKoYeSiBV3SvgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#18 lore raw

Pushed. Thanks!

Alex

Quoted 96 lines · Emily

Hi Alex,
Please help, thanks.

Best wishes
Emily Deng

Quoted 87 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 22, 2019 12:13 AM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 9 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 5 lines

Solution:
First loop search the best match fd about drm 1.4.

Do you need someone to commit this for you?

Alex

xf86drm.c static int drmOpenByBusid(const char *busid, int

Quoted 9 lines
---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int

type)

Quoted 41 lines
xf86drm.c +23 -1
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#19 lore raw

Thank you very much.

Best wishes
Emily Deng

Quoted 9 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Saturday, February 23, 2019 5:05 AM
To: Deng, Emily <[email protected]>
Cc: Maling list - DRI developers <[email protected]>; amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 104 lines

Pushed. Thanks!

Alex

Quoted 99 lines · Emily

Hi Alex,
Please help, thanks.

Best wishes
Emily Deng

Quoted 90 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 22, 2019 12:13 AM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 10 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 5 lines

Solution:
First loop search the best match fd about drm 1.4.

Do you need someone to commit this for you?

Alex

Quoted 10 lines
---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid,

int

type)

Quoted 42 lines
     if (base < 0)
         return -1;
xf86drm.c +24 -1
+    /* We need to try for 1.4 first for proper PCI domain support
+ */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#20 lore raw
In reply to Alex Deucher

Hi all,

This patch causes unnecessary round trip by openning the nodes. As mentioned previously this could be trivially fixed [1].

Even Emily acknowledged that [1], yet the sub-par fix was merged. Can we revert+fixup this properly?

Thanks
Emil

[1] https://lists.freedesktop.org/archives/amd-gfx/2019-February/031573.html

Quoted 98 lines · Alex Deucher

Pushed. Thanks!

Alex

Quoted 92 lines · Emily

Hi Alex,
Please help, thanks.

Best wishes
Emily Deng

Quoted 83 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 22, 2019 12:13 AM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 4 lines · Emily Deng

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 9 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 5 lines

Solution:
First loop search the best match fd about drm 1.4.

Do you need someone to commit this for you?

Alex

xf86drm.c static int drmOpenByBusid(const char *busid, int

Quoted 9 lines
---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +0 -0
index 336d64d..b60e029 100644
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char *busid, int

type)

Quoted 37 lines
xf86drm.c +23 -1
     if (base < 0)
         return -1;
 
+    /* We need to try for 1.4 first for proper PCI domain support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#21 lore raw
Quoted 10 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Emil Velikov
Sent: Monday, February 25, 2019 8:09 AM
To: Alex Deucher <[email protected]>
Cc: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>; amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 8 lines

Hi all,

This patch causes unnecessary round trip by openning the nodes. As mentioned previously this could be trivially fixed [1].

Even Emily acknowledged that [1], yet the sub-par fix was merged. Can we revert+fixup this properly?

Sorry, I totally missed your reply. I'm having Internet issues at the moment so if you want to revert for now, I'll work with Emily to address your suggestions later in the week or next. Emily, can you take a look at addressing Emil's concerns with an updated patch?

Alex

Quoted 114 lines

Thanks
Emil

[1] https://lists.freedesktop.org/archives/amd-gfx/2019-
February/031573.html

Quoted 6 lines · Alex Deucher

Pushed. Thanks!

Alex

On Thu, Feb 21, 2019 at 9:36 PM Deng, Emily <[email protected]>

Quoted 19 lines · wrote:
Quoted 19 lines

Hi Alex,
Please help, thanks.

Best wishes
Emily Deng

Quoted 10 lines

-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Friday, February 22, 2019 12:13 AM
To: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

On Thu, Feb 14, 2019 at 2:53 AM Emily Deng <[email protected]>

Quoted 40 lines · wrote:
Quoted 40 lines
Quoted 40 lines
Quoted 4 lines

For multiple GPUs which has the same BDF, but has different domain ID, the drmOpenByBusid will return the wrong fd when startx.

Quoted 10 lines

The reproduce sequence as below:
1. Call drmOpenByBusid to open Card0, then will return the right fd0, and the
fd0 is master privilege;
2. Call drmOpenByBusid to open Card1. In function drmOpenByBusid, it will open Card0 first, this time, the fd1 for opening Card0 is not master privilege, and will call drmSetInterfaceVersion to identify the domain ID feature, as the fd1 is not master privilege, then drmSetInterfaceVersion will fail, and then won't compare domain ID, then

return the wrong fd for Card1.

Quoted 5 lines

Solution:
First loop search the best match fd about drm 1.4.

Do you need someone to commit this for you?

Alex

xf86drm.c static int drmOpenByBusid(const char · line 584

Quoted 9 lines
---
 xf86drm.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
xf86drm.c +0 -0
@@ -584,11 +584,34 @@ static int drmOpenByBusid(const char
 *busid, int

type)

Quoted 3 lines
xf86drm.c +0 -0
     if (base < 0)
         return -1;
 
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
xf86drm.c +2 -0
+    /* We need to try for 1.4 first for proper PCI domain
+ support */
     drmMsg("drmOpenByBusid: Searching for BusID %s\n", busid);
     for (i = base; i < base + DRM_MAX_MINOR; i++) {
         fd = drmOpenMinor(i, 1, type);
         drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
Quoted 8 lines
Quoted 8 lines

xf86drm.c static int drmOpenByBusid(const char · line 601

Quoted 8 lines
xf86drm.c +7 -0
         if (fd >= 0) {
+            sv.drm_di_major = 1;
+            sv.drm_di_minor = 4;
+            sv.drm_dd_major = -1;        /* Don't care */
+            sv.drm_dd_minor = -1;        /* Don't care */
+            if (!drmSetInterfaceVersion(fd, &sv)) {
+                buf = drmGetBusid(fd);
+                drmMsg("drmOpenByBusid: drmGetBusid reports %s\n",

buf);

Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
xf86drm.c +15 -1
+                if (buf && drmMatchBusID(buf, busid, 1)) {
+                    drmFreeBusid(buf);
+                    return fd;
+                }
+                if (buf)
+                    drmFreeBusid(buf);
+            }
+            close(fd);
+        }
+    }
+
+   for (i = base; i < base + DRM_MAX_MINOR; i++) {
+        fd = drmOpenMinor(i, 1, type);
+        drmMsg("drmOpenByBusid: drmOpenMinor returns %d\n", fd);
+        if (fd >= 0) {
             /* We need to try for 1.4 first for proper PCI domain support
              * and if that fails, we know the kernel is busted
              */
--

2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Quoted 8 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#22 lore raw
Quoted 13 lines · Alexander
Quoted 13 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Emil Velikov
Sent: Monday, February 25, 2019 8:09 AM
To: Alex Deucher <[email protected]>
Cc: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>; amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Hi all,

Quoted 9 lines
Quoted 6 lines

This patch causes unnecessary round trip by openning the nodes. As mentioned previously this could be trivially fixed [1].

Even Emily acknowledged that [1], yet the sub-par fix was merged. Can we revert+fixup this properly?

Sorry, I totally missed your reply. I'm having Internet issues at the moment so if you want to revert for now, I'll work with Emily to address your suggestions later in the week or next. Emily, can you take a look at addressing Emil's concerns with an updated patch?

Doesn't seem like there's any follow-up work on this, so I've reverted this for now.
I'm a sad panda for doing it - hopefully v2 will come shortly.

-Emil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): CACvgo53kFFRbrr+DHd6sizDQTK7TYTKN0JHHWrOL1Wk9-+gS7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#24 lore raw

Hi Emil and Alex,
Sorry for miss your emails. I will update a new patch as Emil's suggestion.

Best wishes
Emily Deng

Quoted 40 lines

-----Original Message-----
From: Emil Velikov <[email protected]>
Sent: Thursday, April 18, 2019 2:26 AM
To: Deucher, Alexander <[email protected]>
Cc: Alex Deucher <[email protected]>; Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>; amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Quoted 17 lines · Alexander
Quoted 17 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Emil Velikov
Sent: Monday, February 25, 2019 8:09 AM
To: Alex Deucher <[email protected]>
Cc: Deng, Emily <[email protected]>; Maling list - DRI developers <dri- [email protected]>; amd-gfx list <[email protected]>
Subject: Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

Hi all,

This patch causes unnecessary round trip by openning the nodes. As mentioned previously this could be trivially fixed [1].

Quoted 6 lines
Quoted 4 lines

Even Emily acknowledged that [1], yet the sub-par fix was merged. Can we
revert+fixup this properly?

Sorry, I totally missed your reply. I'm having Internet issues at the moment

so if you want to revert for now, I'll work with Emily to address your suggestions later in the week or next. Emily, can you take a look at addressing Emil's concerns with an updated patch?

Quoted 1 line
Quoted 6 lines

Doesn't seem like there's any follow-up work on this, so I've reverted this for now.
I'm a sad panda for doing it - hopefully v2 will come shortly.

-Emil

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx