net: stmmac: use correct define to get rx timestamp on GMAC4
Subsystems (4)
PATCH v2 1/1 net: stmmac: use correct define to get rx timestamp on GMAC4
In dwmac4_wrback_get_rx_timestamp_status we looking for a RX timestamp. For that receive descriptors are handled and so we should use defines related to receive descriptors. It'll no change the functional behavior as RDES3_RDES1_VALID=TDES3_RS1V=BIT(26) but it makes code easier to read.
---
changes since v1:
*use le32_to_cpu to handle endianess
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c +1 -1
@@ -268,7 +268,7 @@ static int dwmac4_wrback_get_rx_timestamp_status(void *desc, void *next_desc,int ret = -EINVAL ;/* Get the status from normal w/b descriptor */ -if (likely (p->des3 &TDES3_RS1V )) { +if (likely (le32_to_cpu (p->des3) &RDES3_RDES1_VALID )) {if (likely (le32_to_cpu (p->des1) &RDES1_TIMESTAMP_AVAILABLE )) {int i =0 ;
Signature · 7 lines
2.7.4 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Alexandre Torgue <[email protected]>
Date: Thu, 14 Feb 2019 17:03:44 +0100
Quoted 6 lines
In
dwmac4_wrback_get_rx_timestamp_statuswe looking for a RX timestamp. For that receive descriptors are handled and so we should use defines related to receive descriptors. It'll no change the functional behavior as RDES3_RDES1_VALID=TDES3_RS1V=BIT(26) but it makes code easier to read.Signed-off-by Alexandre Torgue <[email protected]>
Applied.